From:   Eric Snowberg <eric.snowberg@oracle.com>
To:     keyrings@vger.kernel.org, linux-integrity@vger.kernel.org,
        zohar@linux.ibm.com, dhowells@redhat.com, dwmw2@infradead.org,
        herbert@gondor.apana.org.au, davem@davemloft.net,
        jarkko@kernel.org, jmorris@namei.org, serge@hallyn.com
Cc:     eric.snowberg@oracle.com, keescook@chromium.org,
        torvalds@linux-foundation.org, weiyongjun1@huawei.com,
        nayna@linux.ibm.com, ebiggers@google.com, ardb@kernel.org,
        nramas@linux.microsoft.com, lszubowi@redhat.com, jason@zx2c4.com,
        linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
        linux-efi@vger.kernel.org, linux-security-module@vger.kernel.org,
        James.Bottomley@HansenPartnership.com, pjones@redhat.com,
        konrad.wilk@oracle.com
Subject: [PATCH v8 02/17] integrity: Fix warning about missing prototypes
Date:   Tue, 23 Nov 2021 23:41:09 -0500
Message-Id: <20211124044124.998170-3-eric.snowberg@oracle.com>
In-Reply-To: <20211124044124.998170-1-eric.snowberg@oracle.com>
References: <20211124044124.998170-1-eric.snowberg@oracle.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?i8ShooSxg13yg5NjL7CzOVaTKypcTKizbYThKmzcGiG6SSN3YViyOmjEY7gj?=
 =?us-ascii?Q?mrUAwc7lST7nycDE9zGqozXKmambzxITjMAAK6Nmo82mpMyaNspZMGA9c+Qr?=
 =?us-ascii?Q?gmz5isULLkjmFtYqguHcSg8pYB5P4KIqzQCgh5xulPIsVDy6YWOrm6DljJtr?=
 =?us-ascii?Q?cCd3+wylNvlJ7cPHyRfCHD9N60I/yBCEmg6h2eZ2bWDewMSZrgG84qlWH+lB?=
 =?us-ascii?Q?bjUzh4l3Xa4gTfCglRd1jJ6Yd8CqO2+iA+bs0Z7CXC8e5K9aj45RDMDCZN2c?=
 =?us-ascii?Q?4e1xwkK71FoVPIPBEmZfynuboCQ2hMNd2B85cKB3Vh4vh6AjjIITjl3dXely?=
 =?us-ascii?Q?2kCA7gm8FiXU3GQ801aZZRgnwpskmbfCVFDI5wrcWd1iBhvt8dOTr3agYeHU?=
 =?us-ascii?Q?+ts1P6NvhVQsgezIQu2PZDjxBCrx+jPzHqsh4n4ysR4Mys2kzzvUYBfngRRK?=
 =?us-ascii?Q?sK/kFcXSfDS0e3dMpQtLf765ZQFDa6m2pYW5GujbQDGVqBcdZFK4SBySBvNo?=
 =?us-ascii?Q?puIFzCYIcwcfIHPomNAzIlC3r/eT8S7sCoGSeOUibATDCMZXzCve/UNp0maA?=
 =?us-ascii?Q?XtDun/EAOvd/pFLthCPJsgGCvH6Rn0/vSYhCz4SZQRw53S8I4vB72MfX7UJH?=
 =?us-ascii?Q?DkAG8zrJ0n7kaAHspQw4xYGiU5wQbgfErc/mqwILl3pGBNv00rfa0/Ydk7xp?=
 =?us-ascii?Q?fCXwAjEv0bjGI4FcCjkulz7YOQca5qUST1b/HcX3cb2d8zA49Hz2N35C/tV1?=
 =?us-ascii?Q?fohq3rrnAJ5BunRcmurM176waVbcnpxd1MtdTpPHy3lps1A9I6jzjEqfmD1U?=
 =?us-ascii?Q?s4hgV7PzeGbYAAB0LHgQlSZts5XneNPrKfHQLn7Z0EpMWZdcHyrxr0psF0hj?=
 =?us-ascii?Q?W4AhSY/k8eCVOjHGbuQ19j13psEpvTEPlfkR9F23VxmLh1pwZmZU/8L7wjfF?=
 =?us-ascii?Q?qiWKdT9C4xEaC2XXJOYmeb2F9o5c2gmlltDAx2f29qy0wf98GSe1f2flxgzz?=
 =?us-ascii?Q?iY7cqJ64wxhyZolp/FnV9mK1t7gARTY9FexmN7ckm9jXEa7CzyUPNCmihTlZ?=
 =?us-ascii?Q?EtiiEQbjLwI353VtoCKd4A3uR5j1DatrHzEWERGv6xsJIre6YF1hizAunN+A?=
 =?us-ascii?Q?Q1nhg9z20mNsNhJ+s0K5dmLTxvIhTEjxUe7MkXXtSMbVRyl2bEebuJI07vvJ?=
 =?us-ascii?Q?fIaVId817a9Qx1UCqJFYjgCkJSnJzR8XBS1p42gfO5HcsuXikfaHnzWEGUKW?=
 =?us-ascii?Q?NMu3nH1DUppnFRFPwRQ4iUClTfi6UzOhIVbZhyXZlUlo0BwG3eeCYe2mBw9g?=
 =?us-ascii?Q?0dFfllXtlhSTVaCT8HW2Ja+64hs1rzwswkLrdQuuG2jx3qNluAqTHS0rNoA4?=
 =?us-ascii?Q?TKmcsWEwn505/2sROJcl2im/i3WEbTSVkqYhnaWZlxkENwut4jqyxuhtseYk?=
 =?us-ascii?Q?h8HDf3V3xjgRpQ4n9RYK22HYlUKWx7m2RsK2xsUoxFxp8h7cNWZmG+8y8xUJ?=
 =?us-ascii?Q?iTyiv9aYMBF2yyIOCNhMURuRZ1dIa3r8OSTgeczOipokk9zlatdNZSa8Pcc4?=
 =?us-ascii?Q?iFQxsA6dHiO5+FD0craVAfjIszPUbq+XyzhDO3VqAocgUozC9Zw01HK7EnsS?=
 =?us-ascii?Q?ZjfXyiBPcaCUhxOuhsRT7/9oq75brMTbWj80CGF1HvHS9MQLzLdl+gxeIDl+?=
 =?us-ascii?Q?sitnjw=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 247c203f-72ad-4014-834e-08d9af04bfd4
X-MS-Exchange-CrossTenant-AuthSource: CH2PR10MB4150.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Nov 2021 04:41:58.4404
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rG8pp3VYm2a+WmMwK5iWxoO+s/Ke4eO9JpKqKxkNT+lBemn4XjruR1HCpJTJEjOFgiaSYlMBUyn/XvsSAtb4nvMf4UCbqI26lQTpt+HoO3Q=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR10MB3957
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10177 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxscore=0 spamscore=0
 mlxlogscore=999 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2111240026
X-Proofpoint-GUID: AZLGD8RpId_qpZ9c8Znpjzy0FRHZJnra
X-Proofpoint-ORIG-GUID: AZLGD8RpId_qpZ9c8Znpjzy0FRHZJnra
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

make W=1 generates the following warning in keyring_handler.c

security/integrity/platform_certs/keyring_handler.c:71:30: warning: no previous prototype for get_handler_for_db [-Wmissing-prototypes]
 __init efi_element_handler_t get_handler_for_db(const efi_guid_t *sig_type)
                              ^~~~~~~~~~~~~~~~~~
security/integrity/platform_certs/keyring_handler.c:82:30: warning: no previous prototype for get_handler_for_dbx [-Wmissing-prototypes]
 __init efi_element_handler_t get_handler_for_dbx(const efi_guid_t *sig_type)
                              ^~~~~~~~~~~~~~~~~~~
Add the missing prototypes by including keyring_handler.h.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Eric Snowberg <eric.snowberg@oracle.com>
Reviewed-by: Mimi Zohar <zohar@linux.ibm.com>
---
v7: Initial version
v8: Code unmodified from v7 added Mimi's Reviewed-by
---
 security/integrity/platform_certs/keyring_handler.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/security/integrity/platform_certs/keyring_handler.c b/security/integrity/platform_certs/keyring_handler.c
index 5604bd57c990..e9791be98fd9 100644
--- a/security/integrity/platform_certs/keyring_handler.c
+++ b/security/integrity/platform_certs/keyring_handler.c
@@ -9,6 +9,7 @@
 #include <keys/asymmetric-type.h>
 #include <keys/system_keyring.h>
 #include "../integrity.h"
+#include "keyring_handler.h"
 
 static efi_guid_t efi_cert_x509_guid __initdata = EFI_CERT_X509_GUID;
 static efi_guid_t efi_cert_x509_sha256_guid __initdata =
-- 
2.18.4