Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31428C433F5 for ; Tue, 30 Nov 2021 18:15:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245369AbhK3STR (ORCPT ); Tue, 30 Nov 2021 13:19:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52652 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239483AbhK3STR (ORCPT ); Tue, 30 Nov 2021 13:19:17 -0500 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B4C6FC061574; Tue, 30 Nov 2021 10:15:57 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 842FBCE1AF9; Tue, 30 Nov 2021 18:15:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B56B4C53FC7; Tue, 30 Nov 2021 18:15:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1638296153; bh=KszbXaHbfOc2Nhur115bSEzw+sxwzvVpgaoXce0hUeU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pvoBhd3HTrfwP/+FCfUG763klv8OrF/++24trInXsRoQ+avLpr+z0q/0jj/luWbPJ 0rwuyx2LhQKj52N5hpDHs4FuXRw11OLjVWunfDFDXoFKTMl5ZzWjK058CYRsNeiPVZ E6kbLcPkUQcGKZ+dmTXXE36mkPbphNcNwte52S23AENgBhu3PWjSGZnnORI+p0xqAV 7qDW+1sPQYqArCNmryQFLq8SzihNEscYcGRTbdtz7gUfwJDZ6ehgie8/HgiFN7z+Qm VbUZyboZMswuZFrjPuoYTH1OtgfRf+ZOazEmnfVK4k1Snou75crhMV/36Y3AskKZW1 VRvHNXSgkJTag== Date: Tue, 30 Nov 2021 10:15:51 -0800 From: Eric Biggers To: Greg Kroah-Hartman Cc: Simo Sorce , Jeffrey Walton , Stephan Mueller , "Jason A. Donenfeld" , Tso Ted , Linux Crypto Mailing List , Willy Tarreau , Nicolai Stange , LKML , Arnd Bergmann , "Eric W. Biederman" , "Alexander E. Patrakov" , "Ahmed S. Darwish" , Matthew Garrett , Vito Caputo , Andreas Dilger , Jan Kara , Ray Strode , William Jon McCann , zhangjs , Andy Lutomirski , Florian Weimer , Lennart Poettering , Peter Matthias , Marcelo Henrique Cerri , Neil Horman , Randy Dunlap , Julia Lawall , Dan Carpenter , Andy Lavr , Petr Tesarik , John Haxby , Alexander Lobakin , Jirka Hladky Subject: Re: [PATCH v43 01/15] Linux Random Number Generator Message-ID: References: <2036923.9o76ZdvQCi@positron.chronox.de> <22137816.pfsBpAd9cS@tauon.chronox.de> <9311513.S0ZZtNTvxh@tauon.chronox.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, Nov 30, 2021 at 04:45:44PM +0100, Greg Kroah-Hartman wrote: > > And the main question here is, how can we get there, in any case, if > > the maintainer of the random device doesn't even participate in > > discussions, does not pick obvious bug fixes and is simply not engaging > > at all? > > What obvious bug fixes have been dropped? > The RNDRESEEDCRNG ioctl was totally broken, and I sent out a patch to fix it which was ignored for months: https://lore.kernel.org/linux-crypto/20200916041908.66649-1-ebiggers@kernel.org/ Reminders didn't help: First ping: https://lore.kernel.org/linux-crypto/20201007035021.GB912@sol.localdomain/ Second ping: https://lore.kernel.org/linux-crypto/20201026163343.GA858@sol.localdomain/ Third ping: https://lore.kernel.org/linux-crypto/X7gQXgoXHHEr6HXC@sol.localdomain/ Fourth ping: https://lore.kernel.org/linux-crypto/X%2FNkrKpaIBTjQzbv@sol.localdomain/ Resent to Andrew Morton: https://lore.kernel.org/linux-crypto/20210112192818.69921-1-ebiggers@kernel.org/ Pinged Andrew: https://lore.kernel.org/linux-crypto/YBiEJ9Md60HjAWJg@sol.localdomain/ Finally *you* took the patch: https://lore.kernel.org/linux-crypto/YBwZ1a0VIdpTDNuD@kroah.com/ Here's another random.c bug fix which was ignored, this one for 6 months before Herbert Xu finally took it through the crypto tree: https://lore.kernel.org/linux-crypto/20210322051347.266831-1-ebiggers@kernel.org/ Here's a dead code cleanup which was ignored for 6 months before being taken by Herbert Xu through the crypto tree: https://lore.kernel.org/linux-crypto/20200916043652.96640-1-ebiggers@kernel.org/ Here's a patch to random.c which was taken by the arm64 maintainers due to being ignored by the random.c maintainer: https://lore.kernel.org/lkml/20201105152944.16953-1-ardb@kernel.org/ So unfortunately, as far as I can tell, Ted is not maintaining random.c anymore. - Eric