From:   "Bae, Chang Seok" <chang.seok.bae@intel.com>
To:     Peter Zijlstra <peterz@infradead.org>
CC:     Thomas Gleixner <tglx@linutronix.de>, Borislav Petkov <bp@suse.de>,
        "Dave Hansen" <dave.hansen@linux.intel.com>,
        "mingo@kernel.org" <mingo@kernel.org>,
        "Lutomirski, Andy" <luto@kernel.org>,
        "x86@kernel.org" <x86@kernel.org>,
        "herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "Williams, Dan J" <dan.j.williams@intel.com>,
        "Gairuboyina, Charishma1" <charishma1.gairuboyina@intel.com>,
        "Dwarakanath, Kumar N" <kumar.n.dwarakanath@intel.com>,
        "Krishnakumar, Lalithambika" <lalithambika.krishnakumar@intel.com>,
        "Shankar, Ravi V" <ravi.v.shankar@intel.com>
Subject: Re: [PATCH v3 11/15] crypto: x86/aes-kl - Support AES algorithm using
 Key Locker instructions
Thread-Topic: [PATCH v3 11/15] crypto: x86/aes-kl - Support AES algorithm
 using Key Locker instructions
Thread-Index: AQHX4W/kZoA3rQNJf0mSmN0oRVVbp6wfTOMAgAbBxgA=
Date:   Mon, 6 Dec 2021 21:32:29 +0000
Message-ID: <92B42C5B-ABB1-4CCA-ACD7-3828DAD0FE8E@intel.com>
References: <20211124200700.15888-1-chang.seok.bae@intel.com>
 <20211124200700.15888-12-chang.seok.bae@intel.com>
 <YajWYuwFAy81VP5t@hirez.programming.kicks-ass.net>
In-Reply-To: <YajWYuwFAy81VP5t@hirez.programming.kicks-ass.net>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?TtbM2vDzs0JkbJdm8AOM8OAibEyQiW8eiMZNivIeAB3t8IK+WPeRLS0JyOh8?=
 =?us-ascii?Q?pGLUQg3P8rPnx86RSdk0AnkS6VDslPPR11etS/Lp0ph45MB9H/+pk72QX7iR?=
 =?us-ascii?Q?ScdnpTmpv9pu+6O+SQcy9dR0IDOUBIZ99pEq9CYCMnqB5U/ODBIF+DLDlakq?=
 =?us-ascii?Q?U/LxGSXAKPltzvbKrZUG/KkQfL3Xrq7CAMnaJ20sPRCVS6xtBIGRsv3g4VM7?=
 =?us-ascii?Q?FN3OaliXM6p+mx18nXzZWGkD86KTpSBmbz+9ePxhQZdX0EFt7ITFaJLgLNuM?=
 =?us-ascii?Q?MxyB4oTy6JJxa9Y6LHful8fblpNUYIpoTqrv7bFj2ZDt91He2YUnEnTTSAFb?=
 =?us-ascii?Q?/CgaFUtHoKLYTsw52jnxwD80R8gwcQToVUnJT2eb851IaMj8ohFkv2OllstP?=
 =?us-ascii?Q?HGaNG9rS6fMk/cNPoWFFvo2CgBVBKzGEPdBLSbQQbFJj8qVAMJZ/PZD+cWdj?=
 =?us-ascii?Q?ZUv1DkWvRdhavT/e8jXjABxghHBGA+WZlT+AA3h25/BZnssx5eoys2JFbKhh?=
 =?us-ascii?Q?D8gjByQvMhHGljU4W+p2mBRyQ4cLck6QhGGPGorn5XM/yJULPbsIjjPxHMmf?=
 =?us-ascii?Q?l0WPjartc5OOqlXGdf0kVJnDht11Uu7qSqXfW1ZWeQj8OER8WB73/RRUICti?=
 =?us-ascii?Q?cNDFBfG+HD5GIMxFSvkRq+TO8R24k46RbL4rRzVWu8mdCHFMGalavrTqo7Ze?=
 =?us-ascii?Q?2DlL7FOWOV2kuTqL1wqjh+TCi5EfcdUwUWLu61vVu8ZlCNL8GNZIeIN9fPU3?=
 =?us-ascii?Q?neBBVvzDaIaMu7C+MnK9vpOqNoYSwGKNLe4Gypd30FCUda5DAW2GoRQOQUqb?=
 =?us-ascii?Q?jOt/XWsVlbyYiJ+iPtiLxqaa9IbvpEzkFIm0fAOJAe8SN90xY1MLdFyFQ9T7?=
 =?us-ascii?Q?wX/7pzAonItS9W5TwVv2sfKa6380RSQ0GavrzqgDdZBfkQ2Li2Vaior6OQU5?=
 =?us-ascii?Q?vleH6GETjyqk5A2ZlO8Rkyx1YkhvcdLh4VXqhHUizTo0yfnbZUawQt7tW4Jx?=
 =?us-ascii?Q?bLQrBU1gObxQzvGyz4KIQPsgGNwdBIR/hd77G/szY3v1xirWSNjuXJo10l3m?=
 =?us-ascii?Q?3RG8KEPfBuEc9lJozcmnAdudGH79EEH6HJZSDLsEeFEd3tjvoe0pkB22OZKc?=
 =?us-ascii?Q?PGalgOhRglX72Y3HSYnkjDc6a+XpqHvZgxAHPoQNBOcVebR3AxjA9uLTe+CE?=
 =?us-ascii?Q?y34/s0SAWNpfGhoUs9VJK2VeYnihV585zYdaE4eePG9gtavGVcscDVSs2rrf?=
 =?us-ascii?Q?/ifpusv/rY0BW5XnCpChWFzLy2GKSbR8I/t60j5Sl2QWDtaBSipIJTDiN8/O?=
 =?us-ascii?Q?xmw6Hw2zxI+roPTu1ESqGeJnZuNOe78ky3dSj+8HaACvGlsdbUr6R1TRzXo2?=
 =?us-ascii?Q?AaUcEv/X1d29sSCD+nNwWvi/GczuMxpTQYtk4JN8FwcQeYEeZP3dgHyR5JIY?=
 =?us-ascii?Q?/i4byvSSl2gDOdgy92B8xNEOuu34bK0AwztqODi63KCqmSqPDBIkqWgjOTZ5?=
 =?us-ascii?Q?UcM8lahtB+72x69zAUKcFVgO+Ck4r0mQ+P5qAk6poHSpW2F8OkuY68FEd3pY?=
 =?us-ascii?Q?C2tg9UdjG+KOWITmlmoDL0t1q0RqOeIT+cVsrHE19RC5H26DrmbNcxEqpvP+?=
 =?us-ascii?Q?4E57R3WVAxe9Xd47zcihd5DVBrG9O7tFUuMkDyHBfiDEdAqPeNDV0bl6MpKx?=
 =?us-ascii?Q?KNN7GUSMVKeJYiXG+PqQ8CY1OR0=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <FD0724AFB334A34CAEFE1722204BDADC@namprd11.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4855.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f77a0cbd-4d3e-4a0a-93cc-08d9b8ffe7fb
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Dec 2021 21:32:29.6737
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: doK4Aknx+MhEzM0GbrxooW5fIJf9n9Rhncjua3dBRRMiDOYymFh2c3mKCXiQnOhv2jHqJH8pDS8rGu8BppcKbgM7sCZqJ/qxZmwVASyuvHM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5015
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On Dec 2, 2021, at 06:21, Peter Zijlstra <peterz@infradead.org> wrote:
> On Wed, Nov 24, 2021 at 12:06:56PM -0800, Chang S. Bae wrote:
>> +	encodekey256 %eax, %eax
>=20
> So this thing uses the fancy new keylocker instructions, however:
>=20
>> diff --git a/crypto/Kconfig b/crypto/Kconfig
>> index 285f82647d2b..784a04433549 100644
>> --- a/crypto/Kconfig
>> +++ b/crypto/Kconfig
>> @@ -1113,6 +1113,50 @@ config CRYPTO_AES_NI_INTEL
>> 	  ECB, CBC, LRW, XTS. The 64 bit version has additional
>> 	  acceleration for CTR.
>>=20
>> +config CRYPTO_AES_KL
>> +	tristate "AES cipher algorithms (AES-KL)"
>> +	depends on (LD_VERSION >=3D 23600) || (LLD_VERSION >=3D 120000)
>> +	depends on DM_CRYPT
>> +	select X86_KEYLOCKER
>> +	select CRYPTO_AES_NI_INTEL
>=20
>=20
> There is no dependency on the compiler actually supporting them..
>=20
> config AS_HAS_KEYLOCKER
> 	def_bool $(as-instr,encodekey256)
>=20
> 	depends on AS_HAS_KEYLOCKER
>=20
> Hmm?

Well, LD_VERSION reflects the binutils version.

But yes, the as-instr macro looks to be useful here:

+config AS_HAS_KEYLOCKER
+       def_bool $(as-instr,encodekey256 %eax$(comma)%eax)
+       help
+         Supported by binutils >=3D2.36 and LLVM integrated assembler >=3D=
 V12
+
 config CRYPTO_AES_KL
        tristate "AES cipher algorithms (AES-KL)"
-       depends on (LD_VERSION >=3D 23600) || (LLD_VERSION >=3D 120000)
+       depends on AS_HAS_KEYLOCKER

Thanks,
Chang