Date:   Fri, 17 Dec 2021 10:12:32 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Boris Brezillon <bbrezillon@kernel.org>,
        Srujana Challa <schalla@marvell.com>
Cc:     Arnaud Ebalard <arno@natisbad.org>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        "David S. Miller" <davem@davemloft.net>,
        Suheil Chandran <schandran@marvell.com>,
        Shijith Thotton <sthotton@marvell.com>,
        linux-crypto@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [PATCH 1/2] crypto: octeontx2 - out of bounds access in
 otx2_cpt_dl_custom_egrp_delete()
Message-ID: <20211217071232.GG26548@kili>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.10.1 (2018-07-13)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?aWnT7jHd3FdL/vA1xaai455jo5/I+XaEKhkHvgkmmOvbVXMCgOqfK+251rBW?=
 =?us-ascii?Q?h58aVCOweCS2VfeXTW3ovJg6uzSHMbapkGNgCahEqB5eY95FFBUZ1/cMJn3I?=
 =?us-ascii?Q?wC35dZJ37VcbbyLySZEMc7Mv+kmK/3dKw1vJ7cGd3lvnTpAAsAZ836yTuhjb?=
 =?us-ascii?Q?YPyhwk0vfiv6bsYo5CFGzs4gjiFWkbZ/Z+lC6Hw394c6sOzwRUUKM/hXtLco?=
 =?us-ascii?Q?iZD7LvGC7IQzNzTlHEkRW/tjW3YqbhqjanefoSCgtPpYCAMJkM48BX8XwcJs?=
 =?us-ascii?Q?M22IgEZyJXhs2OGFgy8uqCZwM9uu/RaWYSvzxVZAxeAVrQ8s0iAhZv2ugYhI?=
 =?us-ascii?Q?GI/rTwOc31MmHtjoHnzyNEEwdlOOXAinBSwf9gm8KLq5GtineLCTw5xLnM2a?=
 =?us-ascii?Q?06Vdb1luVwoiWYHRZ+SzON5zAf67e80y0tMcZ2lmNrPfSfe70L1T1CNSUoIH?=
 =?us-ascii?Q?6miQVJMKSDEyi9Mzgy8C2gVWsr4PWjZ/VT7TSTUIyaYdx3NXQw6lwX7wtXn+?=
 =?us-ascii?Q?RtlREcRa10SG8DE5eaNrY5a4utRBJJOAXJpEksz5ImUdbJ9y538/EuzH0WiU?=
 =?us-ascii?Q?YcjaA+Ur7WZFQG5xtUAHNqVrLKlkqdCWoJclv0Frd8eeNh4XWTlmBl+MXA4R?=
 =?us-ascii?Q?CHlfsNDpq1kuJoQUdZalV42IU02oAPtWlOnJE6xLncEOx4HoLTBXVTri3kwU?=
 =?us-ascii?Q?jXzDEl8eAqA3CbauEjRO4Hez5BtaSfxzphyfb1y81TRWockDAQI9gvAGC4NS?=
 =?us-ascii?Q?nHzNPns5ofrYgFFfrobonMOq/cjPjHUXt3kcPu5DGI/miPI49vosyRfq3dDd?=
 =?us-ascii?Q?z9TdTBQWq634tJrFRBvJncS7sGtoXSanzPgzJ+5LNzwTQ3oQBco6zWx72RC3?=
 =?us-ascii?Q?HlcKleNQXuy5zGK7x3DufSB8kQMrlWDKgpCARpiQHmBsyOukKHmKzR4HcGX7?=
 =?us-ascii?Q?kWcIgQBffUouA1lPi0IYpk/XnvbIA4V/64Q3W4Lp7DgGMIqvMe+QoUvl76gO?=
 =?us-ascii?Q?dAB1vVhiH0BY+YqZoyLMzCRCbiOA3TvO8TxVaspSHq2Fh+kPWW0q1PaPcbJo?=
 =?us-ascii?Q?WAXlULE9XqeSZ3PzJPneyOXZ1o3wf4oW+8u0aTebKWzFvnhgUIwhF0Kyknea?=
 =?us-ascii?Q?yKviD/DIrwniKAzOEyIXsjXDel1lY4AGQRzJs65NSQtAZHq7AXr5N9dC5JfN?=
 =?us-ascii?Q?G1K78TbKQqkRTky1ywnuIH8K8rCxGvmH/Eu89dtpXkEg3mwQB4rHGdZ0mBOE?=
 =?us-ascii?Q?8A968hLR4b6HMfkFsqrAPSXA5VLyJxMEljJxuDXG7KxQ4zPymjjd283y/x/I?=
 =?us-ascii?Q?zt0lajev6iArO48ddmRt9Bsgut6NVcHFaD887DgXdB+vRh5sLZ58DyVZ3d2O?=
 =?us-ascii?Q?TXW8Jle37PS4V5CcY7MxjTfbSqJ9ZpWix0yaFhJaBGmTSFp9tDqduDKdO+Oc?=
 =?us-ascii?Q?b7zuUJf5D+6/JTE8/TcUNEMbOjxjST0h1JDjisR4RPX+46N0TqpBd46SCprK?=
 =?us-ascii?Q?53V1FGB92KAQ53LWdnIRyo/5bCcya5MqD0KTcdO7LVL4qLDT8mwFAxPZBjW0?=
 =?us-ascii?Q?oQuv7g8TkcOD1i9hWvT0lKkHxyDyKXNeQKlngQaC1V6/SRiGttaa5KFci9u6?=
 =?us-ascii?Q?OPTBPSop9hV//iAKYTswPOoWVim6mRdlRYMV3U9N3hbegE1m4nAfqtXJTe4Z?=
 =?us-ascii?Q?qqGgVUBqhxfwPwuqsWB5l817OV8=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2f028ef4-cac5-4e34-b333-08d9c12ca09a
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Dec 2021 07:12:46.8119
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ImeppHu4boXx+NIEWwmsgV7315TaKWrpia+XMyoMTqixdEOnyfM9oARjNxMQPcWCf3D5B5mfIt75kD4+xdgpdyQ4sLH9XcsR0syTyFTTtHc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR10MB5863
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10200 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 adultscore=3
 malwarescore=0 bulkscore=0 spamscore=0 mlxlogscore=999 mlxscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2112170040
X-Proofpoint-GUID: s2CBPjsmgvTz8e4NtmH0wjuZ3kDLKoK9
X-Proofpoint-ORIG-GUID: s2CBPjsmgvTz8e4NtmH0wjuZ3kDLKoK9
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

If "egrp" is negative then it is causes an out of bounds access in
eng_grps->grp[].

Fixes: d9d7749773e8 ("crypto: octeontx2 - add apis for custom engine groups")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/crypto/marvell/octeontx2/otx2_cptpf_ucode.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/marvell/octeontx2/otx2_cptpf_ucode.c b/drivers/crypto/marvell/octeontx2/otx2_cptpf_ucode.c
index 57307eac541c..07f28d887c2c 100644
--- a/drivers/crypto/marvell/octeontx2/otx2_cptpf_ucode.c
+++ b/drivers/crypto/marvell/octeontx2/otx2_cptpf_ucode.c
@@ -1695,7 +1695,7 @@ int otx2_cpt_dl_custom_egrp_delete(struct otx2_cptpf_dev *cptpf,
 	if (kstrtoint(tmp, 10, &egrp))
 		goto err_print;
 
-	if (egrp >= OTX2_CPT_MAX_ENGINE_GROUPS) {
+	if (egrp < 0 || egrp >= OTX2_CPT_MAX_ENGINE_GROUPS) {
 		dev_err(dev, "Invalid engine group %d", egrp);
 		return -EINVAL;
 	}
-- 
2.20.1