Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 488CEC433EF for ; Fri, 17 Dec 2021 08:39:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229502AbhLQIjr (ORCPT ); Fri, 17 Dec 2021 03:39:47 -0500 Received: from helcar.hmeau.com ([216.24.177.18]:58078 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233920AbhLQIjr (ORCPT ); Fri, 17 Dec 2021 03:39:47 -0500 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.103.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1my8mD-00012E-2x; Fri, 17 Dec 2021 19:39:42 +1100 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 17 Dec 2021 19:39:40 +1100 Date: Fri, 17 Dec 2021 19:39:40 +1100 From: Herbert Xu To: Weili Qian Cc: davem@davemloft.net, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, wangzhou1@hisilicon.com, liulongfang@huawei.com Subject: Re: [PATCH] crypto: hisilicon/hpre - fix memory leak in hpre_curve25519_src_init() Message-ID: <20211217083940.GF7018@gondor.apana.org.au> References: <20211211081719.30329-1-qianweili@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211211081719.30329-1-qianweili@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Sat, Dec 11, 2021 at 04:17:19PM +0800, Weili Qian wrote: > hpre_curve25519_src_init() allocates memory for 'ptr' before calling > memcmp(). If memcmp() returns 0, the function will return '-EINVAL' > without freeing memory. > > Signed-off-by: Weili Qian > --- > drivers/crypto/hisilicon/hpre/hpre_crypto.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt