From:   Stephan =?ISO-8859-1?Q?M=FCller?= <smueller@chronox.de>
To:     herbert@gondor.apana.org.au, Simo Sorce <simo@redhat.com>
Cc:     linux-crypto@vger.kernel.org, skozina@redhat.com,
        Nicolai Stange <nstange@suse.de>
Subject: Re: [PATCH] crypto: jitter - add oversampling of noise source
Date:   Fri, 17 Dec 2021 13:16:13 +0100
Message-ID: <4742341.vXUDI8C0e8@positron.chronox.de>
In-Reply-To: <ee13fe8c757a419f0f4c6b60419afb1b63003f2f.camel@redhat.com>
References: <2573346.vuYhMxLoTh@positron.chronox.de> <ee13fe8c757a419f0f4c6b60419afb1b63003f2f.camel@redhat.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Precedence: bulk

Am Freitag, 17. Dezember 2021, 13:06:07 CET schrieb Simo Sorce:

Hi Simo,

> >  static void jent_gen_entropy(struct rand_data *ec)
> >  {
> > 
> > -	unsigned int k = 0;
> > +	unsigned int k = 0, safety_factor = JENT_ENTROPY_SAFETY_FACTOR;
> > +
> > +	if (!jent_fips_enabled())
> > +		safety_factor = 0;
> 
> I would find this more readable if safety_factor is initialized to 0,
> and then in the code:
> 	if (jent_fips_enabled())
> 		safety_factor = JENT_ENTROPY_SAFETY_FACTOR;
> 
> However this is just readability for me, either option is perfectly
> identicaly IMO, so

Thank you, I will send an updated patch.

Ciao
Stephan