From:   Stephan =?ISO-8859-1?Q?M=FCller?= <smueller@chronox.de>
To:     Herbert Xu <herbert@gondor.apana.org.au>
Cc:     linux-crypto@vger.kernel.org, simo@redhat.com, skozina@redhat.com,
        Nicolai Stange <nstange@suse.de>
Subject: Re: [PATCH] crypto: jitter - add oversampling of noise source
Date:   Sun, 19 Dec 2021 09:52:57 +0100
Message-ID: <4499108.vXUDI8C0e8@positron.chronox.de>
In-Reply-To: <20211218032720.GA11637@gondor.apana.org.au>
References: <2573346.vuYhMxLoTh@positron.chronox.de> <20211218032720.GA11637@gondor.apana.org.au>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
Precedence: bulk

Am Samstag, 18. Dezember 2021, 04:27:21 CET schrieb Herbert Xu:

Hi Herbert,

> On Fri, Dec 17, 2021 at 10:41:42AM +0100, Stephan M=FCller wrote:
> > diff --git a/crypto/jitterentropy-kcapi.c b/crypto/jitterentropy-kcapi.c
> > index 2d115bec15ae..b02f93805e83 100644
> > --- a/crypto/jitterentropy-kcapi.c
> > +++ b/crypto/jitterentropy-kcapi.c
> > @@ -59,6 +60,11 @@ void jent_zfree(void *ptr)
> >=20
> >  	kfree_sensitive(ptr);
> > =20
> >  }
> >=20
> > +int jent_fips_enabled(void)
> > +{
> > +	return fips_enabled;
> > +}
>=20
> Why do you need this function? And why can't it be inlined?
>=20
> Normally fips_enabled is entirely optimised away if FIPS is
> disabled in Kconfig.  This function breaks this.

You are right, fips.h can be included into jitterentropy.c and this helper=
=20
function can be eliminated.

Thanks
>=20
> Thanks,


Ciao
Stephan