Message-ID: <8dd55bd0-ccb6-ea4e-5679-51f88925c40f@gmail.com>
Date:   Thu, 23 Dec 2021 07:59:01 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Content-Language: en-US
To:     "Rafael J. Wysocki" <rafael@kernel.org>,
        Herbert Xu <herbert@gondor.apana.org.au>
Cc:     "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Linux PM <linux-pm@vger.kernel.org>,
        Linux Crypto Mailing List <linux-crypto@vger.kernel.org>
References: <0edfdadc-336b-657d-5566-beeb4f4343ac@gmail.com>
 <CAJZ5v0gps0C2923VqM8876npvhcETsyN+ajAkBKX5kf49J0+Mg@mail.gmail.com>
From:   Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: Annotate pm_runtime_resume_and_get() as __must_check ?
In-Reply-To: <CAJZ5v0gps0C2923VqM8876npvhcETsyN+ajAkBKX5kf49J0+Mg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 03.08.2021 15:07, Rafael J. Wysocki wrote:
> On Sat, Jul 31, 2021 at 11:36 AM Heiner Kallweit <hkallweit1@gmail.com> wrote:
>>
>> Seeing an erroneous use of pm_runtime_resume_and_get() in a patch I wonder
>> whether we should annotate this function as __must_check. If the caller
>> doesn't check the return code he doesn't know whether usage counter was
>> bumped or not. Therefore I see a good chance that this results in a usage
>> counter imbalance.
> 
> Sounds reasonable.  Please send a patch to make that change.

It took some time to fix the callers that use pm_runtime_resume_and_get()
w/o checking the return code. Last pending patch is [0], all other fixes
are available on linux-next meanwhile.
I'll submit the patch to annotate pm_runtime_resume_and_get() as
__must_check, so that we hopefully can get this into 5.17 (incl. pending [0]).

[0] https://lore.kernel.org/all/ed1ac2f8-5259-684d-42c8-effdf2920e78@gmail.com/T/