Date:   Fri, 24 Dec 2021 14:26:53 +1100
From:   Herbert Xu <herbert@gondor.apana.org.au>
To:     Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Cc:     Rob Herring <robh+dt@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Randy Dunlap <rdunlap@infradead.org>,
        linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
        Prabhakar <prabhakar.csengg@gmail.com>
Subject: Re: [PATCH] crypto: ux500 - Use platform_get_irq() to get the
 interrupt
Message-ID: <YcU9/YknV1xJt7jv@gondor.apana.org.au>
References: <20211218150625.15134-1-prabhakar.mahadev-lad.rj@bp.renesas.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211218150625.15134-1-prabhakar.mahadev-lad.rj@bp.renesas.com>
Precedence: bulk

On Sat, Dec 18, 2021 at 03:06:25PM +0000, Lad Prabhakar wrote:
> platform_get_resource(pdev, IORESOURCE_IRQ, ..) relies on static
> allocation of IRQ resources in DT core code, this causes an issue
> when using hierarchical interrupt domains using "interrupts" property
> in the node as this bypasses the hierarchical setup and messes up the
> irq chaining.
> 
> In preparation for removal of static setup of IRQ resource from DT core
> code use platform_get_irq() so that interrupt mapping is created on demand.
> 
> While at it also store the IRQ number in struct cryp_device_data so that
> we don't have to call platform_get_irq() frequently.
> 
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> ---
> Hi,
> 
> Dropping usage of platform_get_resource() was agreed based on
> the discussion [0].
> 
> [0] https://patchwork.kernel.org/project/linux-renesas-soc/
> patch/20211209001056.29774-1-prabhakar.mahadev-lad.rj@bp.renesas.com/
> 
> Cheers,
> Prabhakar
> ---
>  drivers/crypto/ux500/cryp/cryp.h      |  2 ++
>  drivers/crypto/ux500/cryp/cryp_core.c | 26 +++++++-------------------
>  2 files changed, 9 insertions(+), 19 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt