From:   "Bae, Chang Seok" <chang.seok.bae@intel.com>
To:     Eric Biggers <ebiggers@kernel.org>
CC:     "dm-devel@redhat.com" <dm-devel@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Borislav Petkov <bp@suse.de>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Ingo Molnar <mingo@kernel.org>,
        "Lutomirski, Andy" <luto@kernel.org>,
        the arch/x86 maintainers <x86@kernel.org>,
        "Herbert Xu" <herbert@gondor.apana.org.au>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
        "Williams, Dan J" <dan.j.williams@intel.com>,
        "Gairuboyina, Charishma1" <charishma1.gairuboyina@intel.com>,
        "Dwarakanath, Kumar N" <kumar.n.dwarakanath@intel.com>,
        "Krishnakumar, Lalithambika" <lalithambika.krishnakumar@intel.com>,
        "Shankar, Ravi V" <ravi.v.shankar@intel.com>
Subject: Re: [PATCH v4 00/13] x86: Support Key Locker
Thread-Topic: [PATCH v4 00/13] x86: Support Key Locker
Thread-Index: AQHX8IXgPtLMRzOkzUOX4xWFKhqGg6w0Uf6AgCDKzgCAAHjSAIAAEj0A
Date:   Thu, 6 Jan 2022 06:13:00 +0000
Message-ID: <B67A9D30-2FC8-4AF7-957F-5A90D889142F@intel.com>
References: <20211214005212.20588-1-chang.seok.bae@intel.com>
 <YbqRseO+TtuGQk5x@sol.localdomain>
 <4101B942-6327-49A9-BE8B-9E51F0427F50@intel.com>
 <YdZ5HrOKEffBrQIm@sol.localdomain>
In-Reply-To: <YdZ5HrOKEffBrQIm@sol.localdomain>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ZZ+OvV5mUFkbZ+CvJZ6AyM4L43DO5sLkQs+vArEfrRa5CIBTwFoYO38dHBwi?=
 =?us-ascii?Q?Vg90scRIx4YT4guTZ/dn2JVUGZgHT+2EYO2KrLdMFh5GiJCka4TzQ34EjH7e?=
 =?us-ascii?Q?4U/kR2Dhm5DwuvJ0C0BbAU/piPLqpWnYsmB2+c/CMlSBTSD3seYuqdD+FAqx?=
 =?us-ascii?Q?WlfKCIPqQvx522RWFBzCBCA8mYzBlGA+0V4CfMHtDdis8Jx7DxJL3GR/aMKE?=
 =?us-ascii?Q?qJiX9Xsitljf9wj5DNmgzRU1WprttSsHtt3kfuugCuqe/OXffHxTbG74Y9wB?=
 =?us-ascii?Q?KcqpETQva6fKrfU++BcyIGgigXUdnFVV5L8uEqrXOTYvQ5rxt9hm1NpFNxMB?=
 =?us-ascii?Q?uVETs6bk9Yq0nz+7FjcSuuvCuD6hJpxXCMWnEeoCrDzUqsWYgxL0EOuuyqVd?=
 =?us-ascii?Q?UWCiPCnC+ThQMw1TdN7oRnjgA8f2mQPLUzx/uC/oFTk0Nc2BnDx8RrHxT4V1?=
 =?us-ascii?Q?j2zRBfX9SJq6E/ob9G1FAhqx0ZiiMZSljKpRoPNNW5ZjLKBvIFocbZ9z0x3L?=
 =?us-ascii?Q?rNRzzUudTCrZckJ26KBQeruBPF/USURBGp6zVW9++thyc3dosU6FpUtQpZ8a?=
 =?us-ascii?Q?2CERuqKodCPNqOabXSxS9FP1DR5Pj32XVGekengl1i9lqY1T2i4z9zFuKmO8?=
 =?us-ascii?Q?oxo4KGYQvpw9wV3FSn1jV7xWaNZaKUvnnltlgYI1CtvsAYEiwkKs2r6kXlIM?=
 =?us-ascii?Q?dBTypP10B2YF/wfD4YwbcUsbqjQSRlXQM8z7hFntOtjEqoeczr9qpXVIm0EU?=
 =?us-ascii?Q?aZZFBym71GOUxkXB8fvwozIJiqeHseQdwQGPKmJAoKwJrSNH8mYQ820itAQF?=
 =?us-ascii?Q?3oSahMQWmWILf+GwrXX2NPLNCqPyZElXQfDlTdut/vARk0rMkpnnwEzuupeK?=
 =?us-ascii?Q?287pfgyFaYYrq0HkcHBUo0oQAe936BwEFZMm7LX6njb3Ri7qTuW8T08OVlIC?=
 =?us-ascii?Q?06bx1l08xurtjOBpXmu/XpDLLi8v0ZG1WlL2UvOM9EaAZpo9pCeKOaeQ9ek3?=
 =?us-ascii?Q?RnOsd5cQUVK22mR05cpUMs6IQ/O03SBl9YEJPM0GKgHB0DF+ZpFmQYni+gC8?=
 =?us-ascii?Q?EVU+5J2idQc2OY8meRlI4uqXwhysmLMtmNLg5C9WXS+zZ7M4a+j2v2hH+5LC?=
 =?us-ascii?Q?y2uWx4/FkorvIzEzneT4fgCqpqNTVDG/3odmJeIcK25mAoaZioV4kwpe02vZ?=
 =?us-ascii?Q?XqJ5S1XQCEgXRdqfu7DiZbcxXqyHcQAI3E5F46U9xypx+3eBkIfkWrvzz/aH?=
 =?us-ascii?Q?yWPM5Gn0ZWEWkBAZomgQLwB1Rt/S9J9I3XMvR9nwnSZ9MMp4rfOR82eBD+d4?=
 =?us-ascii?Q?fl1uFPJfGovvJ5Sf6g0gwQURaeYle6xfM7nxrq8yjtfTrwGXtdnbzGrPvNIq?=
 =?us-ascii?Q?eKIWseWI6+iq7qi5VXI+u3nMykuers//4/SG3k4TXVC4/fKnRsPZgV2y8dCu?=
 =?us-ascii?Q?UVA1FJRMwogRadtg/oGfTazeMLkgoY3aNRS9UDRtWPp97EUuT0/7XyYPTkDi?=
 =?us-ascii?Q?af3pWsaC8C1f03AILgnknyhAV4WSmdBfsPIZCnwBA7WJOTw04WddIPsrrFf9?=
 =?us-ascii?Q?T/huSffsvvpVUk2o2STEMmnBSEZ37/tOgpeVtU0v9zMKmp6vXzHUzDUomhw0?=
 =?us-ascii?Q?NhdgFcyzXFBiYp1HANlm+6Jp9829pCzFbCG3DdmBqiPJrtEVu1WR9vMBHOi/?=
 =?us-ascii?Q?xKz7V2S4IRDlveTBbNeATCrhHqU=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <650678EFAA8AEA4EBF93642644F856B7@namprd11.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4855.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e4d9282a-5a89-491a-f4c3-08d9d0db977d
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jan 2022 06:13:00.6108
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: sD1v3mVU+yDiT9v7LQoLQfNKGrsTxX2OQt9x/BBiccz/durOGqfaKqRIK1uY5pjxAIa4wz1U4sfd+e1etThSfvcnAgLxQl+vCRB6CNsNrpc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5781
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On Jan 5, 2022, at 21:07, Eric Biggers <ebiggers@kernel.org> wrote:
> On Wed, Jan 05, 2022 at 09:55:17PM +0000, Bae, Chang Seok wrote:
>>=20
>> As long as it is factual that the mode was once popular, it can help som=
ebody
>> who wants to use Key Locker for an old disk image I think.
>=20
> AES-CBC is/was usually used with ESSIV, in which case the key cannot be f=
ully
> protected by Key Locker.
>=20
> I'm not sure you should bother to support legacy use cases, especially si=
nce it
> might mislead users into choosing a worse algorithm.

Alright, this is not that critical as it will be possible to add this mode
later when needed.

Thanks,
Chang=