Date:   Tue, 11 Jan 2022 10:19:22 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Giovanni Cabiddu <giovanni.cabiddu@intel.com>,
        Mateusz =?utf-8?Q?Jo=C5=84czyk?= <mat.jonczyk@o2.pl>
Cc:     Herbert Xu <herbert@gondor.apana.org.au>,
        "David S. Miller" <davem@davemloft.net>,
        Alessandro Zummo <a.zummo@towertech.it>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Marco Chiappero <marco.chiappero@intel.com>,
        Fiona Trahe <fiona.trahe@intel.com>,
        Wojciech Ziemba <wojciech.ziemba@intel.com>,
        Tomasz Kowalik <tomaszx.kowalik@intel.com>,
        qat-linux@intel.com, linux-crypto@vger.kernel.org,
        linux-rtc@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [PATCH] rtc: mc146818-lib: fix signedness bug in mc146818_get_time()
Message-ID: <20220111071922.GE11243@kili>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.10.1 (2018-07-13)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?E4W9pWZq0ppmeoQCZ8Jn2r6ap6y4LhCaRFqxpc8x7LyKLgFrrAX3dONom7W+?=
 =?us-ascii?Q?Nwbors6O8+wFv75HCRM4+L5MmP5lcPtZvqZchW+F1EbnTCM/fe5DhbsjOVwI?=
 =?us-ascii?Q?eXcQ8hIFOxbGci6VkklQsxF9mCbtuhVum8QTeQ+dNv/mMYwa3GS8tSRr6MNO?=
 =?us-ascii?Q?3w4gY+2zwPRxt7kUa5CkSlAyNtWSizO4HsxGye4nnyhStHkWH38y0XSEkq/B?=
 =?us-ascii?Q?KC1rpFOsNdQGpdHaOu3CI4v70lJsGvjHUj+QT+S44DAU17+qAHoYAWdxB1/D?=
 =?us-ascii?Q?rnTs09Rboie8JxgxItbThssXD1l+7n9+e2ijMNXe1sdxd6wveH5L09QcfbkN?=
 =?us-ascii?Q?1nc6w7ci5zTL2W69pxjp0I+4Fw6rwhl6WasMSasYpedsnypvZmUxxNatK3wR?=
 =?us-ascii?Q?HFsjBjWZ3/HIQrj90F0LrdRJOtOUec55JsDeWmCIMnaVT7EH5m3XhyYMYstb?=
 =?us-ascii?Q?cwP0+KgQGBBw/QSy4RCJFLFltRE4MMzXZf4tbVBSyM99JRx4qwif3rmzAjNt?=
 =?us-ascii?Q?d0XHTxncB3yEWLcc/SfUz1oZIvrOv8SDk8uQMqJ36uby00QBJ6x+2lRM9G0A?=
 =?us-ascii?Q?jhPvzH0jYLmWH4lYHFrqcgMzt//FXEOHc40cLVb5j3GDu8MEoo/ZVpp9o0a5?=
 =?us-ascii?Q?LkNgRshbSCC0BQYdvYDznYv+RmgAX94p6IFqS2UumdIq/v1pc7dLfFQ4Cuw3?=
 =?us-ascii?Q?exkXT3oGNX1isjq7dFVL7xmxzLxI66yC/mDYzd6da0h0tUPz7ScyaNvlFk9Q?=
 =?us-ascii?Q?KxDbXTX2O0/H3paLRjrhz8YgZ17GE5yMq1xBE/Vrjk8QASInp1JlXPZD/pSY?=
 =?us-ascii?Q?Y/yjQaxl7CPX6Qp3HWk7P1cJYggOQh19BU/+k/YDCPHGx3EyLS/+8yxCRN2A?=
 =?us-ascii?Q?mz3T4sGw3Vy63PB+vkfZkL4M2khMJN0sUMhhJYSclNvnoVY9o6vAxO6/iEfX?=
 =?us-ascii?Q?8zK+5QvCKr+dETysp/nC5a2/brsonuKnSVIikou+xZ/571lkLyKfDd/N505b?=
 =?us-ascii?Q?ym1zWzdFT5S2VJTC0iZ4aBTeCxItuPZL99+0FHoUe0dRVOz1Ix6kUQ9tE1EB?=
 =?us-ascii?Q?d4pNyCrdg1TaHftS64xGlDl30Im5WlpHOlKXt5i0uD2X7ZfgvX56YLkuOPXq?=
 =?us-ascii?Q?PbuSEDQkLKh3nro4DGHEbcMHVkOtTpGjjjEZAVGhtyNruCR02CUE1f0YufsR?=
 =?us-ascii?Q?BGLxKc9nVnqWWwi79ulwalSPfyESpjgAvmyqKo9SLlL2ajJ2v14+fRcLxk0t?=
 =?us-ascii?Q?9dW2Yh5AANfAIoaI1D58bKsd+xIwdz0k8T7ZfmmVa/kZkRG+yJ1t2JAKzrXG?=
 =?us-ascii?Q?iO1JfL6mJ/fkaFUyuNP8XKrQ593XNKWi0CV+M+8ffZgHa04CpH+z69PHt3eO?=
 =?us-ascii?Q?W5vK1F4KlBjeJRfe8sGIFfLF5Kx1HP29GTNH+9BeRXJoUNKM94aujj4/zsEJ?=
 =?us-ascii?Q?H2DK2smBuUD58ZIT9WLglQTQUlDnaFv4GniTZsDQEcCMcCR/hbxZ+jal8Mib?=
 =?us-ascii?Q?JU43pKNhLo6M2CSgopxy9kL3Ld7zm9a244PMfrj03qu/jHdzjOCX3OLznjZA?=
 =?us-ascii?Q?WnomInrOUsyY4HlOW9c9Rd3ZYtJfjB73xasxiF292uSaW03IrL51ZYdtw0Rl?=
 =?us-ascii?Q?oiMH1mD3zUfNRRZOp05WtuagEwk/l20Xg9z9jqxewD43dfJChQ7EJhPBnNAW?=
 =?us-ascii?Q?weuB3l78enElpacUsa6tHs9MUCo=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 91bc0f5a-3e63-4f0e-7252-08d9d4d2b904
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2022 07:19:36.4432
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: L4DYtMoO1hMkXy+rokOEsVZ3XBuR/KsVyJSiBiBL0R6K8YFLPcpVJiMa+2IiikQUAH6q3KHHGqecXNieEDEsxFq1g41VkIvIEMpKQ8gXae0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1421
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10223 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxscore=0 phishscore=0
 mlxlogscore=999 spamscore=0 bulkscore=0 malwarescore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2201110039
X-Proofpoint-GUID: OyQMVpgJZTz8UG0jDDERFRYkcmmEHKOQ
X-Proofpoint-ORIG-GUID: OyQMVpgJZTz8UG0jDDERFRYkcmmEHKOQ
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

The mc146818_get_time() function returns zero on success or negative
a error code on failure.  It needs to be type int.

Fixes: d35786b3a28d ("rtc: mc146818-lib: change return values of mc146818_get_time()")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 include/linux/mc146818rtc.h                    | 2 +-
 drivers/rtc/rtc-mc146818-lib.c                 | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/mc146818rtc.h b/include/linux/mc146818rtc.h
index 67fb0a12becc..808bb4cee230 100644
--- a/include/linux/mc146818rtc.h
+++ b/include/linux/mc146818rtc.h
@@ -124,7 +124,7 @@ struct cmos_rtc_board_info {
 #endif /* ARCH_RTC_LOCATION */
 
 bool mc146818_does_rtc_work(void);
-unsigned int mc146818_get_time(struct rtc_time *time);
+int mc146818_get_time(struct rtc_time *time);
 int mc146818_set_time(struct rtc_time *time);
 
 bool mc146818_avoid_UIP(void (*callback)(unsigned char seconds, void *param),
diff --git a/drivers/rtc/rtc-mc146818-lib.c b/drivers/rtc/rtc-mc146818-lib.c
index f62e658cbe23..7f689f1bafc5 100644
--- a/drivers/rtc/rtc-mc146818-lib.c
+++ b/drivers/rtc/rtc-mc146818-lib.c
@@ -130,7 +130,7 @@ static void mc146818_get_time_callback(unsigned char seconds, void *param_in)
 	p->ctrl = CMOS_READ(RTC_CONTROL);
 }
 
-unsigned int mc146818_get_time(struct rtc_time *time)
+int mc146818_get_time(struct rtc_time *time)
 {
 	struct mc146818_get_time_callback_param p = {
 		.time = time
-- 
2.20.1