Date:   Tue, 11 Jan 2022 12:05:51 +0000
From:   Giovanni Cabiddu <giovanni.cabiddu@intel.com>
To:     Dan Carpenter <dan.carpenter@oracle.com>,
        Herbert Xu <herbert@gondor.apana.org.au>
Cc:     Tomasz Kowalik <tomaszx.kowalik@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        Marco Chiappero <marco.chiappero@intel.com>,
        Fiona Trahe <fiona.trahe@intel.com>,
        Wojciech Ziemba <wojciech.ziemba@intel.com>,
        Mateuszx Potrola <mateuszx.potrola@intel.com>,
        qat-linux@intel.com, linux-crypto@vger.kernel.org,
        kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] crypto: qat - fix a signedness bug in
 get_service_enabled()
Message-ID: <Yd1yn4FHaueG4Lv8@silpixa00400314>
References: <20220111071806.GD11243@kili>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220111071806.GD11243@kili>
Organization: Intel Research and Development Ireland Ltd - Co. Reg. #308263 -
 Collinstown Industrial Park, Leixlip, County Kildare - Ireland
Precedence: bulk

On Tue, Jan 11, 2022 at 10:18:06AM +0300, Dan Carpenter wrote:
> The "ret" variable needs to be signed or there is an error message which
> will not be printed correctly.
> 
> Fixes: 0cec19c761e5 ("crypto: qat - add support for compression for 4xxx")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks Dan.
Acked-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>

@Herbert, there are 2 other (identical) patches in the list that fix the
same issue:
    https://patchwork.kernel.org/project/linux-crypto/patch/YdWZm6QJAYbYTKAR@debian-BULLSEYE-live-builder-AMD64/
    https://patchwork.kernel.org/project/linux-crypto/patch/20220105152005.43305-1-jiapeng.chong@linux.alibaba.com/

Since none of them made into the pull request for 5.17, I'm fine with
taking this one as it is the only one which contains the Fixes tag.

Regards,

-- 
Giovanni