Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 18 Jan 2022 12:40:08 -0500
From:   Daniel Jordan <daniel.m.jordan@oracle.com>
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     Alexander Duyck <alexanderduyck@fb.com>,
        Alex Williamson <alex.williamson@redhat.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Ben Segall <bsegall@google.com>,
        Cornelia Huck <cohuck@redhat.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Ingo Molnar <mingo@redhat.com>,
        Jason Gunthorpe <jgg@nvidia.com>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Josh Triplett <josh@joshtriplett.org>,
        Michal Hocko <mhocko@suse.com>, Nico Pache <npache@redhat.com>,
        Pasha Tatashin <pasha.tatashin@soleen.com>,
        Steffen Klassert <steffen.klassert@secunet.com>,
        Steve Sistare <steven.sistare@oracle.com>,
        Tejun Heo <tj@kernel.org>,
        Tim Chen <tim.c.chen@linux.intel.com>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        linux-mm@kvack.org, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org
Subject: Re: [RFC 15/16] sched/fair: Account kthread runtime debt for CFS
 bandwidth
Message-ID: <20220118174008.22bdwhxeg5qdc3xq@oracle.com>
References: <20220106004656.126790-1-daniel.m.jordan@oracle.com>
 <20220106004656.126790-16-daniel.m.jordan@oracle.com>
 <YeFDC0mV3yurUFbl@hirez.programming.kicks-ass.net>
 <YeFE9j4Qynp9sNXS@hirez.programming.kicks-ass.net>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YeFE9j4Qynp9sNXS@hirez.programming.kicks-ass.net>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?uLeSl4yF2pAhgNqQgIVe6iaHnn5QzXzGdRu69RkblvLXk9D15O3ptazYem2M?=
 =?us-ascii?Q?7vbd9tuZcRjRajyWO2pBV8wHuAza8SIWxxnlvMG4GbyEOJgHV6r8xfHs1Sog?=
 =?us-ascii?Q?oqfNyPEy4N6jZJdsPIK9WVnBDcuNvBL0kqjohfryqFuRYjAP0Aw8f/zTGPFZ?=
 =?us-ascii?Q?wztrmrSY2dZRBYQqcPEVsc8CGFj4UZAE4SMfZz+ZvYdmZF1UEBWIV2/8WxJr?=
 =?us-ascii?Q?hHmFLx8qN5JImEsm+cIJPtedl9NMXnfEoDxBtvgtln2L2eFFeFinNEQzIpfX?=
 =?us-ascii?Q?aBAeLund+1vGE5HN0XexnItYYYHfCtvSpcpDIyw2zHsZWhNLWktQfte/cIX6?=
 =?us-ascii?Q?GO9MOhYKcz08WVz5BQHGYLKp2H2yW4/gr0siP4Wem45h6jylAJlYh6VUm4hx?=
 =?us-ascii?Q?72KyttK1g2C491Ep8QEP3aHdvPbjv3l8cf0AD1NwLgoZlzd1KVZIr1ruFEHn?=
 =?us-ascii?Q?8EULbX/ADUCjERqudjKZq1E2A/9nI0Nw5NG+iFBNpXzFb1u9j3LvnpF+WmxP?=
 =?us-ascii?Q?5IaVy+xJhZ7zK6wocSmX1BtGF926UaVkb4LbYKf2N9B8pYX2rTry02i/fgW9?=
 =?us-ascii?Q?HtN+abtaFBgMHF8ojkvqKR51PUiuwXa7I8Ccg7VLl/G501VgjN4KcgAh0yPa?=
 =?us-ascii?Q?4uUxSsAX1AhHovPDCTxJuqH6R50CE8W4bb9cZSnmg1dba9oetYDxzGOrgxc9?=
 =?us-ascii?Q?4fIZzG8qRuDyI95566cmILNBBPfOF4k452KLuj/Jw1Wam6wONFB5PH/HGhzF?=
 =?us-ascii?Q?jvC9Ntsx7rxSOn0ai+sTnU6KRB2CnzcVku0whormz2phIs+lGoQLbTGG+/vM?=
 =?us-ascii?Q?NPObxNjfrGRWgx0KJVePjYdMCey87HrsdEfzgS5ddEbHGLLRwwvqMghZ0FFH?=
 =?us-ascii?Q?a+OqIJV9KkfCFlfTJZWW8YUZ15MkNAk9gVhVazT79s3ESB56GnSccM0DO/E4?=
 =?us-ascii?Q?FUhbjNB8WoPVr9L01YHFZRNSVem46QBSGRegJL+ju0r0XfRrybDBDGp/D3vi?=
 =?us-ascii?Q?lQTieoOJEW2UcE81QJwKcIBkRbwaKaO/VEnmZfxqeIPfSGwjRb0HlwOM8BLk?=
 =?us-ascii?Q?W2U+FAPFjgzdW7UvJQBwWlZgBHdG4Iw71qs0JMZumIDSza0K/eQeYC9923iG?=
 =?us-ascii?Q?lTxCGyrRBf9U6HkDHy/jx4ZLkWw8jw+76Q1oFU8BMvVWL9zfh9iX8Gp0HaBW?=
 =?us-ascii?Q?MnOXy0TzaxCiD2tucDJvXDGfEikE51aKTDbqITOvIflPLxulQtke4I/xYcb9?=
 =?us-ascii?Q?RXlnQ4f7410igeXFIFA3KQxtKRFnYmvjD+mZmwBARQgeCRUgDM/MC2MN82ps?=
 =?us-ascii?Q?bjvWhYubZeGdVlZz9IsR32NeMpXSsEMwEWp1Ve22xdRkxc6jhpmHmDm1DS7z?=
 =?us-ascii?Q?+666e5qNafGpNc95VmLBr5/ifBPNciIHPDQucye7MQe9yqDOC+7RzqABGiBy?=
 =?us-ascii?Q?mZmaafc+O2642v0M7QVq/P6uKY/ebDVBo+IY9jI3tCEq65dbx0O0mo/uiAHR?=
 =?us-ascii?Q?gM1VjQf+CcYj8rUAatcTOzwt7rTgP+IGqPZ9NmQOUkUaI//eWM48vBvMfQjv?=
 =?us-ascii?Q?ZupXGPVU+tSFQWGM3zL+uQ+T6nBwITvUB+fRDTTojsHQUNEoA+AQvjb5xsDi?=
 =?us-ascii?Q?MZ3cmIGt8eer1OYjgAqnWbJ62HFV0lTP5Ke/dXua8Uo6SE/65W5NJaeQxixC?=
 =?us-ascii?Q?YwMiRnYtoozD4QwG8sL5h1JDu2o=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 230e1646-d3bb-4f79-d5ba-08d9daa9948b
X-MS-Exchange-CrossTenant-AuthSource: SA1PR10MB5711.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jan 2022 17:40:12.8655
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vYUd2SGYamkj6QeD3yoIpeKQI8hPisRgEmluwKcEA+faeYVswbeYJnnJigEhCJEMPrsSfasyD8cbJKc1liaCmMWleZtZ8755dCwoXlaIElw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB5547
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10231 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 bulkscore=0
 malwarescore=0 adultscore=0 phishscore=0 mlxscore=0 spamscore=0
 mlxlogscore=735 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2201180105
X-Proofpoint-GUID: _2Xqkn3ZY5_XqapE5CBooO2qhUti_0Zj
X-Proofpoint-ORIG-GUID: _2Xqkn3ZY5_XqapE5CBooO2qhUti_0Zj
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On Fri, Jan 14, 2022 at 10:40:06AM +0100, Peter Zijlstra wrote:
> On Fri, Jan 14, 2022 at 10:31:55AM +0100, Peter Zijlstra wrote:
> 
> > Also, by virtue of this being a start-stop annotation interface, the
> > accrued time might be arbitrarily large and arbitrarily delayed. I'm not
> > sure that's sensible.
> > 
> > For tasks it might be better to mark the task and have the tick DTRT
> > instead of later trying to 'migrate' the time.
> 
> Which is then very close to simply sticking the task into the right
> cgroup for a limited duration.
> 
> You could do a special case sched_move_task(), that takes a css argument
> instead of using the current task_css. Then for cgroups it looks like
> nothing changes, but the scheduler will DTRT and act like it is in the
> target cgroup. Then at the end, simply move it back to task_css.

Yes, that's one of the things I tried.  Less new code in the scheduler
this way.

> This obviously doesn't work for SoftIRQ accounting, but that is
> 'special' anyway. Softirq stuff is not otherwise under scheduler
> control and has preemption disabled.

It also doesn't work for memory reclaim since that shouldn't be
throttled in real time.  Reclaim and softirq seem to demand something
that doesn't move tasks onto runqueues, that's external to avoid getting
pushed off cpu.