Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp1155422pxb; Fri, 21 Jan 2022 11:02:32 -0800 (PST) X-Google-Smtp-Source: ABdhPJxQon+xdPew+93mvTsNn1/RvB7DMgGplnukKBKp78Fy2n7H+ve0liX/Ii/UW/tJec2rcy7J X-Received: by 2002:a17:90a:6288:: with SMTP id d8mr2042012pjj.199.1642791752196; Fri, 21 Jan 2022 11:02:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1642791752; cv=none; d=google.com; s=arc-20160816; b=SIhH+jkGermW1I2AAv+m8UEVcE/NQj9f3t6lo77qhTnQhIgK8H2wPOJXjUBJ3rFR1D V2z5jqfUJCCAbiNeXs1a+5LbNoI8DuaDox38OPLt5MRD0tUAkvgp6UYcqNYRi/vrKc/s 2C3q2QnUWYhEhhNLnJxvj7RgoLpEfc0LS9y88jxiaIPEM6RIJq+/VD842xtpUrPAxg03 sLAWVrmCkMK8wjy6Sp4KLV+Ro7m6H8mMnaokyO+iWj7zP7KVU077Yg+8bNyiUPkPfQOw aiQkbc0s3ZDO/+VGS0auJCCBPj4CCwZkjjq/BJgenr8C1kiEBKwYZUKdmkKDwXIqhZb4 KPoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:references :in-reply-to:mime-version:dkim-signature; bh=28KnNoVV1Kbl+7o1ojcz/PfZRpiIvLKDsWmtd4coQEU=; b=UAFrRzCzMD7HOzs1/F4AA0K7WVoZb9Khaf3HJHwpbhuse9TnUhEo78lSb9UPPKQxjK hDEaeRTY3EbS8fFQAOMTgBqB+eHSNLPRW5CKMZ6ZQZmAG4gbWSez/ALkQLeUAJLMgiK5 PqD/LlWtV7YAAL452F1GKf385SpJQq3Dtl2KgH5AflGWpD77DZQDWgpoddJJBOEWZ3te yoAHQVn/PgzedkENINSI0vGlA07AxI70mdYoj4Krk8f8bCmASYSAhLuCVmIRmoYu2XAn q5vW5YiWLGOkyeY7pm5E5Qr2LZJ8mGErpVahiytr9BsUlPZ706uZRoQoq9j5ql5BgRi/ PMng== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@zx2c4.com header.s=20210105 header.b=GmDnD7qK; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x6si6401829pjo.82.2022.01.21.11.02.18; Fri, 21 Jan 2022 11:02:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@zx2c4.com header.s=20210105 header.b=GmDnD7qK; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352688AbiASJJM (ORCPT + 99 others); Wed, 19 Jan 2022 04:09:12 -0500 Received: from dfw.source.kernel.org ([139.178.84.217]:40064 "EHLO dfw.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352786AbiASJJH (ORCPT ); Wed, 19 Jan 2022 04:09:07 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 502A461455; Wed, 19 Jan 2022 09:09:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 691A9C340E6; Wed, 19 Jan 2022 09:09:06 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="GmDnD7qK" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1642583343; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=28KnNoVV1Kbl+7o1ojcz/PfZRpiIvLKDsWmtd4coQEU=; b=GmDnD7qKe49YACCFbopCGc5ngi0WzKrXjuC5UT1Klfqho6xXR4ydzgLY6nPyZnlRMUkLdq nXzZ/sfhNSonNQ37z41vcVLjwM1cAekWm0mhCGr9cMEn1nwaWMaTgMC+6QZYNX/WxDr5gP UCeMOfuDJT8kZL3dY6BhFMpVVjoqzrM= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 5baddba0 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Wed, 19 Jan 2022 09:09:03 +0000 (UTC) Received: by mail-yb1-f173.google.com with SMTP id 23so5373375ybf.7; Wed, 19 Jan 2022 01:09:03 -0800 (PST) X-Gm-Message-State: AOAM532zNAMkrffr1ldRwhbA4TFl86uKDyI+vWm2QDg2kfZKzTfu4dZK uZHYJ4+VQq1ruUAXeVzC6D2eKRk7I+pNMGMqawA= X-Received: by 2002:a25:e7c7:: with SMTP id e190mr12455559ybh.457.1642583340917; Wed, 19 Jan 2022 01:09:00 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a05:7110:209:b0:11c:1b85:d007 with HTTP; Wed, 19 Jan 2022 01:09:00 -0800 (PST) In-Reply-To: References: <20220119082447.1675-1-miles.chen@mediatek.com> From: "Jason A. Donenfeld" Date: Wed, 19 Jan 2022 10:09:00 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] lib/crypto: blake2s: fix a CFI failure To: miles.chen@mediatek.com Cc: Herbert Xu , "David S. Miller" , Matthias Brugger , Greg Kroah-Hartman , Ard Biesheuvel , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Hey again, Actually... It looks like the issue is that in this file: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/crypto/internal/blake2s.h this line typedef void (*blake2s_compress_t)(struct blake2s_state *state, const u8 *block, size_t nblocks, u32 inc); should become typedef void (*blake2s_compress_t)(struct blake2s_state *state, const u8 *block, size_t nblocks, const u32 inc); Does making that change fix things for you? Thanks, Jason