Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp1155547pxb; Fri, 21 Jan 2022 11:02:41 -0800 (PST) X-Google-Smtp-Source: ABdhPJylWtn1h0mjndIY0HBDQmYiPTv+t3yf/1ZDs7A5Yf8QnQsbsGkRwlrn0hXVhX4KfaW3R2pD X-Received: by 2002:a17:90b:3510:: with SMTP id ls16mr2149611pjb.50.1642791761349; Fri, 21 Jan 2022 11:02:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1642791761; cv=none; d=google.com; s=arc-20160816; b=Yy5BP5GsOyPr69q8EzxuQBiBLBjqWsg6/Ych3/+lpyA3WoTqpKCAlzaz1E2m1BZ45R iULwuuvV++H52tNub7LW1b+NGD1a5yOA3SOH334uxbeqsdITtmCd4VGaKulXaTLwzrmb X3+jMYenKhBSTVVaYP9uuCdEdVCGhRghUHNLlwUs1dJchHWMc0tN0n/IMnk+Imxix7tZ BVH1VdNMOC1QkShAKqS5vk/lwacQr8SHbqOLCtbjB2gvmmAbwKnRXLSuwNKknGIpSY+E r4WV+BinC7YQRpFKgiOdwncf+VFvmluoJbrniOX+iI7XqGcknCeeBxXOTSjWbnqCIJkY 0ejw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:references :in-reply-to:mime-version:dkim-signature; bh=2dOFJ+UpcJtVObG5xI+XoGYifJptafHjJhs8HGfwX1w=; b=sbCNPnL0bdKOrr/mT4bPZteJPewYV6UzGW3KFs0DmGH+HYrsIicoagJ8NoV3EZ7xI/ OyG3qphzf9o5m4piTeLzGu7DJNJgQr4SwPPFdv6cP/2745TFJfGjA0LA2335hFKCOax+ 5KqEHBRHscd3bU0C/nJuFeutqfRhu4O/lFIhN99aLGsA/dxb5DR73ryvRBUI+eTQyWsr yZSGQPiLJTxtzridCuav1beevcYmhJelJwT04CmvHtH/Tkk53S2nHbDX/h4lZ8DWNv3s W/6zLrRZP55auCIeotiz/b2fa9o24xXOL5g4GiYTWCi4WV6c7zd8XpB5yrwk9XSTVhgT ZvFg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@zx2c4.com header.s=20210105 header.b=c3dQq4AT; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 22si7365419pgb.85.2022.01.21.11.02.29; Fri, 21 Jan 2022 11:02:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@zx2c4.com header.s=20210105 header.b=c3dQq4AT; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352767AbiASJAj (ORCPT + 99 others); Wed, 19 Jan 2022 04:00:39 -0500 Received: from ams.source.kernel.org ([145.40.68.75]:59532 "EHLO ams.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237437AbiASJAj (ORCPT ); Wed, 19 Jan 2022 04:00:39 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id F2793B81910; Wed, 19 Jan 2022 09:00:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 62C44C340E6; Wed, 19 Jan 2022 09:00:36 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="c3dQq4AT" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1642582833; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2dOFJ+UpcJtVObG5xI+XoGYifJptafHjJhs8HGfwX1w=; b=c3dQq4ATbm3F/187EqTQn/DEc2+TVz5Z6Leei8F10Yf3ixE2Uu6PJW8ci1EnHZrfZM0tzK HOkeqMqMuOacinhQ2L5LbbQObXWehm5LhxLXbvyOgx2P8gpomIxL5mz6xFs3X39Twpe18H 6UV6m97d9dMYHbb/v+7tKMp5de21ePo= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 421036da (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Wed, 19 Jan 2022 09:00:32 +0000 (UTC) Received: by mail-yb1-f171.google.com with SMTP id h14so5248579ybe.12; Wed, 19 Jan 2022 01:00:32 -0800 (PST) X-Gm-Message-State: AOAM530BhqfR3QltI3Z7G0ouie/zAHliCS+NY/St1793O9Xz0eMhzuTM GtHe7NGb1D1BfdzgEVAsDpWx6R8yivZkteqdB/M= X-Received: by 2002:a25:e7c7:: with SMTP id e190mr12418681ybh.457.1642582830614; Wed, 19 Jan 2022 01:00:30 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a05:7110:209:b0:11c:1b85:d007 with HTTP; Wed, 19 Jan 2022 01:00:30 -0800 (PST) In-Reply-To: <20220119082447.1675-1-miles.chen@mediatek.com> References: <20220119082447.1675-1-miles.chen@mediatek.com> From: "Jason A. Donenfeld" Date: Wed, 19 Jan 2022 10:00:30 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] lib/crypto: blake2s: fix a CFI failure To: miles.chen@mediatek.com Cc: Herbert Xu , "David S. Miller" , Matthias Brugger , Greg Kroah-Hartman , Ard Biesheuvel , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Hi Miles, Thanks for the patch. Could you let me know which architecture and compiler this was broken on? If I had to guess, I'd wager arm32, and you hit this by enabling optimized blake2s? If so, I'm not sure the problem is with weak symbols. Why should CFI break weak symbols? Rather, perhaps the issue is that the function is defined in blake2s-core.S? Are there some CFI macros we need for that definition? Jason