Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp2508354pxb; Sun, 23 Jan 2022 06:59:20 -0800 (PST) X-Google-Smtp-Source: ABdhPJzXv+Vt+kR/dYNWGG8XgmmXMyBwcf2JjGaQlvMapMgUN5W/xYEoL7soOyqvE4aYHV0ChLrz X-Received: by 2002:a17:902:b598:b0:14a:ca21:9737 with SMTP id a24-20020a170902b59800b0014aca219737mr11223425pls.73.1642949960038; Sun, 23 Jan 2022 06:59:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1642949960; cv=none; d=google.com; s=arc-20160816; b=jLL8zTMec+WYveOJTHp3WvlD4oeE6G/8bgHE9Rkb85CQwX4jTu9dBPLHgpVVMg/yfD r9/L0BgwdNmD1fQMac9JUZD7zZZcF5qj924esWcF/scTL1Efv6hAxMbIK1ajeRK+g5bi S8WVFd6Eo+oEycHBtg8XSWveo16dZPi5cZrgE2/3godroULL9EejkTAUzoFvGb/ybb1c NNiGntJcGpDPmWoXU5wpBS1rnfbXW9gK00mBKiCRi2HrbYbsxNAaZOMStNVhVNXVJlGM vr31kqgT8+FPmsIdDF+Mg4Fh8Vp/o6rTTipxTqc/qeXtb+6NfACCn6l6IhUxmkvL+Iqp 0pbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=4oXAVXk2JlBEkc01q5g3PJxjBXfZB0YboZf235nPSxw=; b=020PDzXD6m4trKGLsGOchobeGQPPULDV/IGtkyrHp1UjNY5PD9mAKMtQdKdb8tvUB8 CjHj6CngXage8crOnmn6kv5rok6szDFUvXCbAjzvW8mfk2NwVzDa8RJxSQ3ru6NiBxBz lfnJ2Xqy8u+60xENGWHwpmno8yoYDGuDafwHEaJH86KbgL4lmTC/Df0zsr+heWjyBfB7 0uHyhu+cREv0Y6/qTFAqDt7Afbzvb1R0HKRtPjwi4EeKDjpU+xKgN3ilJLh+WbS2NYO0 wJu4mtgY1cSsaVpeRTEeGAq4mpVEzgArwKuHlY4P5nLMSvCC0eYYE3mGXZyQyuhbwpxc IvDQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q13si10110610plk.365.2022.01.23.06.59.06; Sun, 23 Jan 2022 06:59:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230380AbiAVJfy (ORCPT + 99 others); Sat, 22 Jan 2022 04:35:54 -0500 Received: from szxga02-in.huawei.com ([45.249.212.188]:17360 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230011AbiAVJfx (ORCPT ); Sat, 22 Jan 2022 04:35:53 -0500 Received: from dggpeml500024.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4JgrgH22kmz9rxh; Sat, 22 Jan 2022 17:34:35 +0800 (CST) Received: from dggpeml100012.china.huawei.com (7.185.36.121) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Sat, 22 Jan 2022 17:35:51 +0800 Received: from huawei.com (10.67.165.24) by dggpeml100012.china.huawei.com (7.185.36.121) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Sat, 22 Jan 2022 17:35:51 +0800 From: Kai Ye To: CC: , , , Subject: [PATCH v2] crypto: hisilicon/qm - cleanup warning in qm_vf_read_qos Date: Sat, 22 Jan 2022 17:30:42 +0800 Message-ID: <20220122093042.40131-1-yekai13@huawei.com> X-Mailer: git-send-email 2.33.0 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.67.165.24] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpeml100012.china.huawei.com (7.185.36.121) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org The kernel test rebot report this warning: Uninitialized variable: ret. The code flow may return value of ret directly. This value is an uninitialized variable, here is fix it. Signed-off-by: Kai Ye --- changes v1->v2: modfiy the comments. drivers/crypto/hisilicon/qm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/hisilicon/qm.c b/drivers/crypto/hisilicon/qm.c index c5b84a5ea350..3b29c8993b8c 100644 --- a/drivers/crypto/hisilicon/qm.c +++ b/drivers/crypto/hisilicon/qm.c @@ -4295,7 +4295,7 @@ static void qm_vf_get_qos(struct hisi_qm *qm, u32 fun_num) static int qm_vf_read_qos(struct hisi_qm *qm) { int cnt = 0; - int ret; + int ret = -EINVAL; /* reset mailbox qos val */ qm->mb_qos = 0; -- 2.33.0