Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp4968563pxb; Wed, 26 Jan 2022 01:40:43 -0800 (PST) X-Google-Smtp-Source: ABdhPJzwMqv5BLutAvYkQGiCq6t3jg2Amoc3gmbHXn09rU5qqiUFV+bzl2czjhg3dUrPv3XLem0Y X-Received: by 2002:a05:6402:4487:: with SMTP id er7mr23866278edb.63.1643190043230; Wed, 26 Jan 2022 01:40:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643190043; cv=none; d=google.com; s=arc-20160816; b=X25wmnHBeSWVWBdD7u9prQ5XWVAkCuKgKrLpx86+totkzLx6ChL3nJIUaF2GxnCvA9 rSvF0XaO9291/eCbkm/+/kzXllm0PZTtXf7JpLCJiwyybu09g8bfCaEq1jv//0MLr0J5 RWwXNaqTjS3EerR6/DyGrtYVDgUysZgSSKIosO8N2ncU5EoiSCaYmHijpCmuZQCDcwum h1IbUOCV/6N6UQlwAjJp7pwAycn8SsFZatSr/tsRmgfV1RW8eBacbiCgcUQWaeEMRX+Z WsR5fN6gO0QBt2OnhWEcM3ccLbjFtAjhwRI7oKI88re7P1hBmHsI1aBRgsq8HVswO/TI gIrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=eAYuA3IYpDa6asQzwjsBPd1aG38lL6DwpQeaWb0KZyc=; b=O7P01rEUp6HFhSPiQqtTTN6q2bCAUBoL3ua9saNHNIuxIh5Ea9zEfjpbwnab/DYByg gN7nSS3LtU8y8LMl91vfNpVR32nnzud5qCskFpj/a+DZDhNnPjDQ/1MwdnYgPslY/6rY vag1Vtjs0NNRUzfakkxq+99+sozKP2tWhTtIOnKg5cRc/0lWoQAHVyGHlGyJoI/thwp8 0WKC1HQDVhUdbgMf+TRARlmCSFBv7hc/BIOpaogB/1o5aCBV9MYdpeknbMrNzXqX6L5Y iyM4JgtsoUVqRJkcR5JecWGsTfMyxBWAnCDhQkj7xChni/hp7hCTOPImIUMj4I9TWaKg +B/w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=u7umuGco; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o10si258025ejy.386.2022.01.26.01.40.16; Wed, 26 Jan 2022 01:40:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=u7umuGco; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231996AbiAYUa4 (ORCPT + 99 others); Tue, 25 Jan 2022 15:30:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36808 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232049AbiAYUaz (ORCPT ); Tue, 25 Jan 2022 15:30:55 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73569C06173B; Tue, 25 Jan 2022 12:30:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=eAYuA3IYpDa6asQzwjsBPd1aG38lL6DwpQeaWb0KZyc=; b=u7umuGcoWurUr5OPmMAUZ3xGOO YZiX6q/jpumt1aXHBk0BRLa5mmm9kCWWQpjv+D+DNgzXt/hAZ/1V8K68SoeXS2I4ruU9h1fnzRxL7 Q+v8WVLR5gsp86yCkzDQtJhNLAl0+mfJakpZ69hu4fKdKAkmEtvCPvmiRSlDnANtsDQT6pz4hjSzR xMbM9JQTQYMOR+ZtpeyzckbV9oBqTDIZOAdvoQRotKUuqC5AMSg6f3IBy3cCqcPm6s/ntnHh2qrQf Qn7DZFJJ/KLQ2aRQ9i+Rk7qAATcNDR2Tc7uzY7jX7MYwF/4xCi5ms7LWHkr//RCN1H/PeV/jKv5KR lb1i4Ksw==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nCSSq-009VdS-1L; Tue, 25 Jan 2022 20:30:52 +0000 Date: Tue, 25 Jan 2022 12:30:52 -0800 From: Luis Chamberlain To: Michal Suchanek , David Howells , Aaron Tomlin Cc: keyrings@vger.kernel.org, linux-crypto@vger.kernel.org, linux-integrity@vger.kernel.org, kexec@lists.infradead.org, Philipp Rudo , Mimi Zohar , Nayna , Rob Herring , linux-s390@vger.kernel.org, Vasily Gorbik , Lakshmi Ramasubramanian , Heiko Carstens , Jessica Yu , linux-kernel@vger.kernel.org, David Howells , Christian Borntraeger , Paul Mackerras , Hari Bathini , Alexander Gordeev , linuxppc-dev@lists.ozlabs.org, Frank van der Linden , Thiago Jung Bauermann , Daniel Axtens , buendgen@de.ibm.com, Michael Ellerman , Benjamin Herrenschmidt , Christian Borntraeger , Herbert Xu , "David S. Miller" , Dmitry Kasatkin , James Morris , "Serge E. Hallyn" , Sven Schnelle , Baoquan He , linux-security-module@vger.kernel.org Subject: Re: [PATCH v5 0/6] KEXEC_SIG with appended signature Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Luis Chamberlain Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, Jan 11, 2022 at 12:37:42PM +0100, Michal Suchanek wrote: > Hello, > > This is a refresh of the KEXEC_SIG series. > > This adds KEXEC_SIG support on powerpc and deduplicates the code dealing > with appended signatures in the kernel. > > powerpc supports IMA_KEXEC but that's an exception rather than the norm. > On the other hand, KEXEC_SIG is portable across platforms. > > For distributions to have uniform security features across platforms one > option should be used on all platforms. > > Thanks > > Michal > > Previous revision: https://lore.kernel.org/linuxppc-dev/cover.1637862358.git.msuchanek@suse.de/ > Patched kernel tree: https://github.com/hramrach/kernel/tree/kexec_sig > > Michal Suchanek (6): > s390/kexec_file: Don't opencode appended signature check. > powerpc/kexec_file: Add KEXEC_SIG support. > kexec_file: Don't opencode appended signature verification. > module: strip the signature marker in the verification function. > module: Use key_being_used_for for log messages in > verify_appended_signature > module: Move duplicate mod_check_sig users code to mod_parse_sig What tree should this go through? I'd prefer if over through modules tree as it can give a chance for Aaron Tomlin to work with this for his code refactoring of kernel/module*.c to kernel/module/ Luis