Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp4968565pxb; Wed, 26 Jan 2022 01:40:43 -0800 (PST) X-Google-Smtp-Source: ABdhPJynXP4Pq5RzVjFXrs9KZU2HxbLweX5nZc4yLhM9Yxddcv2ZELdsuGKJ6NauVdon3G14b9gA X-Received: by 2002:a17:907:2d06:: with SMTP id gs6mr9893395ejc.765.1643190043226; Wed, 26 Jan 2022 01:40:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643190043; cv=none; d=google.com; s=arc-20160816; b=xmEoqCVXcLPuur/aE2W8eYe1DzxO215t/sciSFzdiJPYleqJUisRNetbBMbfbjqGUg herFL4/CKI0ubkWDKQxN1Ut/6/d4TTmk4BMn60EyI0sgd+/czyG5XwGiTwVD9PDonK1/ Q2DwmFCW8Lz8uKuhjxBUWL6gFJtwpGBPfsWGrvm697KMkgq6KyA3comIVw6v+YgsSNvp yyd9CWTljdu+qMcPVyoLn0cco8NmQSoj4c95tCIv1C1BPDHX2dEP42vLN/K4TQI4j+Ag +BI2zE4FJdj/B96JLNgY7YkSKCLMMnPIoli9S8DSohmwCfYXCTvVntMBVh0oZ0JrzP+9 c1lQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=3Bb23zhtgzU7Wxmk6KGQnnxzZSeCxUCxB/mlyZEzbkg=; b=SO1oVGgL4ueq6u+mrN2CumHY4L6sUWnp7pv0DQDM2x/zyN7T8g4srdsZ784K1AFTxb 5TAKOf1ORA0ogYr23Ekqbslu23b9qUPg5zJGkvyuaz18KgySh9+NVBBxXi8U8xA5OQKL r7SRsv+IpA90PPy3bzawXILtm9aIBSzn2SvpYe6sJnz9zAYkrMsaHcaOQWm7HxA99Q0y Q4jp+8rZpvrcXq0te8Kk6O4/m04rizxQZQacH1kb1pnu1rFwFSs3CMaVxQC24IKzs28o c5HjqWlXT9vM+9ZxBpWPRJAhKAbQo/L6eSw05Uys9ofluE1/OojjEa4TAFkKbpRcOSa0 fG9w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=jfnP7t3V; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c18si10835220ejj.803.2022.01.26.01.40.08; Wed, 26 Jan 2022 01:40:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=jfnP7t3V; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231951AbiAYU1P (ORCPT + 99 others); Tue, 25 Jan 2022 15:27:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35938 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231945AbiAYU1P (ORCPT ); Tue, 25 Jan 2022 15:27:15 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5AE4CC06173B; Tue, 25 Jan 2022 12:27:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=3Bb23zhtgzU7Wxmk6KGQnnxzZSeCxUCxB/mlyZEzbkg=; b=jfnP7t3Va434azfa7CGwqEJbQ3 qHZG/qaQxtDi2ObBW5J1jYfDwVfVM7ZUb5kf4IPYmQuegN1jWD+hLfCoF4eox6NUOrbMDbRDvd01P JRJWLy/SP3edGvoUXvlMLgzz1kTXs+G5BrMyJV7syMki25lRyu8gdthFr1hhQvQHZupGC5DWg66N/ LEQ1I7WT1IB4ucPJrXH5MM71+fYSk0pRh4AF7UjEH0NX75oo6gxDediH1BwVk6Y3UAqpWY5jK9vW+ tzDWcn98pI0mUU6JoOfNXyWnp1tDG/xMPd+7rh9K+brTE+sbTmSPvJI5KJmcklnDNhzERB4gNoR6J gznneLpg==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nCSPJ-009Utb-SO; Tue, 25 Jan 2022 20:27:13 +0000 Date: Tue, 25 Jan 2022 12:27:13 -0800 From: Luis Chamberlain To: Michal Suchanek Cc: keyrings@vger.kernel.org, linux-crypto@vger.kernel.org, linux-integrity@vger.kernel.org, kexec@lists.infradead.org, Philipp Rudo , Mimi Zohar , Nayna , Rob Herring , linux-s390@vger.kernel.org, Vasily Gorbik , Lakshmi Ramasubramanian , Heiko Carstens , Jessica Yu , linux-kernel@vger.kernel.org, David Howells , Christian Borntraeger , Paul Mackerras , Hari Bathini , Alexander Gordeev , linuxppc-dev@lists.ozlabs.org, Frank van der Linden , Thiago Jung Bauermann , Daniel Axtens , buendgen@de.ibm.com, Michael Ellerman , Benjamin Herrenschmidt , Christian Borntraeger , Herbert Xu , "David S. Miller" , Dmitry Kasatkin , James Morris , "Serge E. Hallyn" , Sven Schnelle , Baoquan He , linux-security-module@vger.kernel.org Subject: Re: [PATCH v5 6/6] module: Move duplicate mod_check_sig users code to mod_parse_sig Message-ID: References: <687db74a714d50b9c83d7ac024da4f7dec0d9a1d.1641900831.git.msuchanek@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <687db74a714d50b9c83d7ac024da4f7dec0d9a1d.1641900831.git.msuchanek@suse.de> Sender: Luis Chamberlain Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, Jan 11, 2022 at 12:37:48PM +0100, Michal Suchanek wrote: > Multiple users of mod_check_sig check for the marker, then call > mod_check_sig, extract signature length, and remove the signature. > > Put this code in one place together with mod_check_sig. > > This changes the error from ENOENT to ENODATA for ima_read_modsig in the > case the signature marker is missing. > > This also changes the buffer length in ima_read_modsig from size_t to > unsigned long. This reduces the possible value range on 32bit but the > length refers to kernel in-memory buffer which cannot be longer than > ULONG_MAX. > > Also change mod_check_sig to unsigned long while at it. > > Signed-off-by: Michal Suchanek Reviewed-by: Luis Chamberlain Luis