Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp4968807pxb; Wed, 26 Jan 2022 01:41:06 -0800 (PST) X-Google-Smtp-Source: ABdhPJzKDwA5YKfrbcoQVpvXq9DymhdyBMs4Jt0T/6ORdVclmSqWRgtyPGlVHuyysSFa0DV5y7nS X-Received: by 2002:a17:906:35cd:: with SMTP id p13mr16680143ejb.353.1643190060600; Wed, 26 Jan 2022 01:41:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643190060; cv=none; d=google.com; s=arc-20160816; b=eCC8kNT3JW+DfUHh9V1hrGBPe0eymRcoopsBqk9HX9DxDRqlupg4YFWX72lurN9ctK IcgepiXP2QUqbBuft2G03AyGjKakJojP48Rl2vJ38oro9AcKZKlRY/bXCBVzimSkLJOE TiBd1KJBSTQ+nvwzPEhj4x5OkqLrZzQHDUnYCMJBp9ORFL+s+G9hmKmwFkm9AORFClxb GUri7fmPJhOAspQNDR8DvUBEOHrnUsWS4sNwtTeLlwK4AIkX3WcJ9WCZFKVyYcRd7F20 7fgrJLUO0TvERZX3S1lauegbUefFlRjb40v9g1FK0OXj21rMq//3pqvSYlXUuAdCByEE cM5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=8jiAAbr8zjyas8ne1Zsnl8EfrMwDftxtsxyZx5EZ57c=; b=VFhkEcyLQr04r9gPX21famfcNMlZ2xzji/GNFhpQplrN7J5/Jj4Cvf14iJOsY+4oHr MQTcEPpxHHVbMjw3c4Y0qWocdeW/Uy5LVMjzq8Td60FeyVu69ogxTO077NMnlpoIBhc9 vp+ZxkU+eYPqk95JPKaPoB+vrmkvFPxr3V1a8NdAUX+0VTGHAgzFnjPXm9AauxOWIwpV XY1FCJflHmkbEaKH2JWORPm9Vnxf9ZKwEO/UV+lK8PuyQgNrvFJi3SFh+n6YIbpKIrnf bFEPFFSS2ncLvw15b3B/+E2pNCHg1M9zGCiVIp7IVswrh3GWYCQ7fnM3jjdUM4PJYqak ZBCQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=Zs3kdWGP; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cw11si6391941edb.118.2022.01.26.01.40.36; Wed, 26 Jan 2022 01:41:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=Zs3kdWGP; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231853AbiAYUYE (ORCPT + 99 others); Tue, 25 Jan 2022 15:24:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35118 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231904AbiAYUXz (ORCPT ); Tue, 25 Jan 2022 15:23:55 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 02DC3C06173B; Tue, 25 Jan 2022 12:23:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=8jiAAbr8zjyas8ne1Zsnl8EfrMwDftxtsxyZx5EZ57c=; b=Zs3kdWGPYxRaR0Lyl8LsCxUojd FFbsw3pyxYrZ3IXIN8AF9RJ2qJ/Bmqcq2TAd6QT97fTEJJEFH59N5EDUXItL67rTvqu9CELDUkQ+i Uq1OFX4NMD28J5kX4RmW2tWk2EloLum46S6lt5QX8psuNiE8k3FRvZ5otiABScKNxYFCnOmYjIJ7f +Jf+ktkVVjy9xeba6ZX6Vk6EFOOytBwL3uw9rF5ICEep7gNmiJbbL9ISoXGxu/dq8g6Z96luSyUeh S4RZni/SQBT61HceEIDWZTN/SkrD1UpDe7IJTO6rRWoQOpjyw970iqk7dkaHA9OIckeBBYkUmjUDv rJLNxzvg==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nCSM3-009UF5-Sa; Tue, 25 Jan 2022 20:23:51 +0000 Date: Tue, 25 Jan 2022 12:23:51 -0800 From: Luis Chamberlain To: Michal Suchanek , David Howells Cc: keyrings@vger.kernel.org, linux-crypto@vger.kernel.org, linux-integrity@vger.kernel.org, kexec@lists.infradead.org, Philipp Rudo , Mimi Zohar , Nayna , Rob Herring , linux-s390@vger.kernel.org, Vasily Gorbik , Lakshmi Ramasubramanian , Heiko Carstens , Jessica Yu , linux-kernel@vger.kernel.org, Christian Borntraeger , Paul Mackerras , Hari Bathini , Alexander Gordeev , linuxppc-dev@lists.ozlabs.org, Frank van der Linden , Thiago Jung Bauermann , Daniel Axtens , buendgen@de.ibm.com, Michael Ellerman , Benjamin Herrenschmidt , Christian Borntraeger , Herbert Xu , "David S. Miller" , Dmitry Kasatkin , James Morris , "Serge E. Hallyn" , Sven Schnelle , Baoquan He , linux-security-module@vger.kernel.org Subject: Re: [PATCH v5 4/6] module: strip the signature marker in the verification function. Message-ID: References: <96d29773b9ef418a71b1d8bbfd0a456a0f996ec6.1641900831.git.msuchanek@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <96d29773b9ef418a71b1d8bbfd0a456a0f996ec6.1641900831.git.msuchanek@suse.de> Sender: Luis Chamberlain Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, Jan 11, 2022 at 12:37:46PM +0100, Michal Suchanek wrote: > It is stripped by each caller separately. > > Note: this changes the error for kexec_file from EKEYREJECTED to ENODATA > when the signature marker is missing. > > Signed-off-by: Michal Suchanek > --- > v3: - Philipp Rudo : Update the commit with note about > change of raturn value > - the module_signature.h is now no longer needed for kexec_file Reviewed-by: Luis Chamberlain Luis