Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp689120pxb; Fri, 28 Jan 2022 08:02:45 -0800 (PST) X-Google-Smtp-Source: ABdhPJyQRCDqM8xfil9Esf1Ttr3rSqgmgnWxJGz7n9O2IcSs/46pInv8QwaJkPPBZXRJtWk6lqop X-Received: by 2002:a65:494d:: with SMTP id q13mr7090972pgs.53.1643385765410; Fri, 28 Jan 2022 08:02:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643385765; cv=none; d=google.com; s=arc-20160816; b=C5gsLTqHtI15tBmJLVJsxni9+1pDc+1PU43iDQSI0kPS83KHSfG7sXMhcM7PIzMck1 Ufh9535/UC8NZs34rbqDZcb/t34ymojfRnEQ0nncqbMdO6Ae93ZMO98kXQIHdi00t777 UVJLvpKfz0GlLs2NvGOe8M1Y9M6YbK+0XWIAhhS4d9lCtZhe57kojHIj625KWS8gnS2h GS40SexmVFcmMDE3DlAcmiPADnDW7H7k9IVro61YPtPtNTMbNpMlV8xTVMK94Rxh64SY 5zy8yVEHhgyahpbkSQZfNSW/m4IJntBGYKy3XEf9yPJ7Z7r1HVqKrW7keT4RSnTY0Xbo 3wiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=VI2OCHCTrRQ8SkFsro+nXGiEE9GiG6Zlb8jDQC9Hr6g=; b=EWTd9JDW8ZY1nVSPsm4d+sXRApRx87D/mv2xVwC3IMSk4vDnFwUUSKXN6uBIRE3eUM bgciE8oxTzzkP2+FmCrjNbLJDYbGyE+Niq0VSj4x600TszM51pdrst7aROEZOTnOOVtl T5Au4gDWx3BH+jIgIpfSHk2Ij8mt5zbmCztb8Xwh5fZJjr1bWTxgv5NIJJNiXGNYg0pq sEiHhEMxQlj7xnyjXyVxShojlcePm6fx//DWzGUbBRkaLssAlZwHwE8aOuCsVY9VDQdt fX1IWMrghDc2DqNm/UX8DSVASlMchV+y2LxB0lvh7tb34HkqAGMZYfoz0c0OmRBad6dc L9hg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=o9aQjv8b; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e19si6987022pgl.703.2022.01.28.08.02.21; Fri, 28 Jan 2022 08:02:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=o9aQjv8b; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245410AbiA0TId (ORCPT + 99 others); Thu, 27 Jan 2022 14:08:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59148 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229628AbiA0TIc (ORCPT ); Thu, 27 Jan 2022 14:08:32 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9392C061714 for ; Thu, 27 Jan 2022 11:08:32 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6B80261DA1 for ; Thu, 27 Jan 2022 19:08:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9B7EEC340E4; Thu, 27 Jan 2022 19:08:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643310511; bh=5kqWoAmlJfPg69e6lBs1tqaVjvbcOmnI2o8rQ+u4OpY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=o9aQjv8bUW9e1zMOZDHPN2FrcJlRGCd0Wpz4sjQf8baqwBV55zNzvLh3J33k19MzU zMk5ScDrVjWPFSMSNjHm+fk77eNUSdZGQ4sJnxTZdKl5xN6T2/I1ZUq8j7XEGJPGVO T444N9/Y3Z9NtwmIOfMLpYEApCdopaxDGlRh2NNHge7RxBcYqGWwtS1yGCfmr59aug 8rdVYVeRXT8StvnBUYL3OFGZ/2St2bl5GwdRQsvVCf6HWpszNl2cLyTQiEwAeUrZUB IXaBSezL0AtF38GjnR/SsbKfeu5LWYsFMR+2E/fJJMoF6mPxZ788Pka+xIvDrPHM1l ILr5GUaI4buHw== Date: Thu, 27 Jan 2022 11:08:30 -0800 From: Eric Biggers To: Sandy Harris Cc: Linux Crypto Mailing List , Ted Ts'o , "Jason A. Donenfeld" , Herbert Xu , John Denker Subject: Re: RFC random(4) We don't need no steenking ... Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Thu, Jan 27, 2022 at 05:04:07PM +0800, Sandy Harris wrote: > Current code in extract_buf() declares a local struct blake2s_state, > calls blake2s_init() which uses initialisation constants Which is good, because BLAKE2s is defined to use certain constants. If different constants were used, then it wouldn't be BLAKE2s anymore, but rather some homebrew crypto with unknown security properties (like the old "SHA-1" that wasn't really SHA-1). > and moves data into the chacha state with memcpy(). It's actually XOR'd in. Please take a closer look at crng_reseed(). - Eric