Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Shijith Thotton <sthotton@marvell.com>
To:     Herbert Xu <herbert@gondor.apana.org.au>
CC:     "arno@natisbad.org" <arno@natisbad.org>,
        "bbrezillon@kernel.org" <bbrezillon@kernel.org>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
        Sunil Kovvuri Goutham <sgoutham@marvell.com>,
        Srujana Challa <schalla@marvell.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "chi.minghao@zte.com.cn" <chi.minghao@zte.com.cn>,
        "ovidiu.panait@windriver.com" <ovidiu.panait@windriver.com>,
        Suheil Chandran <schandran@marvell.com>,
        "Lukas Bartosik [C]" <lbartosik@marvell.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [EXT] Re: [PATCH v2] crypto: octeontx2: fix NULL pointer
 dereference
Thread-Topic: [EXT] Re: [PATCH v2] crypto: octeontx2: fix NULL pointer
 dereference
Thread-Index: AQHYDu506+NGMiNG1EOgNzFnpf+DMax39iqAgABczgA=
Date:   Fri, 28 Jan 2022 11:19:08 +0000
Message-ID: <SJ0PR18MB4429BDEA6327DB256A4AD38CD9229@SJ0PR18MB4429.namprd18.prod.outlook.com>
References: <3ef09bf0c4adf7bc33f01f60cb8ce96e8f77b58c.1642786900.git.sthotton@marvell.com>
 <YfOCkY3RL0qqn5YU@gondor.apana.org.au>
In-Reply-To: <YfOCkY3RL0qqn5YU@gondor.apana.org.au>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?g0hVPl7aEcr3++n3o7ieDkx149ENIW7zexP3I7TQLjRjGAu4vaRtDh3UmLoO?=
 =?us-ascii?Q?e4SuONX/IhMtZlwHFAVzbA0uX/7VYuQ3ykblAB6CkJCbMNRaCLgxMMrTks4f?=
 =?us-ascii?Q?VoM3RZnMqGJEQ6y8cRwUHlUa99l0iUJ3neUS8xIep+rOfcLM4HSK7LEWlstA?=
 =?us-ascii?Q?scC9X+TkNooZH551GS8NaFBXZyEvbeeH7IWTEIypz4Nm6QjlKaiAj4fzRTAy?=
 =?us-ascii?Q?eD2iwf4i8x79ZluO/k6lCFwMTJ1cVwraB7GtxIn8PLs39OujF9UBbP+D38b5?=
 =?us-ascii?Q?hX/rLAOl1rcQE4SfE4DsJQhYEZNaY4qFGTqTl9t15vdVp/u8zNc0n1XzyR53?=
 =?us-ascii?Q?vEBYnYgq7zMUW6ZyUihlRl4g04mYz82hJyQZiuKTLq14NI655Ppm1iusCxJB?=
 =?us-ascii?Q?9sox4cxVFzDfokoCDLvCmbJPfxtqCfQnImKyFmSw23mbXEvO2OxOrhH7z0Wo?=
 =?us-ascii?Q?ucvg2bJfezmCEgghw5lMzZ1L4nYo9wU0gE3qN+76tt1rfgbGqDZaaKZx/lRm?=
 =?us-ascii?Q?fP9hpXhN5BvGXxCeqoFZT9Uhr/F8hgwN9+z+86AKQftY1cCGtZ1/S3Vhj4hU?=
 =?us-ascii?Q?eLEuDb9d7ZnYaseVSI9TMFc7SdkcS0370vMp54ryburpV+6WesHQWuSUBkSn?=
 =?us-ascii?Q?Jvpkgal8ha9JT+Rx3PzBfZ4VbUaRPIoPXSuHZrQtXs8piS8+kSZCk82OQq7H?=
 =?us-ascii?Q?n2VumHmZXkGRPkSeek3i0Tnfyqo5p8Xv9LhtgO3aL+bBf3CYGjiKvucyWVwA?=
 =?us-ascii?Q?w2jd7QeicG9y38MROvOGVpQcZNDgBHAYFGRbe4vgbOhXLwixUzS8X2/gDHyl?=
 =?us-ascii?Q?DyzBRN8Gt8f/B95FSj45afLrQBXHoPbBHTDIC2RXY7rrccqFAJooLrRtHn2b?=
 =?us-ascii?Q?I1/2I4W/qy5H4O1sshnGF39pVFO3iKUBgI1ljTzcN34Po4jC8eGn3fWZq1t7?=
 =?us-ascii?Q?FZralJueV2XDvc3iGZGQ9vDpXodwKZtl9PRObi7CMPyrT73g5HRZ1w9toOmz?=
 =?us-ascii?Q?QZCs+yiFoeExqsvBuGsVRY9w+e0yT5vn66ccoXFzTNjuGCw/8p4NYFCLJXqV?=
 =?us-ascii?Q?n3ZEJ6R5qaDz0VGT0lgAY1zZT/vZv/sgksCITqNOXQ1YzmhYxKThfqr9Byf3?=
 =?us-ascii?Q?fsLNEqHSAgnNc+3ITiWyVFKoS0DWLhsBCqF9Jlj1ggEQIZtahlPz8bso1kuS?=
 =?us-ascii?Q?Knc8WDEpARaJOMZpj3cj12yzLjxZNAl/3tHk8hZqvXiXbF8hYljSY10kNZr/?=
 =?us-ascii?Q?VyuJOpa8SBDnge3KGUCqCEmooGhSWYaDHcBUezkVtdGEFslQUGRToTfn0FDb?=
 =?us-ascii?Q?BCgezHBivxAs91qXLIGhJEwy1LGvicrNlH8KAUwjBirXZTvq2/2zu6aTewVH?=
 =?us-ascii?Q?jgxniRbrShRSrf+5LSIUyJC5+R2CXi/b4VxF4ZiEzMi/wygFmT+LkSQZGMkk?=
 =?us-ascii?Q?80wvriap9R4uy0+MM2A3w0bWKWLUMEyqbo6pZH3cFGyG40vWPRjDHdDThglq?=
 =?us-ascii?Q?IT9ki9Ne8b288pK/x5Lp8izvrBx2i3eHQtvu7lacQg0kiO0fj3M0ik26Iw9k?=
 =?us-ascii?Q?qNxqM/UimMHvPQdLwoOSKIO5G14T+dbBVA8x6/E87Hs2VScXExoIThkzpi9o?=
 =?us-ascii?Q?pQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR18MB4429.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d7a4db91-f71c-41d9-2c51-08d9e25000d6
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jan 2022 11:19:08.6901
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: b5zRpmW6ELy73g84Um0uqnYSlI5YlGqiEBwMRpWylK4fptTYsLKFduHxhL6xIhy2zPxP6SZ8xAWcgfVKPkvYkw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY3PR18MB4593
X-Proofpoint-ORIG-GUID: EGtQSZgd62ys_ZIPtxIkr5uleIaNfB_w
X-Proofpoint-GUID: Qv5BozjnQEoh9XI_vm0jrwyVkc686DxO
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-01-28_02,2022-01-27_01,2021-12-02_01
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

>> diff --git a/drivers/crypto/marvell/octeontx2/otx2_cptvf_algs.c
>b/drivers/crypto/marvell/octeontx2/otx2_cptvf_algs.c
>> index 2748a3327e39..620fa9b23e78 100644
>> --- a/drivers/crypto/marvell/octeontx2/otx2_cptvf_algs.c
>> +++ b/drivers/crypto/marvell/octeontx2/otx2_cptvf_algs.c
>> @@ -1650,7 +1650,7 @@ static inline int cpt_register_algs(void)
>>
>>        err =3D crypto_register_aeads(otx2_cpt_aeads,
>>                                    ARRAY_SIZE(otx2_cpt_aeads));
>> -       if (err) {
>> +       if (err && !IS_ENABLED(CONFIG_DM_CRYPT)) {
>>                crypto_unregister_skciphers(otx2_cpt_skciphers,
>>                                            ARRAY_SIZE(otx2_cpt_skciphers=
));
>>                return err;
>
>A better fix would be to make the driver actually work with
>dm-crypt.  What exactly is the issue?
>
>Even if we have to keep the kludge, please move this into Kconfig
>as a dependency and simply disable the whole driver.
>

I have tested the latest driver with dm-crypt and found no issues.
I will send next version without the checks.

Thanks,
Shijith