Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <YgOQBNIdf0UnSH+M@Red>
In-Reply-To: <YgOQBNIdf0UnSH+M@Red>
From:   Gilad Ben-Yossef <gilad@benyossef.com>
Date:   Wed, 9 Feb 2022 19:45:12 +0200
Message-ID: <CAOtvUMeoYcVm7OQdqXd1V5iPSXW_BkVxx6TA6nF7zTLVeHe0Ww@mail.gmail.com>
Subject: Re: [BUG] crypto: ccree: driver does not handle case where cryptlen =
 authsize =0
To:     Corentin Labbe <clabbe.montjoie@gmail.com>
Cc:     Herbert Xu <herbert@gondor.apana.org.au>,
        Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
        Linux kernel mailing list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi,

On Wed, Feb 9, 2022 at 11:57 AM Corentin Labbe
<clabbe.montjoie@gmail.com> wrote:
>
> Hello
>
> Booting a salvator X with CRYPTO_MANAGER_EXTRA_TESTS lead to:
> [   37.510039] ------------[ cut here ]------------
> [   37.514712] WARNING: CPU: 7 PID: 616 at /home/clabbe/linux-next/kernel=
/dma/mapping.c:200 __dma_map_sg_attrs+0xb8/0x108
> [   37.525444] Modules linked in: des_generic ofb snd_soc_hdmi_codec dw_h=
dmi_cec dw_hdmi_i2s_audio rcar_du_drm rcar_lvds crct10dif_ce snd_soc_audio_=
graph_card simple_bridge snd_soc_simple_card_utils rcar_dw_hdmi dw_hdmi drm=
_cma_helper cec rcar_csi2 rcar_fdp1 v4l2_mem2mem vsp1 rcar_cmm videobuf2_vm=
alloc rcar_fcp renesas_usb3 snd_soc_rcar rcar_vin v4l2_fwnode v4l2_async vi=
deobuf2_dma_contig videobuf2_memops videobuf2_v4l2 videobuf2_common videode=
v pwm_rcar mc snd_soc_ak4613 max9611 ccree(+) renesas_usbhs phy_rcar_gen3_u=
sb3 libdes usb_dmac gpio_bd9571mwv at24 display_connector drm_kms_helper pw=
m_bl drm ecb xts cts essiv cmac xcbc ccm
> [   37.581446] CPU: 7 PID: 616 Comm: cryptomgr_test Tainted: G        W  =
       5.17.0-rc3-next-20220207-00110-g41bd5fbfc1e4 #5
> [   37.592672] Hardware name: Renesas Salvator-X board based on r8a77950 =
(DT)
> [   37.599555] pstate: 00000005 (nzcv daif -PAN -UAO -TCO -DIT -SSBS BTYP=
E=3D--)
> [   37.606526] pc : __dma_map_sg_attrs+0xb8/0x108
> [   37.610978] lr : __dma_map_sg_attrs+0x48/0x108
> [   37.615430] sp : ffff80000c1632a0
> [   37.618749] x29: ffff80000c1632a0 x28: ffff0004c2997c00 x27: ffff0004c=
2997e20
> [   37.625909] x26: 0000000000000000 x25: 0000000000000008 x24: 000000000=
0000000
> [   37.633068] x23: 0000000000000000 x22: ffff0004cc777840 x21: 000000000=
0000000
> [   37.640226] x20: 0000000000000000 x19: ffff0004c164c010 x18: ffff80000=
b3a72f0
> [   37.647385] x17: 0000000000000000 x16: 0000000000000072 x15: 000000000=
0000010
> [   37.654544] x14: 001fffffffffffff x13: 000000006894887f x12: 818235788=
794af1b
> [   37.661703] x11: 00000000000ef000 x10: ffff0004c164c518 x9 : ffff80000=
9aa6a38
> [   37.668862] x8 : ffff80000b2759d8 x7 : ffff80000c1633a0 x6 : 000000000=
0000000
> [   37.676021] x5 : ffff800009aa6a38 x4 : 0000000000000000 x3 : 000000000=
0000000
> [   37.683179] x2 : 74374306a1f1c500 x1 : 0000000000000000 x0 : 000000000=
0000000
> [   37.690338] Call trace:
> [   37.692789]  __dma_map_sg_attrs+0xb8/0x108
> [   37.696894]  dma_map_sg_attrs+0x10/0x28
> [   37.700739]  cc_map_sg+0x64/0xf8 [ccree]
> [   37.704711]  cc_map_aead_request+0x158/0x920 [ccree]
> [   37.709703]  cc_proc_aead+0x148/0xeb8 [ccree]
> [   37.714087]  cc_aead_encrypt+0x44/0x68 [ccree]
> [   37.718557]  crypto_aead_encrypt+0x44/0x78
> [   37.722669]  test_aead_vec_cfg+0x244/0x900
> [   37.726779]  test_aead_vec+0x8c/0x190
> [   37.730450]  test_aead+0x78/0xe0
> [   37.733687]  alg_test_aead+0xa4/0x3e0
> [   37.737358]  alg_test.part.29+0xb4/0x398
> [   37.741289]  alg_test+0x48/0x78
> [   37.744439]  cryptomgr_test+0x48/0x50
> [   37.748109]  kthread+0x11c/0x128
> [   37.751347]  ret_from_fork+0x10/0x20
> [   37.754939] irq event stamp: 119412
> [   37.758431] hardirqs last  enabled at (119411): [<ffff800009188a54>] _=
raw_spin_unlock_irqrestore+0x8c/0x90
> [   37.768105] hardirqs last disabled at (119412): [<ffff800009179e20>] e=
l1_dbg+0x28/0x90
> [   37.776040] softirqs last  enabled at (119376): [<ffff80000125ac20>] c=
c_send_request+0xa0/0x208 [ccree]
> [   37.785462] softirqs last disabled at (119374): [<ffff80000125abf4>] c=
c_send_request+0x74/0x208 [ccree]
> [   37.794883] ---[ end trace 0000000000000000 ]---#
>
> When cryptlen and authsize are both 0, the driver try to map a 0 size buf=
fer which display this warning.

Thank you very much, Corentin!

I thought we squashed all these corner case size bugs but it seems
this is not the case...

I am away from my test equipment right now for covid related reasons
but will dig into this (and your other patch), hopefully early next
week.

Thanks,
Gilad

--=20
Gilad Ben-Yossef
Chief Coffee Drinker

values of =CE=B2 will give rise to dom!