Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 11 Feb 2022 09:43:32 +0000
From:   Giovanni Cabiddu <giovanni.cabiddu@intel.com>
To:     Herbert Xu <herbert@gondor.apana.org.au>
Cc:     Wojciech Ziemba <wojciech.ziemba@intel.com>,
        linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
        qat-linux@intel.com
Subject: Re: [PATCH 0/3] Introduce support for QAT Dynamic Power Management
Message-ID: <YgYvxEwX7k5MOsqm@silpixa00400314>
References: <20220203135434.584967-1-wojciech.ziemba@intel.com>
 <YgYt5tFt+0CD/0V3@gondor.apana.org.au>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YgYt5tFt+0CD/0V3@gondor.apana.org.au>
Organization: Intel Research and Development Ireland Ltd - Co. Reg. #308263 -
 Collinstown Industrial Park, Leixlip, County Kildare - Ireland
Precedence: bulk

Hi Herbert,

On Fri, Feb 11, 2022 at 08:35:34PM +1100, Herbert Xu wrote:
> On Thu, Feb 03, 2022 at 01:54:31PM +0000, Wojciech Ziemba wrote:
> > This patch set consist of following updates:
> > 1. Add misc workqueue for general purpose usage.
> > 2. Move error source related CSRs from 4xxx to the wider GEN4 header
> > file.
> > 3. Add support for HW QAT Power Management (PM) feature.
> > 	This feature is enabled at init time (1) by sending an admin
> > message to
> > 	the firmware, targeting the admin AE, that sets the idle time
> > before
> > 	the device changes state and (2) by unmasking the PM source of
> > 	interrupt in ERRMSK2.
> > 
> > 	The interrupt handler is extended to handle a PM interrupt which
> > 	is triggered by HW when a PM transition occurs. In this case,
> > the
> > 	driver responds acknowledging the transaction using the HOST_MSG
> > 	mailbox.
> > 
> > 
> > Wojciech Ziemba (3):
> >   crypto: qat - add misc workqueue
> >   crypto: qat - move and rename GEN4 error register definitions
> >   crypto: qat - enable power management for QAT GEN4
> > 
> >  .../crypto/qat/qat_4xxx/adf_4xxx_hw_data.c    |  21 +--
> >  .../crypto/qat/qat_4xxx/adf_4xxx_hw_data.h    |  24 ---
> >  drivers/crypto/qat/qat_common/Makefile        |   1 +
> >  .../crypto/qat/qat_common/adf_accel_devices.h |   2 +
> >  drivers/crypto/qat/qat_common/adf_admin.c     |  37 +++++
> >  .../crypto/qat/qat_common/adf_common_drv.h    |   4 +
> >  drivers/crypto/qat/qat_common/adf_ctl_drv.c   |   6 +
> >  .../crypto/qat/qat_common/adf_gen4_hw_data.h  |  14 ++
> >  drivers/crypto/qat/qat_common/adf_gen4_pm.c   | 137 ++++++++++++++++++
> >  drivers/crypto/qat/qat_common/adf_gen4_pm.h   |  44 ++++++
> >  drivers/crypto/qat/qat_common/adf_init.c      |   6 +
> >  drivers/crypto/qat/qat_common/adf_isr.c       |  42 ++++++
> >  .../qat/qat_common/icp_qat_fw_init_admin.h    |   1 +
> >  13 files changed, 306 insertions(+), 33 deletions(-)
> >  create mode 100644 drivers/crypto/qat/qat_common/adf_gen4_pm.c
> >  create mode 100644 drivers/crypto/qat/qat_common/adf_gen4_pm.h
> 
> All applied.  Thanks.
I think this set needs to be reverted. Wojciech provided a v2 that fixed
a few regressions.

Thanks,

-- 
Giovanni