Received: by 2002:a05:6a10:7420:0:0:0:0 with SMTP id hk32csp2125903pxb;
        Sat, 19 Feb 2022 03:00:31 -0800 (PST)
X-Google-Smtp-Source: ABdhPJz+E0n3a5JnHyM85tjNM/SJfEjXq1k+EChvbheOoRtNQV59S65Ngeehev02fSD39xhqavbS
X-Received: by 2002:a17:906:1b4a:b0:6ce:b0cf:7fb8 with SMTP id p10-20020a1709061b4a00b006ceb0cf7fb8mr9761396ejg.429.1645268431275;
        Sat, 19 Feb 2022 03:00:31 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1645268431; cv=none;
        d=google.com; s=arc-20160816;
        b=juTm5A+wpNd8XAENwh6/7yIwh/IqX88a0jKOj9VtMMa/qNMLMajghEWR2Wg+TqaEfo
         Qc+A7AmjBsfaMM2QOkTwsfDCMCznVBknLnBsIEaunCe7mDfjVMe+kls/n3cSGcSC/xQJ
         8T/lsJtAzEsExLTctjOH7HojIq69TBr6IhxsJcm4zNCtJ/cXyl3NdOBhvQwe308d/gYG
         7diHiBOGXcfmY1PuR3ISEs3TAdPfjPPd8UZ52KL+Ho/Q/+qVe14otawKW/uZxPLuHuuM
         uK8hztfQJkrSr/8xanomw2dpvOqvWlwcK6ibh8RB0xPfaC2hN843+ZYP3msmC9kiULUC
         2tdg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:user-agent:in-reply-to:content-disposition
         :mime-version:references:message-id:subject:cc:to:from:date;
        bh=aDc68Cyy1pmh1wslH5aFlfMvtVfqm/V3teyk5/JMlec=;
        b=FfUhrab4LmRf6tRUxNItCaCzbQn1lEHslFW6/+hD5Lyi9jfbGJhqXaubbF8QigTOjD
         RBbMgJggNAK+eE/evu1eJcPRwLnzgMMh+sW8ZGaK3G3xRnFIXRD1lNxLCLZkx75lJA32
         xkfC0XV58sIPfUQdMQPpjdeNnl3nTub0PjEDBm9aa003KQEy9M31WsdhInKFKRV8x3DT
         pbh4B9przDbeJjo1+wk7fpzTgZCDkzecxi/YL/pr09/a/0MUXTh6o0QjY/dzJZpvlAh7
         nyCRzLOaKqc8OB62MBQDM4YzvhK5xBdHDlFo1TUPf1zGAYPHVxJC+SnP5cm97VDrEUA4
         CHig==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org
Return-Path: <linux-crypto-owner@vger.kernel.org>
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
        by mx.google.com with ESMTP id 13si5095014ejx.984.2022.02.19.03.00.07;
        Sat, 19 Feb 2022 03:00:31 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S241541AbiBSHNx (ORCPT <rfc822;benevolent.opressor@gmail.com>
        + 99 others); Sat, 19 Feb 2022 02:13:53 -0500
Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:34212 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S241542AbiBSHNw (ORCPT
        <rfc822;linux-crypto@vger.kernel.org>);
        Sat, 19 Feb 2022 02:13:52 -0500
Received: from verein.lst.de (verein.lst.de [213.95.11.211])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BEB7B15C1B0;
        Fri, 18 Feb 2022 23:13:34 -0800 (PST)
Received: by verein.lst.de (Postfix, from userid 2407)
        id 06F6668BEB; Sat, 19 Feb 2022 08:13:32 +0100 (CET)
Date:   Sat, 19 Feb 2022 08:13:31 +0100
From:   Christoph Hellwig <hch@lst.de>
To:     Baoquan He <bhe@redhat.com>
Cc:     linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        akpm@linux-foundation.org, hch@lst.de, cl@linux.com,
        42.hyeyoo@gmail.com, penberg@kernel.org, rientjes@google.com,
        iamjoonsoo.kim@lge.com, vbabka@suse.cz, David.Laight@ACULAB.COM,
        david@redhat.com, herbert@gondor.apana.org.au, davem@davemloft.net,
        linux-crypto@vger.kernel.org, steffen.klassert@secunet.com,
        netdev@vger.kernel.org, hca@linux.ibm.com, gor@linux.ibm.com,
        agordeev@linux.ibm.com, borntraeger@linux.ibm.com,
        svens@linux.ibm.com, linux-s390@vger.kernel.org, michael@walle.cc,
        linux-i2c@vger.kernel.org, wsa@kernel.org
Subject: Re: [PATCH 17/22] net: marvell: prestera: Don't use GFP_DMA when
 calling dma_pool_alloc()
Message-ID: <20220219071331.GC26711@lst.de>
References: <20220219005221.634-1-bhe@redhat.com> <20220219005221.634-18-bhe@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220219005221.634-18-bhe@redhat.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On Sat, Feb 19, 2022 at 08:52:16AM +0800, Baoquan He wrote:
> dma_pool_alloc() uses dma_alloc_coherent() to pre-allocate DMA buffer,
> so it's redundent to specify GFP_DMA when calling.

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>