Received: by 2002:a05:6a10:7420:0:0:0:0 with SMTP id hk32csp2132089pxb; Sat, 19 Feb 2022 03:09:45 -0800 (PST) X-Google-Smtp-Source: ABdhPJxM6RNSpId8TG9xImHCpTornuzTDZEAf6ia7aDYVVVrrzuyDVZjzaZQGUi1wKWI15KFcBv4 X-Received: by 2002:a17:906:68c2:b0:6b4:9f26:c099 with SMTP id y2-20020a17090668c200b006b49f26c099mr9691971ejr.41.1645268985690; Sat, 19 Feb 2022 03:09:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645268985; cv=none; d=google.com; s=arc-20160816; b=Vg4EJ7LEVM9hWjEPavv630FKHTzsKifwW2vlo+l7uJh3ovHikNLjPvEotdXxcZH4OL SACCc+I4hDHJ9SAF8VeEwFIdxbFaxGYU4Kmf1lIvG9lgZAcvdEAiozzCjcWVVjpSrYK8 YHgByw3A1oN3imXM0Yjppcbh6A33tzyT9SCAzaAErW3dYt6xhtxZ0bbJedi0wukXwDRA j/18LscPEiYfrkI4EHtqo3EXRsj91G1HwlEVhSyq8OPiEIoeXnywaQ01DdF9U6mRsI+g Dst/9e2W5DHEamVRoQkztkz3Vmu3JkTsUpITRYkvhzTmDQPifh88T5YHdR7UBZBpT6+0 t9PA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=us6kt3KF1Isz7L9WCL/FkzFlZ3P7VI9oqSsDxSAgbIQ=; b=jkLX44sqSj5pyy9tBPH0hUgJPY4guT5lSadczJgI8V3E+63ae3eYaQTCEysCrjMzYF OoJA5brp6QkWCGwQHanvVlq0j0m+G2sltWxPTUn29IgFChNLQRSo7qP+5iXr6CLguti3 7t2+XvKHW4PcMABLetApUaASy4YiNT+fwNk4aPIt6AhzmWr1hd37pj22G3ECTB4bHlze 9cd/3nmTyub7EhsTL6Zby2zFrKCeMLtLCxuWFuZZ97OSq6+QUT+Xo/Ej1Ue0LbOi5Ssd 496nGbevgdpmTYlQgGPBsKqgeLr+/XiR7eDxLZvXOw9VK2tZyyzcGtLQvSsN2g6KV/ys FzdA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r10si7549492eds.409.2022.02.19.03.09.19; Sat, 19 Feb 2022 03:09:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241410AbiBSHIV (ORCPT + 99 others); Sat, 19 Feb 2022 02:08:21 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:43004 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229800AbiBSHIU (ORCPT ); Sat, 19 Feb 2022 02:08:20 -0500 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8AF0725A31A; Fri, 18 Feb 2022 23:08:02 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id 848FB68BFE; Sat, 19 Feb 2022 08:07:59 +0100 (CET) Date: Sat, 19 Feb 2022 08:07:59 +0100 From: Christoph Hellwig To: Baoquan He Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, hch@lst.de, cl@linux.com, 42.hyeyoo@gmail.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, vbabka@suse.cz, David.Laight@ACULAB.COM, david@redhat.com, herbert@gondor.apana.org.au, davem@davemloft.net, linux-crypto@vger.kernel.org, steffen.klassert@secunet.com, netdev@vger.kernel.org, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, linux-s390@vger.kernel.org, michael@walle.cc, linux-i2c@vger.kernel.org, wsa@kernel.org Subject: Re: [PATCH 03/22] gpu: ipu-v3: Don't use GFP_DMA when calling dma_alloc_coherent() Message-ID: <20220219070759.GC26505@lst.de> References: <20220219005221.634-1-bhe@redhat.com> <20220219005221.634-4-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220219005221.634-4-bhe@redhat.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Sat, Feb 19, 2022 at 08:52:02AM +0800, Baoquan He wrote: > dma_alloc_coherent() allocates dma buffer with device's addressing > limitation in mind. It's redundent to specify GFP_DMA when calling > dma_alloc_coherent(). Looks good: Reviewed-by: Christoph Hellwig