Received: by 2002:a05:6a10:7420:0:0:0:0 with SMTP id hk32csp2348243pxb; Sat, 19 Feb 2022 08:46:14 -0800 (PST) X-Google-Smtp-Source: ABdhPJwSg4YmUrFG2vUG6cNh03irfIFAspgblMG+EwuBAfvq7YdLoRxUWifHXneRjYzFSZ2InU/H X-Received: by 2002:a05:6402:35c1:b0:412:8359:b8ac with SMTP id z1-20020a05640235c100b004128359b8acmr13712920edc.222.1645289174537; Sat, 19 Feb 2022 08:46:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645289174; cv=none; d=google.com; s=arc-20160816; b=bvIEeoheescyraMlb1qtm5phlWrd7GssNOQUo0CqLk2fHD2+G0Fa+Q0ggdfLIQVVyA 26na+Cc5V974+2M1NMYVFRLYPTQZgRTCIeq3+wEiJTWiyzvlowGWw/D8Ab1agr4j+ixr kNySszc2f1acQN6weyttiXjtKwzvLA3gKjFvSGSvsVe7ZuemLnNd9ghQFx+OGKrFljZ1 yxC1oDt7egiPGx2TID13ljc5Tl3XbbN1DChd5YW+EYwx8vLTqFCAQKT/nfa25GWi6p6l rjpL2HO6/LU/tSyoJJq5NPOZNJ/DjT5qPnlAGJx73UofIrZJ6iDnC74b6PTI7Gp7gnbz g/Dg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=MwwWOhLebaLDlpyB/vCc4pLeo1kWVJ64Cy+2hzkeMmw=; b=oqoHEXq6Lze/Gv8DCouR5xWe1beISq6CZ/2+asLXMEpaE9tPZi8Bd8/1ZZfM8WUwWA Cm/MUHhUjSMfXRkDms3WbpP6jFen3w+xthrlNduCIE5158I9WPzKLIvqdt6FiQAL/P3m KAuJNNH9M71Hsbg/8/n8AXifUhtbedOxcWxU506I/LrUCnkHweCYasB7wn5iN1L88DVU Bq+3fIuhVyEvaGrGOMlldi1sJqnAZbX0lN6+w/TuBv3kWlc2KoeGvXsgxWfK7h+hEan8 tN7MIZ3D1ycn4ImckGKvosYPPskHAB/3p60Z5hPwayzt3JnQ4QaUiUFbSS9r1O6IPDKo 2isw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sh20si5835815ejc.301.2022.02.19.08.45.42; Sat, 19 Feb 2022 08:46:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241512AbiBSHJ6 (ORCPT + 99 others); Sat, 19 Feb 2022 02:09:58 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:50014 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237613AbiBSHJ4 (ORCPT ); Sat, 19 Feb 2022 02:09:56 -0500 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5F50025A968; Fri, 18 Feb 2022 23:09:26 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id 9BF7868D05; Sat, 19 Feb 2022 08:09:23 +0100 (CET) Date: Sat, 19 Feb 2022 08:09:23 +0100 From: Christoph Hellwig To: Baoquan He Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, hch@lst.de, cl@linux.com, 42.hyeyoo@gmail.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, vbabka@suse.cz, David.Laight@ACULAB.COM, david@redhat.com, herbert@gondor.apana.org.au, davem@davemloft.net, linux-crypto@vger.kernel.org, steffen.klassert@secunet.com, netdev@vger.kernel.org, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, linux-s390@vger.kernel.org, michael@walle.cc, linux-i2c@vger.kernel.org, wsa@kernel.org Subject: Re: [PATCH 09/22] usb: cdns3: Don't use GFP_DMA when calling dma_alloc_coherent() Message-ID: <20220219070923.GI26505@lst.de> References: <20220219005221.634-1-bhe@redhat.com> <20220219005221.634-10-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220219005221.634-10-bhe@redhat.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Sat, Feb 19, 2022 at 08:52:08AM +0800, Baoquan He wrote: > dma_alloc_coherent() allocates dma buffer with device's addressing > limitation in mind. It's redundent to specify GFP_DMA when calling > dma_alloc_coherent(). replace it with GFP_KERNEL. Plase avoid the overly long line. The rest looks good.