Received: by 2002:a05:6a10:7420:0:0:0:0 with SMTP id hk32csp2888212pxb; Sun, 20 Feb 2022 03:41:09 -0800 (PST) X-Google-Smtp-Source: ABdhPJzW+6MaPy4lqgTVxH6tjcwXVMLAdQPhwApEC/7XEXKyv4NojtHnGNA1nYP+Uoc1c/uiqWiw X-Received: by 2002:a17:907:3c10:b0:6b9:6f01:37b2 with SMTP id gh16-20020a1709073c1000b006b96f0137b2mr12814424ejc.656.1645357269696; Sun, 20 Feb 2022 03:41:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645357269; cv=none; d=google.com; s=arc-20160816; b=RmuEK1ih8EYJCkU4LQQfWhMPanDbKbhPCNxYz5O4g0wztaNF3LeRii5FUSjoAIY3Zg xn8OiZgRCavQdHLEbwCblvxLUZonp65SXyCkzrY/4IlyGOjFcSNwH8DSYF+EQ7FleKSv gxLxV/7Xz63T4uB4E1r1ejO79TrzjQa+5LoO0/Lz6c4nvfYg6MG2a+Cj3svGYmwWkrpD tSf23pjaGnROI31inj4W0Hm8+CR3pNjUeNzNst0weeecxPVHlM71mARQdZy9I+Sj5Qme 2bNl+85I+rpEVKh7mUA9moaQdlBuyTU38/qUFHg67WeB7cjAFurvj8FgJodZOXs0EYRa WBzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=WYb14RNKKDe/2UiuNUKbKkVd5DhpBy26s7LI7PTfRt8=; b=eKvaLgEoZk1M4AXdwLhiGvZWFjovPQJUTBZ+bguVKHLbR8pxG0/Ph7xsNt3Ypj7mKD 34h2x0HwACn9Aql0V7xC3PNqFNOrcHQdvjZ6xuyNaOHshAh7VqiaPxpnYbZMRobdwzT8 HQSbMaNiD7LOj8RhT0LErkxYVpRlpY6HWAc0pNayNOm0A9j5prAxdkIFPw2PuC2LoO3n R9zNEWMdqjabbwpEimRBgJUCdLurjRIfJ4lMflJV+f0SI4SJMpWfi9G91mzjeo6p+ZXC 1NVtT8Mg7dV6/JCVZ1Cn4js5j5wIcLlcEd1im8EYXyp7YUHqfk6An/YB5Picvvn/DOpa PxpQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cf27si8971242edb.471.2022.02.20.03.40.34; Sun, 20 Feb 2022 03:41:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241470AbiBSHJI (ORCPT + 99 others); Sat, 19 Feb 2022 02:09:08 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:46078 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241455AbiBSHJC (ORCPT ); Sat, 19 Feb 2022 02:09:02 -0500 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B0EC25A95C; Fri, 18 Feb 2022 23:08:43 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id BEE6468D05; Sat, 19 Feb 2022 08:08:40 +0100 (CET) Date: Sat, 19 Feb 2022 08:08:40 +0100 From: Christoph Hellwig To: Baoquan He Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, hch@lst.de, cl@linux.com, 42.hyeyoo@gmail.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, vbabka@suse.cz, David.Laight@ACULAB.COM, david@redhat.com, herbert@gondor.apana.org.au, davem@davemloft.net, linux-crypto@vger.kernel.org, steffen.klassert@secunet.com, netdev@vger.kernel.org, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, linux-s390@vger.kernel.org, michael@walle.cc, linux-i2c@vger.kernel.org, wsa@kernel.org Subject: Re: [PATCH 06/22] fbdev: da8xx: Don't use GFP_DMA when calling dma_alloc_coherent() Message-ID: <20220219070840.GF26505@lst.de> References: <20220219005221.634-1-bhe@redhat.com> <20220219005221.634-7-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220219005221.634-7-bhe@redhat.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Sat, Feb 19, 2022 at 08:52:05AM +0800, Baoquan He wrote: > dma_alloc_coherent() allocates dma buffer with device's addressing > limitation in mind. It's redundent to specify GFP_DMA when calling > dma_alloc_coherent(). Looks good: Reviewed-by: Christoph Hellwig