Received: by 2002:a05:6a10:7420:0:0:0:0 with SMTP id hk32csp3106517pxb; Sun, 20 Feb 2022 09:26:25 -0800 (PST) X-Google-Smtp-Source: ABdhPJxVCal5ZgoDCziKg90BKHd/agRWBEb9vZAkVjhnh0V1foT3Zf37LPHmb9GtjXbXGo4Qlhz8 X-Received: by 2002:a17:906:3a55:b0:6ce:c2ee:3e10 with SMTP id a21-20020a1709063a5500b006cec2ee3e10mr12936893ejf.210.1645377985547; Sun, 20 Feb 2022 09:26:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645377985; cv=none; d=google.com; s=arc-20160816; b=QSLA66zhXMyAiSyEt4JOq84XxkhX5OqhpBhPL0dNncGXytASs/YC/dPHLgGOtozB9N 5m08kyWUa1bSJCLsfKQ+bdQAqt3hEIEVoX9ELImgTXcbTFayE0CNuTC15bEZ9P9VNLJY r63zxNp0T4qrHSpRgal653CEpraNwCQFn+k9lsmDz19WZ1Y0dLQxwNvpaaUObEc3bz/S O3hsxHMntMbjBlsIWLzJkhc2hdx5GQanCL96A7b/Mf6oC4V2xD1JVGWlwOOr5LltucT9 UhiTyguv5baZNHwsp9/ZCtHEZPdF3OaGDqfabHvo4r+plkipgZKtSNCFIG14FF2aAxiZ qZFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=u2ijpkdl86nrNHWfaMOE9RUcbsdibGXAwn5G0KvUqDI=; b=e91LOAZVvDZ1hkTfxaWkYzIIymbtqL7dA3oIZGlJ5DCfFVT7wiNMiziPphbOMMvfaE 5zHQvygUFiBBiH+PthIZGDhUTmCp1VJHSf6iBLqVDSiQAq+RZVamb1WukqlZcGgLQbK9 r2aohnl2DUqeYGPzJ6PafTi0MFsWzBO3t4+UdqGDqTahd9IWF64m3ERHTJ9LyQA4f7T2 e7QVgNzvya6pXcHWnFIx7kgQQpR/tGvPb09IJtsN8kwc3iD108VbbLQ54BSphZ4ehQQf 2QNu/0krV7MGMW2X0lTOmz+RGfpDOg1d4xQuz/WzrZTMXO2zwkIXfipGiqjRa6HRtPeX VR2A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e2si8848091ejs.226.2022.02.20.09.25.51; Sun, 20 Feb 2022 09:26:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241436AbiBSHIy (ORCPT + 99 others); Sat, 19 Feb 2022 02:08:54 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:45572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241444AbiBSHIv (ORCPT ); Sat, 19 Feb 2022 02:08:51 -0500 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC57D25A945; Fri, 18 Feb 2022 23:08:32 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id D2DF468CFE; Sat, 19 Feb 2022 08:08:29 +0100 (CET) Date: Sat, 19 Feb 2022 08:08:29 +0100 From: Christoph Hellwig To: Baoquan He Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, hch@lst.de, cl@linux.com, 42.hyeyoo@gmail.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, vbabka@suse.cz, David.Laight@ACULAB.COM, david@redhat.com, herbert@gondor.apana.org.au, davem@davemloft.net, linux-crypto@vger.kernel.org, steffen.klassert@secunet.com, netdev@vger.kernel.org, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, linux-s390@vger.kernel.org, michael@walle.cc, linux-i2c@vger.kernel.org, wsa@kernel.org Subject: Re: [PATCH 05/22] sound: n64: Don't use GFP_DMA when calling dma_alloc_coherent() Message-ID: <20220219070829.GE26505@lst.de> References: <20220219005221.634-1-bhe@redhat.com> <20220219005221.634-6-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220219005221.634-6-bhe@redhat.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Sat, Feb 19, 2022 at 08:52:04AM +0800, Baoquan He wrote: > dma_alloc_coherent() allocates dma buffer with device's addressing > limitation in mind. It's redundent to specify GFP_DMA when calling > dma_alloc_coherent(). > > [ 42.hyeyoo@gmail.com: Update changelog ] > > Signed-off-by: Baoquan He > Acked-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> Looks good: Reviewed-by: Christoph Hellwig