Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2cead7a0-8e52-54a6-831d-3ba1e2b277cd@suse.de>
Date:   Mon, 21 Feb 2022 15:11:48 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH v4 02/15] crypto: kpp - provide support for KPP spawns
Content-Language: en-US
To:     Nicolai Stange <nstange@suse.de>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        "David S. Miller" <davem@davemloft.net>
Cc:     =?UTF-8?Q?Stephan_M=c3=bcller?= <smueller@chronox.de>,
        Torsten Duwe <duwe@suse.de>,
        David Howells <dhowells@redhat.com>,
        Jarkko Sakkinen <jarkko@kernel.org>,
        linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
        keyrings@vger.kernel.org
References: <20220221121101.1615-1-nstange@suse.de>
 <20220221121101.1615-3-nstange@suse.de>
From:   Hannes Reinecke <hare@suse.de>
In-Reply-To: <20220221121101.1615-3-nstange@suse.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 2/21/22 13:10, Nicolai Stange wrote:
> The upcoming support for the RFC 7919 ffdhe group parameters will be
> made available in the form of templates like "ffdhe2048(dh)",
> "ffdhe3072(dh)" and so on. Template instantiations thereof would wrap the
> inner "dh" kpp_alg and also provide kpp_alg services to the outside again.
> 
> The primitves needed for providing kpp_alg services from template instances
> have been introduced with the previous patch. Continue this work now and
> implement everything needed for enabling template instances to make use
> of inner KPP algorithms like "dh".
> 
> More specifically, define a struct crypto_kpp_spawn in close analogy to
> crypto_skcipher_spawn, crypto_shash_spawn and alike. Implement a
> crypto_grab_kpp() and crypto_drop_kpp() pair for binding such a spawn to
> some inner kpp_alg and for releasing it respectively. Template
> implementations can instantiate transforms from the underlying kpp_alg by
> means of the new crypto_spawn_kpp(). Finally, provide the
> crypto_spawn_kpp_alg() helper for accessing a spawn's underlying kpp_alg
> during template instantiation.
> 
> Annotate everything with proper kernel-doc comments, even though
> include/crypto/internal/kpp.h is not considered for the generated docs.
> 
> Signed-off-by: Nicolai Stange <nstange@suse.de>
> ---
>   crypto/kpp.c                  |  9 +++++
>   include/crypto/internal/kpp.h | 75 +++++++++++++++++++++++++++++++++++
>   2 files changed, 84 insertions(+)
> 
Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		           Kernel Storage Architect
hare@suse.de			                  +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer