Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Eric Snowberg <eric.snowberg@oracle.com>
To:     zohar@linux.ibm.com, jarkko@kernel.org, dhowells@redhat.com,
        dwmw2@infradead.org
Cc:     herbert@gondor.apana.org.au, davem@davemloft.net,
        jmorris@namei.org, serge@hallyn.com, eric.snowberg@oracle.com,
        stefanb@linux.ibm.com, nayna@linux.ibm.com,
        mic@linux.microsoft.com, konrad.wilk@oracle.com,
        keyrings@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-crypto@vger.kernel.org, linux-security-module@vger.kernel.org
Subject: [PATCH 1/4] KEYS: Create static version of public_key_verify_signature
Date:   Tue,  1 Mar 2022 12:36:48 -0500
Message-Id: <20220301173651.3435350-2-eric.snowberg@oracle.com>
In-Reply-To: <20220301173651.3435350-1-eric.snowberg@oracle.com>
References: <20220301173651.3435350-1-eric.snowberg@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4ioemPi3nVN4Y7O14zF61Q7uGsUT/0jrOtbqmLiT9QoiIZ8CipDpZ89zhFQc?=
 =?us-ascii?Q?lAjtbx2E8Q7zqNXFpdJI725xyB4Up111z35YsngtzOGZWhk+Ie9S8S6eb7Ya?=
 =?us-ascii?Q?Y27bLb4p6iZYlV2YGqJo8tdgaCuCTsQjtIFreyNBiBK8LkYG1m6y7OoQYeny?=
 =?us-ascii?Q?LD3UdT3/trT/ASVeLnmzV6WFamhRQx+Ulw+LRFNs0gFjhNk7rwnNkT43FKLu?=
 =?us-ascii?Q?cinAYT+vVGPTObkWFG8P0rEH0X9m5PXD30G+QBHkvrxrEIseBz+yiqSIuqW3?=
 =?us-ascii?Q?UkyHVba9MBjmfy4M5xUXLk28ZAnfzk6do045a1R834AXMqBE7uMF8bDt1Dn4?=
 =?us-ascii?Q?Vy3ztil669MV5imUTNnaqow5O/xvGFWkS/UwIYwUhROdIZfc5tWVw/d7ihbU?=
 =?us-ascii?Q?cfi9rm6Cdq6a8sLoQKVi+QdtB4hO55kn6fOdKY2/Og2Ol55l8ADIvHIa5jux?=
 =?us-ascii?Q?No0wREC19dtlt1Lmiqk/lJWAE202nHTsoGiqfMIGK+qLpZ/FbPNANaVinooB?=
 =?us-ascii?Q?z2MTBJWxoSJt3V9DbXyFCZFNAcO/Hq+5eXV/9qYVFbBBGLpJrvaw973zryfB?=
 =?us-ascii?Q?qR3wdnwcU5GHVkl18q3OOmBEkWZJ3JcNI5dQeYCRo4++D1rwSD7GCJYuPalA?=
 =?us-ascii?Q?1zq41HV5TNeDkbWY/xQdnKm+O+zgx3Pxu3842pCSRCo65kAxEtdVc1LseMGU?=
 =?us-ascii?Q?faSRan8EfV93wKncTZ/CVSjhTlhJo8b0zA46PVNcxbDzOvRZ4DOkePQ2VUTY?=
 =?us-ascii?Q?UPT1tNOY76FaElHRe6vX8MT/dW4kFjK9jKnutI4X9PaOJ45ZSP6SzlGmzSCx?=
 =?us-ascii?Q?O/9TTqd4Y7F9cIiAdd9abT4QDVPtPGZYUXw8z+7VuWQSS2eP4cFevxIriRTh?=
 =?us-ascii?Q?b9J84QR3IiB7EbVtVpSM5bOQuL2iYV+JNmQYr8qv/xHfd4QMPMIWSVCKkScz?=
 =?us-ascii?Q?ZQHICDhmtzKpJoTD9rR76ikugyrlXVurdXTbm/k9CbaL+YxztVq/Gr0DW+VA?=
 =?us-ascii?Q?S4+Hi8dDGCf3HIvMyyc6/hx9fwFz86wC4ec4b6qwiNQs7cBOUeXoPmTN81E6?=
 =?us-ascii?Q?DjMPdRTyYZKMnoa0NNK2RXH1623UbcpCrk9oHrYnbqNuGLTsmEgR1LUPtKXQ?=
 =?us-ascii?Q?bvMNk+ovhVHNJbTvi/AdaFajJdRQAf3JHGVRFetqff5YcV9IqtjpPG1V7f4s?=
 =?us-ascii?Q?FnNln7uAd5alc+bt6vbiTFQNKMuzVCK+DPpYgxhtUdQ8zGPNeOhM+sOkSrZF?=
 =?us-ascii?Q?8LT+iL4+kFwn1lf6QLhHlSmYPAd51x1GOAoqHZFtJQN/D45Ox3YtdcsA9QeE?=
 =?us-ascii?Q?ldJnK4WOB0124BRk2o6hUsifGsgLmeKUD6mcmgZExI1PyCjxnOfHw+xkdUY2?=
 =?us-ascii?Q?UAEqfk8Kq57XjE7O8yxQhK0cHclM53C+M5EPyHx3krA+eE/MvRIt9CpslxDS?=
 =?us-ascii?Q?iVvCdV/T949cJzxqnekbzHK5Svhmu/ore4J3UZWjqCD7P3PMFNEBj8vK4G8g?=
 =?us-ascii?Q?8OLMyG0yr/jtpWpVdsKep6bpmbKcQTreKAQmkWDt2+aXkEZRBxBRI/RV5u6r?=
 =?us-ascii?Q?OBA8qEeI1tWcvvnhN6j4ZzaCKfIRvqCBHglnKnayhYzgVxXw6CLS6eFhxDfj?=
 =?us-ascii?Q?IlAQ0dBB69oQ7UdNenkXaC6qw+KwRoBrTg7wObSv1Gn2W7FElwU8S7iwDP6W?=
 =?us-ascii?Q?DohdUA=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 36aa0204-3323-4486-59b6-08d9fbaa6065
X-MS-Exchange-CrossTenant-AuthSource: CH2PR10MB4150.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2022 17:39:03.2246
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: B2QHQqSo28LfaAK0pQ1kPJkQQLo1ZfrsSoQjQeMTduGO+ChKfN/D0S74QNQzYdwIPUmUzQkrR9xm9seGvd8n0IqSA3nm/9uD+PiqbfTOURg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB2795
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10273 signatures=685966
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0 phishscore=0
 bulkscore=0 adultscore=0 spamscore=0 suspectscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2203010091
X-Proofpoint-ORIG-GUID: K_BwSsW4TlIQJuVc7yFk-W4lJjVGKU3J
X-Proofpoint-GUID: K_BwSsW4TlIQJuVc7yFk-W4lJjVGKU3J
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

The kernel test robot reports undefined reference to
public_key_verify_signature when CONFIG_ASYMMETRIC_PUBLIC_KEY_SUBTYPE is
not defined. Create a static version in this case and return -EINVAL.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Eric Snowberg <eric.snowberg@oracle.com>
Reviewed-by: Mimi Zohar <zohar@linux.ibm.com>
---
 include/crypto/public_key.h | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/include/crypto/public_key.h b/include/crypto/public_key.h
index 68f7aa2a7e55..6d61695e1cde 100644
--- a/include/crypto/public_key.h
+++ b/include/crypto/public_key.h
@@ -80,7 +80,16 @@ extern int create_signature(struct kernel_pkey_params *, const void *, void *);
 extern int verify_signature(const struct key *,
 			    const struct public_key_signature *);
 
+#if IS_REACHABLE(CONFIG_ASYMMETRIC_PUBLIC_KEY_SUBTYPE)
 int public_key_verify_signature(const struct public_key *pkey,
 				const struct public_key_signature *sig);
+#else
+static inline
+int public_key_verify_signature(const struct public_key *pkey,
+				const struct public_key_signature *sig)
+{
+	return -EINVAL;
+}
+#endif
 
 #endif /* _LINUX_PUBLIC_KEY_H */
-- 
2.27.0