Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp1221443pxm; Thu, 3 Mar 2022 12:48:33 -0800 (PST) X-Google-Smtp-Source: ABdhPJyH01PlsuLVquPXZtG5uf2cvbDZAPUXJAr6ybk8ZnNClT+VvwT89tlI9lhHbb0CcE7a6Nac X-Received: by 2002:a17:906:bc9b:b0:6da:9f90:a56a with SMTP id lv27-20020a170906bc9b00b006da9f90a56amr2438268ejb.575.1646340513149; Thu, 03 Mar 2022 12:48:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646340513; cv=none; d=google.com; s=arc-20160816; b=iDqufNGC37SPnZybmllB/I8P7UuUV/KZogmp6ixtNacM4aVXveGABv/JkipN+dueSx HkNedIY/XYFv8WLSJ7kzk1CG0F2jcn1VZvVOr078C+tsFIltP11AApmqShJER7uFZDPd 3VbM/7DdCGNoENiP+Qnv7dch7Rt93NkMq3RMiIkRuALBUYhZ2HZrYFRdm4djy6EGQMJg vXb1XGLwwEwfYYx084xHxVdh6ZaROiDw1fenRb1k5uO4bZDyeODpDlS7gA5C+Lu/TS0S y/iyGEDHeaZrVswArW5NsBlUxJhddabqIhzzIiv008XA1ACyMPuftKQurBhcci5L4Bi+ jdFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:organization :mime-version:message-id:date:subject:cc:to:from:dkim-signature; bh=FGHUxUUid2OruxJSVcl6QFAutUzNik6CE97IJlrfs+M=; b=D61OopksDmJQUZkFNYQ8iXuTG7ndptv5k5lBKnIhuIn9g7PrjXCxy4gMxc4mjBbA3N 1xKEiaElMQ+d9qZUuFGAtufCwJ2oanrejNYtqbgdErdfza6kyr+wEaBclIpcLe0eVCFv oxmhbOyp/lMDlDn5GuAzxBKKX/bIYhnwmvHawNatR20nMKLCinnGhA1gE5IlENoXoU8s PS5YEvFVygOKitcK6DrSbojhx8adsSaG9Vw5P5hRQSACvwFzNd8X5/8c2ZaaZafYKtAO 3Rg1lUL2ojSnsjgieU6qP/BZUo8Q1X9/Ji021ynmDT7RHGcpViOZKpXDfaPQa5/C5bSr IoFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="drc+nZM/"; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cm1-20020a0564020c8100b00410d2a0d015si1998278edb.485.2022.03.03.12.47.58; Thu, 03 Mar 2022 12:48:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="drc+nZM/"; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231932AbiCCSOT (ORCPT + 99 others); Thu, 3 Mar 2022 13:14:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57120 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230013AbiCCSOT (ORCPT ); Thu, 3 Mar 2022 13:14:19 -0500 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78C00EA75F for ; Thu, 3 Mar 2022 10:13:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646331213; x=1677867213; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=4xqR1BVOwp+QcHniOrSt1P56q9F4HFPOe+k9p60BXFw=; b=drc+nZM/+VHnI/qSso5G3iSEAscyz7CpCsddLM+mfxUE7z5NlqQKHesf V8b1mkhxWEO7/goxHR0gRpJjrLedDwgwc7USBKRs9EwGnTFbs+uJ7KvdD X/t2dzIxQapsIeDJsZfbgOfqiZ/pNkULgv5KDKQeQwME+MSUFYnCjKK9D jd8KhTfiy2biAEipZBv262sqq1xjPujGWI6sC38wKBMLiO9OJhnuESX9n Zb1ppzcCxrYvVeoRJ+EEKHmvbirnUjLsoQ+gzqnOiLunitGxKe2OSY78n UONbw0gnWejS7jjaClfu+6dzQZxMrjKoHuuZY19Bws77CL/0PBWeBOOQO w==; X-IronPort-AV: E=McAfee;i="6200,9189,10275"; a="278447731" X-IronPort-AV: E=Sophos;i="5.90,151,1643702400"; d="scan'208";a="278447731" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Mar 2022 10:00:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,151,1643702400"; d="scan'208";a="640279624" Received: from silpixa00400314.ir.intel.com (HELO silpixa00400314.ger.corp.intel.com) ([10.237.222.76]) by fmsmga002.fm.intel.com with ESMTP; 03 Mar 2022 10:00:48 -0800 From: Giovanni Cabiddu To: herbert@gondor.apana.org.au Cc: linux-crypto@vger.kernel.org, qat-linux@intel.com, Kyle Sanderson , Vlad Dronov , Giovanni Cabiddu Subject: [RFC 0/3] crypto: qat - fix dm-crypt related issues Date: Thu, 3 Mar 2022 18:00:33 +0000 Message-Id: <20220303180036.13475-1-giovanni.cabiddu@intel.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Organization: Intel Research and Development Ireland Ltd - Co. Reg. #308263 - Collinstown Industrial Park, Leixlip, County Kildare - Ireland Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org This set fixes the issues related with the dm-crypt + QAT driver use-case. The first patch fixes a potential dead-lock that might occur when using dm-crypt + QAT in out of memory conditions. The datapaths of the aead and skcipher implementations have been changed to use pre-allocated buffers that are part of the request contexts. The second patch addresses a stall in the dm-crypt + QAT usecase by adding support for the CRYPTO_TFM_REQ_MAY_BACKLOG flag. If the HW queue is full, the driver enqueues the request in a list and resubmit it at a later time, avoiding losing it. The last, removes the CRYPTO_ALG_ALLOCATES_MEMORY flag from the aead and skcipher implementations so that the driver can be used by dm-crypt. Although the set is functional, I marked it as RFC as I want to do some code improvements on the second patch, `crypto: qat - add backlog mechanism`, do additional performance profiling and optimizations. Giovanni Cabiddu (2): crypto: qat - use pre-allocated buffers in datapath crypto: qat - remove CRYPTO_ALG_ALLOCATES_MEMORY flag Vishnu Das Ramachandran (1): crypto: qat - add backlog mechanism drivers/crypto/qat/qat_common/adf_transport.c | 12 + drivers/crypto/qat/qat_common/adf_transport.h | 1 + .../qat/qat_common/adf_transport_internal.h | 1 + drivers/crypto/qat/qat_common/qat_algs.c | 305 +++++++++++++----- drivers/crypto/qat/qat_common/qat_crypto.h | 26 ++ 5 files changed, 269 insertions(+), 76 deletions(-) -- 2.35.1