Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 4 Mar 2022 16:57:20 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>
Cc:     kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-crypto@vger.kernel.org, linux-pci@vger.kernel.org,
        alex.williamson@redhat.com, cohuck@redhat.com,
        mgurtovoy@nvidia.com, yishaih@nvidia.com, linuxarm@huawei.com,
        liulongfang@huawei.com, prime.zeng@hisilicon.com,
        jonathan.cameron@huawei.com, wangzhou1@hisilicon.com
Subject: Re: [PATCH v8 8/9] hisi_acc_vfio_pci: Add support for VFIO live
 migration
Message-ID: <20220304205720.GE219866@nvidia.com>
References: <20220303230131.2103-1-shameerali.kolothum.thodi@huawei.com>
 <20220303230131.2103-9-shameerali.kolothum.thodi@huawei.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220303230131.2103-9-shameerali.kolothum.thodi@huawei.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?2Kt01ho33ImBR+3HDCB+n7uFucG4IoKwlpF/VgeVutiqaMGGFkvH5+WQ06rl?=
 =?us-ascii?Q?KpANkBL3m5W3xzAgs9RRHAH78U97VwX+DBql+x3OcRUfaRSlQX1IBAQmRWxc?=
 =?us-ascii?Q?T3/ovZ9slHnyfVKKpVl2HqQ2bRarmi6UaOZLrhqJ2pmKk8pfjgMD0vo45eZG?=
 =?us-ascii?Q?HiP5E8dpc3F78M7fu0acMBEKcJYFHXQrFsVLAzM+pJWFsm/0omyF2bFquegG?=
 =?us-ascii?Q?PRzbfmTJS2+14szNj3qxRdRonITd6QeOlgR1X4ns/ewh23/eOVZojdD6ZkpL?=
 =?us-ascii?Q?hRkyVQ3d+o8y+r03jIV3HwF+IdYrY3/pUt6q9p8ZVdNwJXrmkIATaGk7inyL?=
 =?us-ascii?Q?TUruh9qZL1WrWvTdM076KPN9gjjfK649MgRFHgAWYWwh7hfJ808Uic4FkNQy?=
 =?us-ascii?Q?V8h4iROa0Z5arF88IJ+LlDs8lTRzAdXyWAgORmfo0JsASAzyMdkaZvFgWFCu?=
 =?us-ascii?Q?k4cTJOTLwvb/k2qcWmRHsrOLYuysAjN4cNY74nyeHF3ZnvVGT3j33NKlDiVX?=
 =?us-ascii?Q?VDuG4+c1EZqIANtSzDyLe9PTebxfwGjVm0k2spNakGys4v9eG3HYInxQmd63?=
 =?us-ascii?Q?vpt1x4Boi+Nv0b3FRxfpbhZAfPb0LFMqjNCeyBuamSU2GdfMJ2lD9gx7opeC?=
 =?us-ascii?Q?Os3ZFmVaf/+eVPJQmy+Kbj63ykkL/sPkcBcNt/9X/weiDLQU4oplcO96+KDC?=
 =?us-ascii?Q?qsihr2s1/5TRodvBWmuBi+HvcwflRjxK5RtQb1W3BGKxfXIgFrsBsxTBu5TF?=
 =?us-ascii?Q?ZbrlzgSkHRCu953UQEYoUMQfVwyrMQou+/RErq5LQ7AK7xfa6a5vG4Jbxptm?=
 =?us-ascii?Q?uQmQdoruPRZJ0eoM+6VnUBs4n+I6gXqhMSu8nRMfR1eDo/RhkpIaScwC78GM?=
 =?us-ascii?Q?ANKNCq68I4mmvrEHw/cR7rx1zoc3MET3FwzvbtKYGyDvDWodxL1q5TDRRofx?=
 =?us-ascii?Q?Mv63ZxhAcwK5DqsM6nee7dKPHPeKyTjDjb/BhvaZnur0AI0KYY81VCAawNyK?=
 =?us-ascii?Q?xaiSDl7Y4mFWlNbTxE51KEeA+S58oiWzF8EyCbEbrU5NBwqER9u11B7iXO+W?=
 =?us-ascii?Q?p//HfCXbQmS8n4jOp51hIMyfeuBYpPlgbxw5uadO3jeJ/omvs0Q39UWIGRtt?=
 =?us-ascii?Q?iQu4IWSkJ/AkLX5NXxPjXKyqloZM+amz6rVEgFTpKhyU2JTuh3r4Hf1DFl4J?=
 =?us-ascii?Q?1FRT8hRLXu2Jnr3rfU77AUoAflakkighVhGSSB6aRsFwv+RApNfJRZckFRzH?=
 =?us-ascii?Q?PRcRrsXNOsYUDxvxVD1nJJxf9FYKHmIAeey1KePe/rLt3n4J5+jPqyMlPvs0?=
 =?us-ascii?Q?vSKFgvS7u7BNLNqQOX6CNs7kgGcOwkE4DTbqPExC7kIaxEITq3MkQ3aOV/t9?=
 =?us-ascii?Q?nEAr59wtUcC3WMk6l1/gZFtu3ilOwSxtzwcS3z7jUYfP39tzOzOLUqQ//Bgd?=
 =?us-ascii?Q?b+PXKDIXtn1BMqE8wxSalLUrClOlg0XOYgL/DKAcNziSvRL+RQ3GCCzzHL7Q?=
 =?us-ascii?Q?lUPGNGQRkuZbcqJjylvi7RRUTTPnq36FtEcTjF/X1UddE+QmRLWvlmTALKVw?=
 =?us-ascii?Q?34JiXPiHmaw2J/zShJk=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b84b89af-8942-4085-3715-08d9fe219395
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2022 20:57:21.4759
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VT7hQZn8KZc6epSnTNyuG3Uk4G/1bxjJasjtD6AjLTe04X1ohnfTEk7+2ynJla90
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1150
X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On Thu, Mar 03, 2022 at 11:01:30PM +0000, Shameer Kolothum wrote:
> From: Longfang Liu <liulongfang@huawei.com>
> 
> VMs assigned with HiSilicon ACC VF devices can now perform live migration
> if the VF devices are bind to the hisi_acc_vfio_pci driver.
> 
> Signed-off-by: Longfang Liu <liulongfang@huawei.com>
> Signed-off-by: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>
> ---
>  drivers/vfio/pci/hisilicon/Kconfig            |    7 +
>  .../vfio/pci/hisilicon/hisi_acc_vfio_pci.c    | 1078 ++++++++++++++++-
>  .../vfio/pci/hisilicon/hisi_acc_vfio_pci.h    |  114 ++
>  3 files changed, 1181 insertions(+), 18 deletions(-)
>  create mode 100644 drivers/vfio/pci/hisilicon/hisi_acc_vfio_pci.h
> 
> diff --git a/drivers/vfio/pci/hisilicon/Kconfig b/drivers/vfio/pci/hisilicon/Kconfig
> index dc723bad05c2..2a68d39f339f 100644
> --- a/drivers/vfio/pci/hisilicon/Kconfig
> +++ b/drivers/vfio/pci/hisilicon/Kconfig
> @@ -3,6 +3,13 @@ config HISI_ACC_VFIO_PCI
>  	tristate "VFIO PCI support for HiSilicon ACC devices"
>  	depends on ARM64 || (COMPILE_TEST && 64BIT)
>  	depends on VFIO_PCI_CORE
> +	depends on PCI && PCI_MSI

PCI is already in the depends from the 2nd line in
drivers/vfio/pci/Kconfig, but it is harmless

> +	depends on UACCE || UACCE=n
> +	depends on ACPI

Scratching my head a bit on why we have these

Looks OK though:

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason