Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>
CC:     "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
        "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
        "jgg@nvidia.com" <jgg@nvidia.com>,
        "cohuck@redhat.com" <cohuck@redhat.com>,
        "mgurtovoy@nvidia.com" <mgurtovoy@nvidia.com>,
        "yishaih@nvidia.com" <yishaih@nvidia.com>,
        "linuxarm@huawei.com" <linuxarm@huawei.com>,
        "liulongfang@huawei.com" <liulongfang@huawei.com>,
        "prime.zeng@hisilicon.com" <prime.zeng@hisilicon.com>,
        "jonathan.cameron@huawei.com" <jonathan.cameron@huawei.com>,
        "wangzhou1@hisilicon.com" <wangzhou1@hisilicon.com>
Subject: RE: [PATCH v8 5/9] hisi_acc_vfio_pci: Restrict access to VF dev BAR2
 migration region
Thread-Topic: [PATCH v8 5/9] hisi_acc_vfio_pci: Restrict access to VF dev BAR2
 migration region
Thread-Index: AQHYL1LgK0paKWluGU+nIOk/ItMZEqy1Br3A
Date:   Tue, 8 Mar 2022 06:23:29 +0000
Message-ID: <BN9PR11MB527681F9F6B0906596A77A178C099@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20220303230131.2103-1-shameerali.kolothum.thodi@huawei.com>
 <20220303230131.2103-6-shameerali.kolothum.thodi@huawei.com>
In-Reply-To: <20220303230131.2103-6-shameerali.kolothum.thodi@huawei.com>
Accept-Language: en-US
Content-Language: en-US
dlp-version: 11.6.401.20
dlp-product: dlpe-windows
dlp-reaction: no-action
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ti0pNHqUrPdJ+s6J+RGSXgM1uUWmPrZmfm0sI5CmqAoThXlvFGf7n6ofuOGW?=
 =?us-ascii?Q?2tYIkCbZM1g9MS01B9PGcmTtYQBCGIECEJCNZ9OJrkTeMG/A8iuZR14Rx52Z?=
 =?us-ascii?Q?zAjahRJHJ+Izyv1e4HyJxzcOPA9VJ+S6Z3PCL7ShJUA146bYnkQ9MOFuh9xT?=
 =?us-ascii?Q?QkwH9KhDrAhz/rOKoPHcf6D3EX31gx+cyME7LiOMRY8u1QQKdF05uFIltnWg?=
 =?us-ascii?Q?SBJfGVNLrATh0gD/kG+ch5frTviZSCOEET7cEoyNLIbrte9lCzAbfojjO8na?=
 =?us-ascii?Q?U6nldZBxtMYMrh48K+9m6892Qdyi5cs76zrzCAMQk3wngCo+v/hrM2mYFhIz?=
 =?us-ascii?Q?x9kEHW/Bl8/bgxotlmd8lbP/x1i6GpNPHE/aWWlaHH/yKEussp7M/AucXpsH?=
 =?us-ascii?Q?SJ+NZ3s6eoejs0H2pP07+CIsysG8nZmjmqnUO6AaeBkZGptpC/eUbq0vjiUF?=
 =?us-ascii?Q?0L/Plws7rTL1slMQWEuyrIsbnQBaDJJHP6F3wFL2IRcwtJ64Vh4Vl1yu1OB+?=
 =?us-ascii?Q?UQrbHLpMM3CBPaVnvwpCDN4tSAQ2MnagsiFJ6ASfpmXFLc3DUHM2axvkobKS?=
 =?us-ascii?Q?29eX2iI5rGVeB7jlS6BxHi4HQv6dFyFR974JS1gqZzsKOJbsgoCC7OwKPDK0?=
 =?us-ascii?Q?f+yc9cTYTrF08U/Sl6p3q249jltdfwd3RviKJNAIx1YRnGLF+DxXOv9U5CJB?=
 =?us-ascii?Q?w0cuMk04I3zeqF2B6fTqSXIl8NfjWVCLlLYvTBw2TkiV7jDtib4DhU5Ixf21?=
 =?us-ascii?Q?yb/VNcS/oZZZanyqaQV8m51Iy4anhxkKW0wthOsVviH7cOya+ZEDYikDq+QG?=
 =?us-ascii?Q?GHPYPQC79OLq4RbIAYodL2/mA0KVRoSIJ2MgOizcJ6CR5KuodUE9kwDoPcsg?=
 =?us-ascii?Q?0DLIqWV1amG4ST3VLrWO3etEc7hIFoNJ9P0XfuGV4rU6iKn5NsRe2eX+weB2?=
 =?us-ascii?Q?ocoDpAcb1+0CnASsOYKWyUO3eIubyb3d5Gq3/vCA2QxG4EjMg+vvXzzSh4Sq?=
 =?us-ascii?Q?e0EBjuR8BgMPfMNp2+xLMzFFlUsWr0s0yJETGqYC2yERUmTO1ZVGGi9TIyb8?=
 =?us-ascii?Q?6Jcm2jKUAMWdXHL/OX8mnnq5iK8+WUnSwqdcE7SXGsbl86TqlLpwwEHO6JCG?=
 =?us-ascii?Q?4Bw2yWKU38xyoKx5b/sbEVYk+LIBV7FO8/nzv9dCsVM8y3moTpEE0EWBJRnm?=
 =?us-ascii?Q?fCsFGxsZf3MqRcq3l3drDTei3WUTQ9p6UYAhVV14IrrYLB4ph3Hy2As140uK?=
 =?us-ascii?Q?m+OF8Ip8OMEuC6uzuUVga5cw84zkfpejQvGCxVEeuX92nfblsP/3sdivhHz6?=
 =?us-ascii?Q?RNGWloISz/Hd5pEbP+CHArKsuxbQFu/JK90jzr2YE6LfMCZ/vpgJTUwEALpF?=
 =?us-ascii?Q?ht83PDQn2i30nrIz0z7bTZgPVv6X0B5Djvt8wDcag28p4+wAcUM2fSqF1xws?=
 =?us-ascii?Q?D34LbwXUSClv+oK4V53B65eeYCnhWXiB+AD5IYQKhBoy5QkkyMPMXCnCKo23?=
 =?us-ascii?Q?O/le3HY71MG6qTOyz9rd5XX56dRF/wAEy7069khf4aoIcdP7u4uLmX7ky3qB?=
 =?us-ascii?Q?j0JhiGd65nufmdqEWYLWU1Qan5XFlKFBphwuUdHxs8cYrDQryrCjgilO5jPj?=
 =?us-ascii?Q?YA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 004ac928-bcb8-425b-2df9-08da00cc2998
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Mar 2022 06:23:29.6889
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: GTTgr2BUj9nPGngOrb/4PVBdPjc3RZudKRTeMDF5nc+WrIIhX6k0XBO15m7zEVEav5bxKgWA+nD7lC6IvIZGmA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR11MB3683
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

Hi, Shameer,

> From: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>
> Sent: Friday, March 4, 2022 7:01 AM
>=20
> HiSilicon ACC VF device BAR2 region consists of both functional
> register space and migration control register space. From a
> security point of view, it's not advisable to export the migration
> control region to Guest.
>=20
> Hence, introduce a separate struct vfio_device_ops for migration
> support which will override the ioctl/read/write/mmap methods to
> hide the migration region and limit the access only to the
> functional register space.
>=20
> This will be used in subsequent patches when we add migration
> support to the driver.

As a security concern the migration control region should be always
disabled regardless of whether migration support is added to the
driver for such device... It sounds like we should first fix this security
hole for acc device assignment and then add the migration support
atop (at least organize the series in this way).

Thanks
Kevin