Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp969564pxp; Wed, 16 Mar 2022 23:00:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz9d1LZkRYpGbwYj00QsYUofGP00GIJZLbxAjXmLUgf10G05Vob2u/uliFOfkomrcmQ564k X-Received: by 2002:a17:90a:990c:b0:1bc:3c9f:2abe with SMTP id b12-20020a17090a990c00b001bc3c9f2abemr3536722pjp.220.1647496851497; Wed, 16 Mar 2022 23:00:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647496851; cv=none; d=google.com; s=arc-20160816; b=tuWmi8Be4AdOCSjrnJ/o4BP95v8p8TyExJsJOz/3MaEj6l9B6Ox+w3DDg+3J9qF9of bpiv7YIk1cwEHyVE0FiVZ+BbRoufjcFEeIbNQ+ajVb/U2NpvJv2QZclaVP8XPZiGIuMX 5NjQ62ARvpYVA5fwaC6Hk7Akjn2RIiDdxfUzTd11YdwmRYzAhxEUHu4MKwOzZIa4nTO0 YNRmn/i568eTvO94QyY1PZx4mAeELncjvD0FfXtLAZhLMmCOSC3c/CXZfvCqIEIt84+/ t90qXfqUXNqh/60wKkdhRMzKYnDuxD9muf4cnkIDs82Ixg/OBaOxe44xqO9g3WdSXOKo JtvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=gFkdxDIeYbGE/3bPeE4z/3YJOthWjShRMvk+Cwn6b+Y=; b=Q8ZFenQAiwcNV7P/2h8NdF3V3Af4tHqrqJb4D8lRlEv103HlOe63XA3y1KAdLo5B9V zEg0VUwz5CasaIRScgwGVo0/ggmKcjMonm0EX8QR5p77U+PdNo63/NOG9FVwla1wxB+T TjEkqAzEID0EPMpZNvjKqZdO4Q3XxeBlWKvmO0B5Onm1+14wU3o6u/5ijMowTyf+uE8l jvA4eg/xet4k8VWFMH7jOo3r/RNUIUM340w1gWwOZ7miqoLklQI1lRzNztNtA056ss7b V17e927EmbAMSk20CzlJNFSuKhZXg2sK5wxkPXQ4nqkOLELPoqSq++E2DVa/o2AcOgrD Z0gw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id z4-20020a170902834400b0015337a859f3si3438417pln.506.2022.03.16.23.00.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Mar 2022 23:00:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 96BEE18B7A6; Wed, 16 Mar 2022 22:00:01 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358260AbiCPWMF (ORCPT + 99 others); Wed, 16 Mar 2022 18:12:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35324 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1358320AbiCPWL5 (ORCPT ); Wed, 16 Mar 2022 18:11:57 -0400 Received: from fornost.hmeau.com (helcar.hmeau.com [216.24.177.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08A2D286D4 for ; Wed, 16 Mar 2022 15:10:19 -0700 (PDT) Received: from gwarestrin.arnor.me.apana.org.au ([192.168.103.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1nUbqS-000809-IF; Thu, 17 Mar 2022 09:10:17 +1100 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Thu, 17 Mar 2022 10:10:15 +1200 Date: Thu, 17 Mar 2022 10:10:15 +1200 From: Herbert Xu To: Ard Biesheuvel Cc: Philipp Zabel , Linux Crypto Mailing List , kernel@pengutronix.de, "David S. Miller" Subject: Re: [PATCH] crypto: algapi - Remove test larvals to fix error paths Message-ID: References: <20220126145322.646723-1-p.zabel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Wed, Mar 16, 2022 at 08:23:24AM +0100, Ard Biesheuvel wrote: > > According to the bisect log in the other thread, > adad556efcdd42a1d9e060cb is the culprit, which does not seem > surprising, at is would result in the SIMD skcipher being encapsulated > to not be available yet when the SIMD helper tries to take a reference > to it. It's supposed to work because any use of an algorithm prior to the tests starting will automatically trigger the test right away. I confirmed this by booting the kernel in qemu with AES_ARM_BS=y and it successfully registered those algorithms and passed the self-tests. Someone else has already sent me a complete kconfig file which hopefully should reproduce the crash for me. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt