Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <fec066f8f289be21f9d374eda93a4c75a11f2e15.camel@pengutronix.de>
Subject: Re: [PATCH] crypto: algapi - Remove test larvals to fix error paths
From:   Philipp Zabel <p.zabel@pengutronix.de>
To:     Herbert Xu <herbert@gondor.apana.org.au>,
        Ard Biesheuvel <ardb@kernel.org>
Cc:     Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
        kernel@pengutronix.de, "David S. Miller" <davem@davemloft.net>
Date:   Thu, 17 Mar 2022 10:00:56 +0100
In-Reply-To: <YjJgR2FxAaXNHhTa@gondor.apana.org.au>
References: <20220126145322.646723-1-p.zabel@pengutronix.de>
         <c572bf6f0b0a5d7fd3f8f0744a85eb5660a003d4.camel@pengutronix.de>
         <YjE5UCeoziA8f+Q4@gondor.apana.org.au>
         <CAMj1kXF-BdRCN-239cRHgSGM3K9EPSrRFEDJu+e6Gtri2pONaA@mail.gmail.com>
         <YjJgR2FxAaXNHhTa@gondor.apana.org.au>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
User-Agent: Evolution 3.38.3-1 
MIME-Version: 1.0
Precedence: bulk

On Do, 2022-03-17 at 10:10 +1200, Herbert Xu wrote:
> On Wed, Mar 16, 2022 at 08:23:24AM +0100, Ard Biesheuvel wrote:
> > 
> > According to the bisect log in the other thread,
> > adad556efcdd42a1d9e060cb is the culprit, which does not seem
> > surprising, at is would result in the SIMD skcipher being
> > encapsulated
> > to not be available yet when the SIMD helper tries to take a
> > reference
> > to it.
> 
> It's supposed to work because any use of an algorithm prior to
> the tests starting will automatically trigger the test right away.
> I confirmed this by booting the kernel in qemu with AES_ARM_BS=y
> and it successfully registered those algorithms and passed the
> self-tests.
> 
> Someone else has already sent me a complete kconfig file which
> hopefully should reproduce the crash for me.

It seems you already did. I can confirm that [1] fixes the crash for
me, as I had CRYPTO_CBC disabled. After enabling it, aes_init() doesn't
hit the error path anymore, hiding the BUG() again.

[1] https://lore.kernel.org/all/YjJq0RLIHvN7YWaT@gondor.apana.org.au/

regards
Philipp