Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4f320d3b-7ade-211c-e1ff-d4eb37fe540a@nvidia.com>
Date:   Tue, 22 Mar 2022 14:21:55 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH 07/12] nvme: Implement In-Band authentication
Content-Language: en-US
To:     Hannes Reinecke <hare@suse.de>, Sagi Grimberg <sagi@grimberg.me>
Cc:     Christoph Hellwig <hch@lst.de>, Keith Busch <keith.busch@wdc.com>,
        linux-nvme@lists.infradead.org, linux-crypto@vger.kernel.org
References: <20211202152358.60116-1-hare@suse.de>
 <20211202152358.60116-8-hare@suse.de>
 <346e03e9-ece1-73f9-f7f4-c987055c5b9f@nvidia.com>
 <3382242d-7349-e6f9-9b3c-4a5162f630c0@suse.de>
From:   Max Gurtovoy <mgurtovoy@nvidia.com>
In-Reply-To: <3382242d-7349-e6f9-9b3c-4a5162f630c0@suse.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RlRWN1ZCc0tCbDhYUUdkMlR0OGNuZG44cnBEb1JiUUJVUWxiWWt4aDdVZmpn?=
 =?utf-8?B?enJTMVFiSUpLYVBnK0YxVTBqeU1DV1pidGZiZ0xIQy9FZEFNT3QyK1JHdUhQ?=
 =?utf-8?B?dENIa3BuQzkyM0lvRmxFdjF6S082S3NzNWxMcmFxOU5BbUcxSzJVVUo5QkdP?=
 =?utf-8?B?MGY3Y3NtOTJvb2pZMW43eml4NG55NkVrVjFHTGpBWExsOVlNTXRvb3haMlA2?=
 =?utf-8?B?MkxOS2xFOVExaUQ2cXJlb3htTXpBcWlaLzdPM29nT3pGSHpjSnJxYnJLWVhP?=
 =?utf-8?B?TUdWckwwQXlPVCtXOVMwV3VReTRVV2JHNHlieFJvYlQzaGZyd0hXdGhCbDZv?=
 =?utf-8?B?TFNSVG9jU2NCZHV2Y0RBZkMzYzZyQzZCSEJBQVVISlJoSmF3RVNySzA3RFFk?=
 =?utf-8?B?NCtqZHVYcGxPMWtMcUVlMFJrUGFlVktvbUhUbnk3NmJSWDBKdVI3UnBRVGx0?=
 =?utf-8?B?MEpmc2xoeWZQWlpGNTFENGd2VFV1T3dSUytvNDJRTDJ1M0htT2lWMjFtUjY5?=
 =?utf-8?B?YTkxUzVzMjZITFFUeXptVExNRERKYU1zUkN0THNkM1NOOXo2SVdYeVZxQ0xI?=
 =?utf-8?B?bnNaYmpSQjRoSk01RnRBaDhqKzdjQXRVaVhuRVVIYWZEL0l2RWZnYzRvWlds?=
 =?utf-8?B?a29BVTlxaFpJSWVBTGQzZzVvZ2VFQy9GbnI3dDRacFJyRE51WDNaSXVHZzZM?=
 =?utf-8?B?UGNMbzVRbUcvTlFLeHdKb2h3TXNmR3J5ZHpKejFBZ0FuYUNUbWQ5TVFVTzUy?=
 =?utf-8?B?MU1IUUFHOTRvN3dIc2Y3UjczVHlFdGRlZ2QraXNlTEpmTHJNU1hJbGZjdUY4?=
 =?utf-8?B?c3Ayb1NZK256NDUwOU9SenpxYXptbHZJbjNhSWYzTUkwUzd1RzVqVktMYnU5?=
 =?utf-8?B?MmZwb0YvYTRvNjh5bzl0MEd3YXhUd01LbzZDRW9wK0dkS2FGa2U3dlM0ZHJE?=
 =?utf-8?B?WVdtRFl2Ri9NL0R3QmxreWgxOWxUajVUZVRXWFBIU0ZTMFZHMU1EMndZRkhU?=
 =?utf-8?B?TG1tUVM0RzBpNTBqbmFxR1hCMmM0clVkZnY3UDZEM2pSOFliOWQvZG4wYjRx?=
 =?utf-8?B?SDk1OUlkbm9iR3NYT3FGczQraTBUZ21xSmtTU2RhMm1YUVlyeHhoaksveDZS?=
 =?utf-8?B?eWYxUGlWRldxWUZUV2h4ZWdHM09kb0lhZUh5bmhkNE00Mlc3MldubXJSSjJ6?=
 =?utf-8?B?WXN4cVNpTmNRNmF6YzludmZiVnN5d3BjekNZRFI3TDRDaUtzKzVPNy9OSG55?=
 =?utf-8?B?azFiT0ZuN281WEI3bDVGVS8raFlyOVlEdmRtb0Y2MG1YaVN2N2REVmROOWhB?=
 =?utf-8?B?ZUhIWmFJcTA4MGFtN0phMGQwOGhjNXNiTldVMXBoWjRtU3F1S1I4UEFHcmZ5?=
 =?utf-8?B?ampsellnejFub1YrOFp1d2VSVUx4YWg2VHFPcWhEaHVFM2U0cnRUUzErenNN?=
 =?utf-8?B?ZmhJdVNGWk5MVjZTRFhKcHNqRFZTeWRVQjFLTHNORTNkaHJha253OHlJb1hz?=
 =?utf-8?B?cHhRN2h3NHMwQS9QU3pta1lOVEx6UE5tajE0NE5PcE1NMDB1Zis0eFBIUXhM?=
 =?utf-8?B?L01LVHI1a0VkRkpVZWF6dUhPclFtZWFEeVZsTWNldmhGeXRjbmM0NUpnMGZu?=
 =?utf-8?B?UGlzcWZkV1ZSMWNPQTZaWXVEdGlPdnA1ZDVpZTA2ZzBiV3ZzaEx4MHpzN3ps?=
 =?utf-8?B?RitwblFkNWZhQ1JtYjhZTkg5YkRWcmdPOWhmaGlxcGpXZmRFUG5GdVRtQ0ZC?=
 =?utf-8?B?eXAzZDBDVmtmb3VjcHIvYXBnU3RhR0hTN2Z1R2tMY28vVFE5STA0Vi93NDFT?=
 =?utf-8?B?amtuUEhZMEQ0ZzhXOXdlcytMSkphUTVxdWZndnNOSUFWbmpGbE1TRXJ6NWw3?=
 =?utf-8?B?NWVZR0JoK21qVW8vSFl1VG1ocUQ1WUNXcEtoc09XY25Ca1JycmZ1bVVvelhF?=
 =?utf-8?B?NW9uY25CcFNIRHFEOWt4dDhodE5JdFY3SEIyS2Jyc3hQTEpBUXd5N0VnMHN3?=
 =?utf-8?B?RC8wOEwwdHlnPT0=?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 273bbc07-f234-4d70-b846-08da0bfe91e4
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5040.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Mar 2022 12:22:02.6443
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Q6d0lvFcRdWMsLVh85Odbi/RKXASJwth9bxUKcQudmD2hnl6ZNmsVKKs0ZS7eF+SZ22rxkQK7Q+UK+hi3rxmQQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB2928
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org


On 3/22/2022 2:10 PM, Hannes Reinecke wrote:
> On 3/22/22 12:40, Max Gurtovoy wrote:
>> Hi Hannes,
>>
>> On 12/2/2021 5:23 PM, Hannes Reinecke wrote:
>>> Implement NVMe-oF In-Band authentication according to NVMe TPAR 8006.
>>> This patch adds two new fabric options 'dhchap_secret' to specify the
>>> pre-shared key (in ASCII respresentation according to NVMe 2.0 section
>>> 8.13.5.8 'Secret representation') and 'dhchap_ctrl_secret' to specify
>>> the pre-shared controller key for bi-directional authentication of both
>>> the host and the controller.
>>> Re-authentication can be triggered by writing the PSK into the new
>>> controller sysfs attribute 'dhchap_secret' or 'dhchap_ctrl_secret'.
>>
>> Can you please add to commit log an example of the process ?
>>
>>  From target configuration through the 'nvme connect' cmd.
>>
>>
>
> Please check:
>
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fhreinecke%2Fblktests%2Ftree%2Fauth.v3&amp;data=04%7C01%7Cmgurtovoy%40nvidia.com%7C4e6a16198c834c87e2ac08da0bfd01fc%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637835478535167965%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=OgZkPCwDUIllRWfKF0SoC6osWJy3hqAZouME3KDnIGQ%3D&amp;reserved=0 
>
>
> That contains the blktest scripts I'm using to validate the 
> implementation.
>
blktest is great but for features in this magnitude I think we need to 
add a simple usage example in the commit log or in the cover letter.

for someone that is not familiar with blktests, one should start reverse 
engineering 4000 LOC to use it.

Cheers,

Max.

Thanks for implementing this important feature.


> Cheers,
>
> Hannes