Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp3211912pxp; Tue, 22 Mar 2022 14:39:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwC3ROIlejmLA+duyoADffFUssdgdctPFI3nARAm7dW6I5Nk0eHhRpJcLcE6RsaV76oQlDx X-Received: by 2002:a05:6a00:230b:b0:4fa:7ca6:b1d5 with SMTP id h11-20020a056a00230b00b004fa7ca6b1d5mr20629892pfh.11.1647985168116; Tue, 22 Mar 2022 14:39:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647985168; cv=none; d=google.com; s=arc-20160816; b=uvGzStdca0yZgo2kqJXOmwKH5q0fimzQh4wIBa/X0mBpo+2BuOBq00ykowgawW2rZB /SrVXryVJYMs39eTScBJbkZkfr9ykRUt77d6bjau2vGfR014nW4riJUzb7ToSnfmFAo9 xXkERyIHW87/7SgtfsN2Hc2C1e18dQgIm3RVAJaeKwXqUNMG71ufCdCE1XB4sfZtL50q guhJ76mn/75NdQkMlmYTiCn2dcukMQ/AaljcLrxIQOXLvr0Hg3FhhIa4LKl3zP2DSn5T FYnkSMdyAJkkwT/URMxa8oT2qGk64nCc8z7PbW8Xw1j47USvBxKGU8K8id32+/pZF9tw sB9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=BkGHrKioy4lmRPNIAx4eCyin16fO+yc3WB3vYg9ucPQ=; b=XBHXGdQ5WKf0IOXcL1bMP1Z4tEWQwo7qsnfeX9r6G9sIdUFLOw1/2+V+VqG7JAM9ep XPKB8GAi2nc23D//Xp0hKWwyvqxtn8PtvISVIG5iqt3DoTPXpkOJeO0YDOiJYVshGXst /XzlNVB7/EFTzdWYI3M3GeN2dBrJCfOPNT1S8dMhXWd0y0+OE8oWcD8WWOIRkbJZuW51 tuUCXTkVUu/RSfPyNl+QBCxbJVjk45ES6GsWq673Oyy34poLonAZYu9/9PmHHZ8fVhTS GYFwGP4SFkzLg5zYK8q9n+ZWtJKurYupD6T36PNC76YgqJTBfLo8VRomtEkw2mQ6hQjP ursg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tQuDXUlh; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m14-20020a634c4e000000b003816043ee6fsi16893810pgl.100.2022.03.22.14.39.00; Tue, 22 Mar 2022 14:39:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tQuDXUlh; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240335AbiCVS1B (ORCPT + 99 others); Tue, 22 Mar 2022 14:27:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240474AbiCVS0t (ORCPT ); Tue, 22 Mar 2022 14:26:49 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6082291AE6; Tue, 22 Mar 2022 11:24:29 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DBCCE615C1; Tue, 22 Mar 2022 18:24:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A312DC340EC; Tue, 22 Mar 2022 18:24:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1647973468; bh=FvpGfCbFl7jiIv+5qDBixSNKRQDQ0tuqYtKpgJTJImM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tQuDXUlhqs9CKsHkSjY/ScbmM/fz5A8eD7iftU4YRevtwvus6YLjyHciExv9uEdvK ODgx6yqbrUVHYitdapwSw4VSk3x+3dDFFmpv5S3UydMRalWps10DNbqG6qzDgFeSri tCuYrOWRikPlVAOw3zibpylqKvA34k+giMV9sDN+3SZ18VosQbFmMMNYqyS7RzYk7W San13jBR7ieHdupZcUbtNZo0+rG5hNfra34zL1x9muYlzHDpqu0rkEVeg2jxCsbBLR vi2JhVOE/Fgj8jBj4RQeaxhNngtN4bUtwQOvWzlVEwWN09QoJcBGUj208CehiBpojp K3AoZ6dmCtHdw== Date: Tue, 22 Mar 2022 18:24:19 +0000 From: Mark Brown To: Guenter Roeck Cc: "Jason A. Donenfeld" , linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, linux-arch@vger.kernel.org, Dinh Nguyen , Nick Hu , Max Filippov , Palmer Dabbelt , "David S . Miller" , Yoshinori Sato , Michal Simek , Borislav Petkov , Guo Ren , Geert Uytterhoeven , Joshua Kinard , David Laight , Dominik Brodowski , Eric Biggers , Ard Biesheuvel , Arnd Bergmann , Thomas Gleixner , Andy Lutomirski , Kees Cook , Lennart Poettering , Konstantin Ryabitsev , Linus Torvalds , Greg Kroah-Hartman , Theodore Ts'o Subject: Re: [PATCH v1] random: block in /dev/urandom Message-ID: References: <20220217162848.303601-1-Jason@zx2c4.com> <20220322155820.GA1745955@roeck-us.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="9GphWWnfqSfQwrGD" Content-Disposition: inline In-Reply-To: <20220322155820.GA1745955@roeck-us.net> X-Cookie: I exist, therefore I am paid. X-Spam-Status: No, score=-7.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org --9GphWWnfqSfQwrGD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 22, 2022 at 08:58:20AM -0700, Guenter Roeck wrote: > This patch (or a later version of it) made it into mainline and causes a > large number of qemu boot test failures for various architectures (arm, > m68k, microblaze, sparc32, xtensa are the ones I observed). Common > denominator is that boot hangs at "Saving random seed:". A sample bisect > log is attached. Reverting this patch fixes the problem. Just as a datapoint for debugging at least qemu/arm is getting coverage in CI systems (KernelCI is covering a bunch of different emulated machines and LKFT has at least one configuration as well, clang's tests have some wider architecture coverage as well I think) and they don't seem to be seeing any problems - there's some other variable in there. For example current basic boot tests for KernelCI are at: https://linux.kernelci.org/test/job/mainline/branch/master/kernel/v5.17-= 1442-gb47d5a4f6b8d/plan/baseline/ for mainline and -next has: https://linux.kernelci.org/test/job/next/branch/master/kernel/next-20220= 322/plan/baseline/ These are with a buildroot based rootfs that has a "Saving random seed: "= =20 step in the boot process FWIW. --9GphWWnfqSfQwrGD Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmI6FFIACgkQJNaLcl1U h9BikAf9GyEwspA1FgiJqGxDrpcFJatNlthPVfssfjxi3+PM/Sr3aGVYuI1cucrY rOXZc5iGh0WzI6+6SJa4LHN9Az3zbhAbXim3xfsdRA6H43LLTo2Nnm5X7WXiimIs +DoFKihIN+SIeYLbYORzZpmCnZ23wcVviG2W3WdzUCKj7LzOQYcPKzAoBfqvXM0H DdzlPyQMQMo1RwxuMv7gokqg/ZXNKt3bTJ8ptBTYY+uOwYKAifVdzsJc8GF+FfE7 1vZPgBdPNegM/QLA2E5p5OlfmymsdJfN0+M6pjVINH9CyIKvAPpoFkXacv8EV/2i QuDiWltRqivsK2Px9ISnKQzA9wB5tw== =nsEK -----END PGP SIGNATURE----- --9GphWWnfqSfQwrGD--