Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 25 Mar 2022 16:16:19 +1200
From:   Herbert Xu <herbert@gondor.apana.org.au>
To:     QintaoShen <unSimple1993@163.com>
Cc:     davem@davemloft.net, linux-crypto@vger.kernel.org,
        linux-kernel@vger.kernel.org, unSimple1993@163.com
Subject: Re: [PATCH v1] crypto: stm32: Check for NULL return of
 kmalloc_array()
Message-ID: <Yj1CE0IPS+JB9V8I@gondor.apana.org.au>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1648114692-11175-1-git-send-email-unSimple1993@163.com>
Precedence: bulk

QintaoShen <unSimple1993@163.com> wrote:
> As the potential failure of memory allocation, kmalloc_array() may return
> NULL and lead to NULL pointer dereference because of the usage of 'rctx->hw_context'.
> 
> Therefore, it is better to check the return value of kmalloc_array().
> 
> Signed-off-by: QintaoShen <unSimple1993@163.com>
> ---
> drivers/crypto/stm32/stm32-hash.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/crypto/stm32/stm32-hash.c b/drivers/crypto/stm32/stm32-hash.c
> index d33006d..f1a1a13 100644
> --- a/drivers/crypto/stm32/stm32-hash.c
> +++ b/drivers/crypto/stm32/stm32-hash.c
> @@ -970,7 +970,8 @@ static int stm32_hash_export(struct ahash_request *req, void *out)
>        rctx->hw_context = kmalloc_array(3 + HASH_CSR_REGISTER_NUMBER,
>                                         sizeof(u32),
>                                         GFP_KERNEL);
> -
> +       if (!rctx->hw_context)
> +               return -ENOMEM;

This patch introduces a runtime PM imbalance.  Please fix.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt