Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Pankaj Gupta <pankaj.gupta@nxp.com>
To:     Ahmad Fatoum <a.fatoum@pengutronix.de>,
        Horia Geanta <horia.geanta@nxp.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        "David S. Miller" <davem@davemloft.net>
CC:     "linux-security-module@vger.kernel.org" 
        <linux-security-module@vger.kernel.org>,
        Eric Biggers <ebiggers@kernel.org>,
        David Gstir <david@sigma-star.at>,
        Matthias Schiffer <matthias.schiffer@ew.tq-group.com>,
        Sumit Garg <sumit.garg@linaro.org>,
        Jan Luebbe <j.luebbe@pengutronix.de>,
        Richard Weinberger <richard@nod.at>,
        "tharvey@gateworks.com" <tharvey@gateworks.com>,
        Franck Lenormand <franck.lenormand@nxp.com>,
        James Morris <jmorris@namei.org>,
        Mimi Zohar <zohar@linux.ibm.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        David Howells <dhowells@redhat.com>,
        Jarkko Sakkinen <jarkko@kernel.org>,
        "keyrings@vger.kernel.org" <keyrings@vger.kernel.org>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "linux-integrity@vger.kernel.org" <linux-integrity@vger.kernel.org>,
        James Bottomley <jejb@linux.ibm.com>,
        "Serge E. Hallyn" <serge@hallyn.com>
Subject: RE: [EXT] [PATCH v6 3/4] crypto: caam - add in-kernel interface for
 blob generator
Thread-Topic: [EXT] [PATCH v6 3/4] crypto: caam - add in-kernel interface for
 blob generator
Thread-Index: AQHYOVUNOyYgdbVIskOFW8XkCJYEX6zOQs5wgAAZNICABjWmsA==
Date:   Mon, 28 Mar 2022 09:29:12 +0000
Message-ID: <DU2PR04MB86306DE99EA993BF596BA729951D9@DU2PR04MB8630.eurprd04.prod.outlook.com>
References: <20220316164335.1720255-1-a.fatoum@pengutronix.de>
 <20220316164335.1720255-4-a.fatoum@pengutronix.de>
 <DU2PR04MB8630BDFC29AA31074C623A7B95199@DU2PR04MB8630.eurprd04.prod.outlook.com>
 <ae941471-43c0-1aea-2567-89eed98a61a6@pengutronix.de>
In-Reply-To: <ae941471-43c0-1aea-2567-89eed98a61a6@pengutronix.de>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?S9mosKYL1vczp2lcM46ejTjHeVyjlTRzGR5Yydt7OLLz6RyerZilxElHwX0j?=
 =?us-ascii?Q?Tt2RTI5W/rdJy1JopGqN3KS+sjXjurPavbi51KNoW6hO7IlzpnEL8E21plpQ?=
 =?us-ascii?Q?yQ6q+njokcZjPy9r3im8uEc/1NvGUWBuKqrbtDZQUqDpkdn5nLBAiH0lk5Po?=
 =?us-ascii?Q?K+ZiGZq9M/UfB2RX6aZslytwgEunBYS4XBOExaPYjCyqM03DMIpWlM0vNWRH?=
 =?us-ascii?Q?LPlOSz1ruglCvC2xTBK8LX6iRbA9Przow7RoA2qZcCwGo1ehavDThzt7os8K?=
 =?us-ascii?Q?ghy+MMhYHTY8hMt6mcJd/+kyyFFmR6/0Bh70XIbcAkEdZEVRFl8/TV3yRhpP?=
 =?us-ascii?Q?GQnMKmx2pQz+5ry/DtDxCm1Mwe9YTZHTqFIJekZG7KEGxcEKFeiZwDiN4iMM?=
 =?us-ascii?Q?xuOxwDNQOtvdwNtJ9qDIPHjfKOjL5CY/6YqmpsAea1MYM1yPc0KloH0HCgGE?=
 =?us-ascii?Q?QfLDvSfxmVNYmlZqkVtnezRNVgHc9HkZU2Qa2xvTwRORpkqS0d1BJlMS5M1h?=
 =?us-ascii?Q?NPogzfZzxIEcTxtli2dywLsqxXYXgSdprz7BD7pW8BD6U3WuQXJDHKXz6Bms?=
 =?us-ascii?Q?vuqW5vIRE9Xi5wfiGAxfvYVY5HvkkMAnXfhWHeWkFG9XKwaLqfQLgth7hbKS?=
 =?us-ascii?Q?PQ94ANPlz5sCRw3b4jhqCvmLnWtW2jaR6r3JF/RZF2ndtcmVc1EmkjGPRh8l?=
 =?us-ascii?Q?Ggo187RgICINvrkEdRj6qwBvkKKIrb1J4Oz0Ci2XrIaIgYOkWWXoZtoKbBiY?=
 =?us-ascii?Q?7cv2Nk29qQUQhXLD0lE4672FLxccErorl6qFJRk1DGq3n276ladX0kpRZaOu?=
 =?us-ascii?Q?S1SCZbPp5yj2dhO3wIwjcomX1BOz8ZS+8za8Nvop4KU1daKgEGy4+GiOlVFi?=
 =?us-ascii?Q?s8FaH50xa0bVlGTN5PF1i4fPkESXrSfCXEQ8CEMYoSVu7Xjrg9/RpB44VNFK?=
 =?us-ascii?Q?0+hItGnpqQx7WBN2lQ2UXYkJPO0hdprHBITmBLQ88mi4Zra6sUVovTJliacr?=
 =?us-ascii?Q?7BkSNbwE9yvZihDvTIeftZnt33qKu2b7FPpYDs1m5IAg9b+y1iF/WF4lCgAM?=
 =?us-ascii?Q?PuHwzOjM8YzNE36UiNfZRbZP52NcHtMN0yV194v/pZuhYvbD3bJupZ6d3V+/?=
 =?us-ascii?Q?1cCqOfq7HJcH/CoMO3nOzArYk5y37jJdb1vxcsaZhTafr1YXvTXwN8henzrT?=
 =?us-ascii?Q?CROmFz2uncbKxmxkt1EhKvDKpVsc5AEhDh85umr81/K+UUGwOK8DOEmXb68L?=
 =?us-ascii?Q?9TpkIioZojpghbsKI5dM1lNeq9IOVgMktu1d9KHiS4X+emD9mZmqgcHbgBPs?=
 =?us-ascii?Q?ru/4HltiUtWfgklYDrjFrg1mXpljYZ4e5zkqASIe2Tp2AgEdKRAxEnFQGrnt?=
 =?us-ascii?Q?FO0YJ5HoOXmGzjqlNzm4xL1aWjveMKHt0nT1lGitI0pzASbKtsDjQ5AnbyuO?=
 =?us-ascii?Q?NmTScMRIYR7b/hgykF2Qy6G6D0Ka41qfptUZcNYX7o/l8LSPPJKCGuecAl6Q?=
 =?us-ascii?Q?vqaV3assGtJIaNEU5Iz3tcJ/Y9NhxeP3lH+TCSyKIWuK3gTL19a/OJc/0JFF?=
 =?us-ascii?Q?sfO6SUoz1wouBda7bZnVenujLoJCo9+AdnU8Pl6OM1J63H5mRZMmyZS7L2Ts?=
 =?us-ascii?Q?MSCuiGklDJmaofT36RTGwlAgWHnFx4SHe7jQA2iNikfVBeF+8I3c9aXa9bVP?=
 =?us-ascii?Q?KHXVfl9TBDk+rCZB9aV+TNFRMmju6EfuDqmw+fuzi9dGcapx6WJF4ZKYIull?=
 =?us-ascii?Q?P90gBoMT0Q=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8630.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a26d9f2b-826c-49de-e131-08da109d6b6f
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Mar 2022 09:29:12.3032
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: +2DPEmggRBCPClQAQE1RjDLCaJcy2DuDfysYBZm89qjSj2yC2yber2AYEbsRFt+9mp8KE36uJ0WQ94LXdHrEIw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8164
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

Hi Ahmad,

Please find the comments in-line.

Regards
Pankaj

> -----Original Message-----
> From: Ahmad Fatoum <a.fatoum@pengutronix.de>
> Sent: Thursday, March 24, 2022 3:40 PM
> To: Pankaj Gupta <pankaj.gupta@nxp.com>; Horia Geanta
> <horia.geanta@nxp.com>; Herbert Xu <herbert@gondor.apana.org.au>;
> David S. Miller <davem@davemloft.net>
> Cc: linux-security-module@vger.kernel.org; Eric Biggers
> <ebiggers@kernel.org>; David Gstir <david@sigma-star.at>; Matthias
> Schiffer <matthias.schiffer@ew.tq-group.com>; Sumit Garg
> <sumit.garg@linaro.org>; Jan Luebbe <j.luebbe@pengutronix.de>; Richard
> Weinberger <richard@nod.at>; tharvey@gateworks.com; Franck Lenormand
> <franck.lenormand@nxp.com>; James Morris <jmorris@namei.org>; Mimi
> Zohar <zohar@linux.ibm.com>; linux-kernel@vger.kernel.org; David Howells
> <dhowells@redhat.com>; Jarkko Sakkinen <jarkko@kernel.org>;
> keyrings@vger.kernel.org; linux-crypto@vger.kernel.org;
> kernel@pengutronix.de; linux-integrity@vger.kernel.org; James Bottomley
> <jejb@linux.ibm.com>; Serge E. Hallyn <serge@hallyn.com>
> Subject: Re: [EXT] [PATCH v6 3/4] crypto: caam - add in-kernel interface =
for
> blob generator
>=20
> Caution: EXT Email
>=20
> Hello Pankaj,
>=20
> On 24.03.22 10:55, Pankaj Gupta wrote:
> > Hi Ahmad,
> >
> > Please find the comments in-line.
>=20
> Thanks for you review.
>=20
> > Suggest to continue to use two separate descriptor-creation-function fo=
r
> 'encap' and 'decap'.
> > This will help these API(s) to be maintained easily going forward.
>=20
> We can still split them up in future once there is a real need.
> But currently they are exactly the same, except for input/output length, =
so I
> think it's correct to not introduce duplication unless needed.
>=20
> >>   - use append_seq_(in|out)_ptr_intlen for both encap/decap as a
> >> result
>=20
> Case in point. The intlen omission was because the two functions are larg=
ely
> identical and I only fixed up one of them. This is prone to repeat when w=
e go
> back to have identical code with minor differences.
>=20
> > In continuation to the previous comment, there is another suggestion:
> >
> > Either:
> > struct keyblob_info {
> >         void *key;
> >         size_t key_len;
> >
> >         void *blob;
> >         size_t blob_len;
> >
> >         size_t key_mod_len;
> >         const void *key_mod;
> > };
>=20
> I can do that.
>=20

Please do. Thanks.
Patch 4/4, needs to be re-worked to.

> Whats your opinion on the desc size computation? Comment the macro or
> add the static inline helper?
>=20

Comment the macro is fine.

> Cheers,
> Ahmad
>=20
> --
> Pengutronix e.K.                           |                             =
|
> Steuerwalder Str. 21                       |
> https://eur01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fwww.
> pengutronix.de%2F&amp;data=3D04%7C01%7Cpankaj.gupta%40nxp.com%7C4
> d60f0d524a04b7cbd7b08da0d7e7d21%7C686ea1d3bc2b4c6fa92cd99c5c30163
> 5%7C0%7C0%7C637837134158793951%7CUnknown%7CTWFpbGZsb3d8eyJWI
> joiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3
> 000&amp;sdata=3DPetvZm8teusBwQ4BeZ1VLEOvBlCrZ2k2bNG3SJBEXPw%3D&
> amp;reserved=3D0  |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    =
|
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 =
|