Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp5083504pxb; Mon, 28 Mar 2022 07:43:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy9wYHk0zth1/NC9jyFSrM7i09Xj29sBJjp7H0wx0GyuvNPOGnzZV3aFY1Uo3HQCccViLna X-Received: by 2002:a17:90a:730b:b0:1c6:781a:312f with SMTP id m11-20020a17090a730b00b001c6781a312fmr41076499pjk.53.1648478621789; Mon, 28 Mar 2022 07:43:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648478621; cv=none; d=google.com; s=arc-20160816; b=WTOyNISSoTiTtGgLAMpbIiYGnzHuGn/MOifLUP39qQUh6VnKGRwvv+tJFUEMrBSGCw OZ9HlYsF7DViqy1F04nF4OJ6w1tv9Mf8nUw71KUzvbG9RCYUXwGDX4EC+3zT+c3WIvTx /0aI4Kg1zAKX7mF77kPwRF1z/dy0Z0TpHe2NU6UiieGJNwnWlOwcmf5v4aJRzOCA1S+H /4P3t40Qfq9bSoyUpYlFaWoX6yiERkP8iVPzwETatVKR5PYtFB+73+KKUQyxHmI1s5WV zs9ZHrpo4uZ0pxUKqd2d7I8lbJzYw3Op1EHLW501bdoLJ8Y+hHVPoG8YoMBKFYaxN+Hg PXWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:organization :mime-version:message-id:date:subject:cc:to:from:dkim-signature; bh=kgom1PVausZ+5FugS6R4opWYQtRMWWwY23x3FwvJk/Y=; b=jQj+7orvpz/BOPg3fLVYx+JJ4qBoesFiCH701+uoPwXZPmyvDQWrajBPvBZObEvb5b dI4EFknPF8qZdXdY4SRpUTc88npuThv+udWnAbSFoRwb7DauAB07SA0rEcVvgMnw68Ql fz+AmgHi0LLDWCdH3sB1fQ0lJi/E8LxqK3m1X1Jg+k4kmxh7LqjgvmFkOCN38jydNDkb /5QMJ+qtLLqLivLFH8ca5EiONtpM9bWVEODuVEEn0lB0WkGv11voJYvRAr5gL9Ac4e7F CrSDolBE7nu2SgG9tB7PZyeSJnSmbIcrYHghzX8M0li6tB4nu/WDEqjYlvZRvH5g/1GQ Y+Hg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=LvTUqinC; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w17-20020a170902e89100b00153b2d1657esi14003913plg.390.2022.03.28.07.43.18; Mon, 28 Mar 2022 07:43:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=LvTUqinC; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241584AbiC1NJ0 (ORCPT + 99 others); Mon, 28 Mar 2022 09:09:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56064 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242988AbiC1NJT (ORCPT ); Mon, 28 Mar 2022 09:09:19 -0400 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1480F5DE4E for ; Mon, 28 Mar 2022 06:07:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1648472848; x=1680008848; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=Ae6YiOvxxEdwLXeOCtDcN81k8iA6NRIkgUp2uQBOWiA=; b=LvTUqinCVGvc0pwWPyv3zy09GTir5+rQMBspgNnAV0IwamBGBg0H9baK s9jKtDEpKl4dXdloz57ITATJgzKLJbgNOsL0DWamq6BDiHG0g6yWLSPkO ccclOltYHEc09LHT7RdxhDHY3YJ5NoxmJzsZcdmdOabR4mPlWtuUU2Lbd ovN6PPo1gngjo6w5UurFVHADMn1WxKIXqV2Tk3zwIhRbb9ww74hwT/wnS VfN1kbE/yz0l2ftUgXimUz9vlP6XBp2AO/3d11Mlpjm8Oln2n75TlJgtq 6i6Vw8Soe0+Ql//mgGN4VGyZFuJT3r9PwIRjzTR8vY/MJPC7iAy6wLOdl Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10299"; a="259178987" X-IronPort-AV: E=Sophos;i="5.90,217,1643702400"; d="scan'208";a="259178987" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Mar 2022 06:07:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,217,1643702400"; d="scan'208";a="563641072" Received: from silpixa00400314.ir.intel.com (HELO silpixa00400314.ger.corp.intel.com) ([10.237.222.76]) by orsmga008.jf.intel.com with ESMTP; 28 Mar 2022 06:07:22 -0700 From: Giovanni Cabiddu To: herbert@gondor.apana.org.au Cc: linux-crypto@vger.kernel.org, qat-linux@intel.com, Giovanni Cabiddu Subject: [PATCH 0/4] crypto: qat - fix dm-crypt related issues Date: Mon, 28 Mar 2022 14:07:10 +0100 Message-Id: <20220328130714.31606-1-giovanni.cabiddu@intel.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Organization: Intel Research and Development Ireland Ltd - Co. Reg. #308263 - Collinstown Industrial Park, Leixlip, County Kildare - Ireland Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org This set fixes the issues related with the dm-crypt + QAT driver use-case. The first patch fixes a potential dead-lock that might occur when using dm-crypt + QAT in out of memory conditions. The datapaths of the aead and skcipher implementations have been changed to use pre-allocated buffers that are part of the request contexts. The also removes the CRYPTO_ALG_ALLOCATES_MEMORY flag from the aead and skcipher implementations. The second patch refactors the submission logic in preparation for the introduction of a backlog queue to handle crypto requests with the CRYPTO_TFM_REQ_MAY_BACKLOG flag set. The third patch addresses a stall in the dm-crypt + QAT usecase by adding support for the CRYPTO_TFM_REQ_MAY_BACKLOG flag. If the HW queue is full, the driver enqueues the request in a list and resubmit it at a later time, avoiding losing it. The last, re-enables the crypto instances in the QAT driver which were disabled due to the issues above. Giovanni Cabiddu (4): crypto: qat - use pre-allocated buffers in datapath crypto: qat - refactor submission logic crypto: qat - add backlog mechanism crypto: qat - re-enable registration of algorithms drivers/crypto/qat/qat_4xxx/adf_drv.c | 7 - drivers/crypto/qat/qat_common/Makefile | 1 + drivers/crypto/qat/qat_common/adf_transport.c | 11 ++ drivers/crypto/qat/qat_common/adf_transport.h | 1 + .../qat/qat_common/adf_transport_internal.h | 1 + drivers/crypto/qat/qat_common/qat_algs.c | 148 +++++++++--------- drivers/crypto/qat/qat_common/qat_algs_send.c | 91 +++++++++++ drivers/crypto/qat/qat_common/qat_algs_send.h | 10 ++ drivers/crypto/qat/qat_common/qat_asym_algs.c | 54 ++++--- drivers/crypto/qat/qat_common/qat_crypto.c | 37 ++++- drivers/crypto/qat/qat_common/qat_crypto.h | 40 +++++ 11 files changed, 299 insertions(+), 102 deletions(-) create mode 100644 drivers/crypto/qat/qat_common/qat_algs_send.c create mode 100644 drivers/crypto/qat/qat_common/qat_algs_send.h -- 2.35.1