Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp1938526pxb; Sat, 2 Apr 2022 08:56:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyAlt1sjm7rP0uOrr90I/qGuWy7RJ1Pdz72vxSvIONkerOURLra7Rml9XPDu6ot0ynHmBvv X-Received: by 2002:a17:90b:4a48:b0:1c7:bb62:446c with SMTP id lb8-20020a17090b4a4800b001c7bb62446cmr17627027pjb.146.1648914981492; Sat, 02 Apr 2022 08:56:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648914981; cv=none; d=google.com; s=arc-20160816; b=PqBZOhhKtLZGxL/no+Rx3ySmpqGi/QBl58ZHTwU8q+e1xqsYjKC2lvbTBWd+ibrMm0 hGbonGcHuM5vTpqq6l6rCd0YAw240j+ri3f7BnDm+TP/Ycu/uF9yhq1eeVQkI125akD6 baZtjG1UdRESljj3sP2ejSUJOhfwwKo3PfqaPl4v7hSs0WF6UuByDKfczkmFCujB1kPo +f3SY3zwI8W74lBaFnKM6Uzgig27XMufcavNivx6eZOta0SM3raRpSGGjL4GULyHY1aG uP63xBj4jXx0eBZbP4OFslP8/6WfwVY4ejwzFhkIbWp4Q2T9M11fpsOy/EpvlB1Jjw/X Wieg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=6k9bKJA41frCR0pmOk9SA+9AKNxBSbRS1tpgQTa/e4I=; b=GqA7TWSJSYlp2vGT943MZw8HMb5LF2wOeNGqwRbksG8GYwoT6E7JvgMehFxzpOt5Lv wW8Fvl8/HacqklcXrVitqG5njQQZR6WgCXesxfeIpHO5cPMYSkAt3tNzmq7rtg4ubI/i kvEJR47WDs6R+5jy6J86H4xyebx1YQienIRFYKBhprZycb3JIc0meKY0wUFJGdXcQ3ky NheHFa7V5dwaCSF6Q9n5FWyv3xSpXwwbUsAtH7jUoOjqELVE2t1ebfxujv0AG+9hCIJC TexrUInXnhVQYqz25H/coc94qivppoxaqhMb7b+eR3BaTNd22XeRlvPSuj7BhS1w9ATe jz7A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20210112.gappssmtp.com header.s=20210112 header.b=MX9wcuVu; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y128-20020a633286000000b003816043ee8esi5609049pgy.131.2022.04.02.08.55.55; Sat, 02 Apr 2022 08:56:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20210112.gappssmtp.com header.s=20210112 header.b=MX9wcuVu; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351898AbiDAUUH (ORCPT + 99 others); Fri, 1 Apr 2022 16:20:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351901AbiDAUUF (ORCPT ); Fri, 1 Apr 2022 16:20:05 -0400 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D533F2706F7 for ; Fri, 1 Apr 2022 13:18:12 -0700 (PDT) Received: by mail-wm1-x32b.google.com with SMTP id bi13-20020a05600c3d8d00b0038c2c33d8f3so4229583wmb.4 for ; Fri, 01 Apr 2022 13:18:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6k9bKJA41frCR0pmOk9SA+9AKNxBSbRS1tpgQTa/e4I=; b=MX9wcuVuqO02rmKbmTocVYNsYM3xb69qciQ45XhTTpNt6pGYkOf8zNrTlg+3ajHa26 gx5h4tNyNiQmQtQT/4b4WRcti77DviPc1pElY+TlnEgIuiQEQqCpbi6QgzfAmyuASasy osO40L106DDYqfRXO42ZzyxiEXHi70159kTp/HputOkY9ofQboH2qWVAK3SoeIiIjLSn qu1Ws+xLQ1SK1oR6tGm/2xkYZ2Q1YkGUYNuihQSOhAxWdrGAnazJqbXmBn+nsW74+hZO 4oc4Dgy8WuU1yb/aPQwsANCR2umfKlMgMkpqSJEJZ6yes+0mzHKLX/m4/iu3Afw8n8LP EGZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6k9bKJA41frCR0pmOk9SA+9AKNxBSbRS1tpgQTa/e4I=; b=yB8brKroJYqv8Z8z9bM09NSO7bEk9f22ypAqCKmAzxkGsi7pFqdsoK9OQLN7rAFv0E DH+cOA997s8EAv4/vfINDSoYVvktS6eatMEw8qXyXJ4XiVeIII+WKuC5uf+e6xMfHj8L 2Olmc2NYXq9dbKTq4hc9WmsfvabVLatQhA4MoE5B84KQa5WL98i20Pu6qelPcfG+4eoQ s6rEvT5US6rsfbIfUX2DqgIKSkPL1DJXiVAl2M1hpNP4gpiuoFiPCaUlBeDHQ4l/4Ler nV79YRMIKsKZCAhmUQ6HDSt7oZP75BmG1y+WMyhvBaC3MkbzHtHK3AhqmHBC+DokVvXp wEaw== X-Gm-Message-State: AOAM531jJov+ZhkeS9wdJRkqHB/SQ5UiY+lAXrzaUsKl1Jqc69Ka2xYp PwcGLLwSe3acYrRQz/9D3w/1ng== X-Received: by 2002:a05:600c:1d26:b0:38e:2c97:6f19 with SMTP id l38-20020a05600c1d2600b0038e2c976f19mr10107691wms.89.1648844291447; Fri, 01 Apr 2022 13:18:11 -0700 (PDT) Received: from localhost.localdomain (laubervilliers-658-1-213-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.googlemail.com with ESMTPSA id j16-20020a05600c191000b0038ca3500494sm17823838wmq.27.2022.04.01.13.18.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Apr 2022 13:18:11 -0700 (PDT) From: Corentin Labbe To: heiko@sntech.de, herbert@gondor.apana.org.au, krzk+dt@kernel.org, robh+dt@kernel.org Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Corentin Labbe Subject: [PATCH v4 01/33] crypto: rockchip: use dev_err for error message about interrupt Date: Fri, 1 Apr 2022 20:17:32 +0000 Message-Id: <20220401201804.2867154-2-clabbe@baylibre.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220401201804.2867154-1-clabbe@baylibre.com> References: <20220401201804.2867154-1-clabbe@baylibre.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Interrupt is mandatory so the message should be printed as error. Signed-off-by: Corentin Labbe --- drivers/crypto/rockchip/rk3288_crypto.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/crypto/rockchip/rk3288_crypto.c b/drivers/crypto/rockchip/rk3288_crypto.c index 35d73061d156..45cc5f766788 100644 --- a/drivers/crypto/rockchip/rk3288_crypto.c +++ b/drivers/crypto/rockchip/rk3288_crypto.c @@ -371,8 +371,7 @@ static int rk_crypto_probe(struct platform_device *pdev) crypto_info->irq = platform_get_irq(pdev, 0); if (crypto_info->irq < 0) { - dev_warn(crypto_info->dev, - "control Interrupt is not available.\n"); + dev_err(&pdev->dev, "control Interrupt is not available.\n"); err = crypto_info->irq; goto err_crypto; } -- 2.35.1