Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp485046pxb; Thu, 7 Apr 2022 10:28:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzN0nICWejwjY8YD7AOg5b5/fGXLnihMKkcctwKfmwz7K6wVezjsuW6WV0+cmjkhXc2w/A2 X-Received: by 2002:a05:6402:2999:b0:418:eb22:64f9 with SMTP id eq25-20020a056402299900b00418eb2264f9mr15074241edb.391.1649352526830; Thu, 07 Apr 2022 10:28:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649352526; cv=none; d=google.com; s=arc-20160816; b=hlMmrTb2glmCy/3yFojyaBa6Lr36AZdMUCz4xnQBmhA/ZEEekRyR3kFdd79+4DQWHb fBBcsx8D9fy4mNqS3deDOTZTFxqQHUsm+gXlerdNGNnWzhuA4AQYBmKto5asR4+g4cUJ 8iJxBQ1TdqOIHqCwMJeIXXT4lMWWloXFcDdtJEB2XZeIUohUGVfCEciQzsJtBHtWM/Hi DyHyIJBUa7rbI92If3/o0QdL75T3q9XpN1MlfSGaJE+V7ZUpZp1Fi/vgRV6UhPQiXC1J qq4ot5/J2NrQmxK3Q0o1lFYgf020XfWvOuFYkHYxWMaZzHnrbs8dQzUOMHqCUm6B6UiP tefw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:organization :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=z0DipjiJsdu0stqOga1NF5FZcd0whrcF79pCsrn0GEQ=; b=o7wR7H4/VM7YkuxoEgFOIChtT7HQK1Y0D0eMAcpnI+Ys+n10Qh0Cl8ji1OuIT3h2qr lwPqi0fKLL1rFoJciYHWhDz+fO9GQmfQKTlO0+uYPDQp2x8ojXvshW/dhEe1DkxcWsFv sXljBdQp3TYzfQRP+0MyvulkrF9Q4bDvszc8r7CSwJwbr3gKzIbETMnn9UbBOJ2vq1gC LZ6yodoIMrsY6lgLBLjGihaEs7maJ6zVnax0CKoDzovhhLRi0Li6NoOtgGrf9x5GUTiG IQIM1pQZjdpgpIoDzooWqYpSRwqLjna6NmuvUzvUq5rLpS579TSSY0aReFzbCBVuUGXl 7FPg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=WS3kyUV7; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f14-20020a50a6ce000000b00418c2b5bf41si13280624edc.547.2022.04.07.10.28.18; Thu, 07 Apr 2022 10:28:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=WS3kyUV7; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345833AbiDGQxZ (ORCPT + 99 others); Thu, 7 Apr 2022 12:53:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48882 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345858AbiDGQxW (ORCPT ); Thu, 7 Apr 2022 12:53:22 -0400 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 105F211A37 for ; Thu, 7 Apr 2022 09:51:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1649350276; x=1680886276; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Fmltnfxcr440AqeR4iM7RcgLXqxDxaud8Rf3z7URLf8=; b=WS3kyUV7aN/EB0+8XMmgHn42dTxsqyqn/dDff9lstKUUbVo1QbLYOmQL Os9L1M6gF1/u4myr7o/YcNXTfhRf0gfiIQDo6lsD2igaPoXSTIiCvsrJO T3U2XDMtHluFPqK6uqnXVdvXui+jp2Y+DCZSY57wMFSHPkhpfODNlKwo9 Mh5SwD9gh/R+KRr8aOX/WsmPPHlRmDZCj5yM36DErBFtlMiwSMdbLDZ2v GtkWi4Fwe1W/wwBHxC6qkonaQO2nk59xZLJ6cA89BuTAMytrDDQQHvL/G FGGBZIIaBaCLRJKDvwlZ+NmKU9UraDoAbhVXpMozvc8z/8fvsXLM2VZGO Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10310"; a="241312058" X-IronPort-AV: E=Sophos;i="5.90,242,1643702400"; d="scan'208";a="241312058" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Apr 2022 09:51:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,242,1643702400"; d="scan'208";a="652898359" Received: from silpixa00393544.ir.intel.com ([10.237.213.118]) by fmsmga002.fm.intel.com with ESMTP; 07 Apr 2022 09:51:14 -0700 From: Marco Chiappero To: herbert@gondor.apana.org.au Cc: linux-crypto@vger.kernel.org, qat-linux@intel.com, giovanni.cabiddu@intel.com, Wojciech Ziemba , Marco Chiappero Subject: [PATCH v2 08/16] crypto: qat - add check for invalid PFVF protocol version 0 Date: Thu, 7 Apr 2022 17:54:47 +0100 Message-Id: <20220407165455.256777-9-marco.chiappero@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220407165455.256777-1-marco.chiappero@intel.com> References: <20220407165455.256777-1-marco.chiappero@intel.com> MIME-Version: 1.0 Organization: Intel Research and Development Ireland Ltd - Co. Reg. #308263 - Collinstown Industrial Park, Leixlip, County Kildare - Ireland Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org From: Wojciech Ziemba PFVF protocol version 0 is not a valid version, but PF drivers currently would report any such version from VFs as compatible. This patch adds an extra check for the invalid PFVF protocol version 0. Signed-off-by: Wojciech Ziemba Signed-off-by: Marco Chiappero Reviewed-by: Marco Chiappero --- drivers/crypto/qat/qat_common/adf_pfvf_pf_proto.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/qat/qat_common/adf_pfvf_pf_proto.c b/drivers/crypto/qat/qat_common/adf_pfvf_pf_proto.c index 588352de1ef0..c059b98836aa 100644 --- a/drivers/crypto/qat/qat_common/adf_pfvf_pf_proto.c +++ b/drivers/crypto/qat/qat_common/adf_pfvf_pf_proto.c @@ -242,7 +242,9 @@ static int adf_handle_vf2pf_msg(struct adf_accel_dev *accel_dev, u8 vf_nr, "VersionRequest received from VF%d (vers %d) to PF (vers %d)\n", vf_nr, vf_compat_ver, ADF_PFVF_COMPAT_THIS_VERSION); - if (vf_compat_ver <= ADF_PFVF_COMPAT_THIS_VERSION) + if (vf_compat_ver == 0) + compat = ADF_PF2VF_VF_INCOMPATIBLE; + else if (vf_compat_ver <= ADF_PFVF_COMPAT_THIS_VERSION) compat = ADF_PF2VF_VF_COMPATIBLE; else compat = ADF_PF2VF_VF_COMPAT_UNKNOWN; -- 2.34.1