Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Yihao Han <hanyihao@vivo.com>
To:     Herbert Xu <herbert@gondor.apana.org.au>,
        "David S. Miller" <davem@davemloft.net>,
        Julia Lawall <Julia.Lawall@inria.fr>,
        Linus Walleij <linus.walleij@linaro.org>,
        Yihao Han <hanyihao@vivo.com>,
        Zhen Lei <thunder.leizhen@huawei.com>,
        YueHaibing <yuehaibing@huawei.com>, linux-crypto@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     kernel@vivo.com
Subject: [PATCH] crypto: ux500/hash - simplify if-if to if-else
Date:   Fri,  8 Apr 2022 07:23:49 -0700
Message-Id: <20220408142351.16961-1-hanyihao@vivo.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?GaHIpYaFZg1yUQkmxM9crnAwWu7MEQZruEGX15LPiX0w+AJKoZfUM/Jk3C3X?=
 =?us-ascii?Q?ZiuEg9uqQHRntOT+yhNywkEClVa3GLA1OUyoa459DaGJ85UBUy12AFesqUT/?=
 =?us-ascii?Q?ncjBGHmGHotfTrbkTG60kKCL8xaqY7RCf2z1SAO+AuQL06EGBoZ5F5dwpoKa?=
 =?us-ascii?Q?GQb9T0gKAwcYctNDOq0jOVt09NfCROjzYRSqRVCvm6V1PN/6Zj+Zi9JV5B14?=
 =?us-ascii?Q?iVvV7kakF+qM6GQZboBqBPd4JB8onrz8dZfJkfEsF5bD5jXrnqkFBHUis3Hp?=
 =?us-ascii?Q?oF70B9xo1IFLwKOhKP/cp7getR5tQwjIy06ptP7TdlJ3ewZCFX3uqBzobv8+?=
 =?us-ascii?Q?+L0r7nQFrukADFtn3f/R3RCs53BtEUqGYgrh6UJy2DzC0JXFbXEK9ue9IXnX?=
 =?us-ascii?Q?YfePz4PEVauRk9ge9naFm1r/6Es6gi1LnJhDpL5pOJ33JBWuButWWbyvffdi?=
 =?us-ascii?Q?Mo/DhQ64PBSaCm7MTbDP6kP8PTb02LTU/kCaDTAXFS7DX3h/dn2OFqU044Tk?=
 =?us-ascii?Q?Z+JAhewEee2GIJVWS1b56s9K8U035InWO8NjDClMAPiT9WWJLsZVrmrBkWPY?=
 =?us-ascii?Q?InK2IrZ7mRRK70AIA5l4c8blp0aJaTWcoDRp6aLcvZ5h7vPfINxvIR0KMWfJ?=
 =?us-ascii?Q?vkN8Nuhu4d2i04HaqT9gwHFeEtdV3Jxnw6tbTEweLXbwMlLiwzE6szOn7Seu?=
 =?us-ascii?Q?TYViRMShdSUBNZiNw4FwpzWu505JDCmb5zXtULsdJ1TLx8i/ow+uzvj7QB+q?=
 =?us-ascii?Q?PkDRenHenMxXKMZNPgr9SXBbI41oCDoI/YQiWMrNMMYQaVn++KFmFbV9kx31?=
 =?us-ascii?Q?8vdgrUsS3iBngGiWiVaUu5QWaeIt0X3erjWei3lIDV6GbM8Nog0gmqi9sWZ/?=
 =?us-ascii?Q?HjDEV1B65YfZSG4il4yly+orc9YytCiNv5ZM9kCpZwjxto+NxEtKoXj23c9V?=
 =?us-ascii?Q?Mqwu5Y/bhZZdDxcgSC5SZJpK3f2pKJzvrlifQxpM5Ihwx1C7aDIkRU3SaceL?=
 =?us-ascii?Q?KmxS4jEog3+6PJQVtGk8cB6W+iSC6Wmmb8pbp1jnaUVb3fS6GyLyNIodlBE8?=
 =?us-ascii?Q?/mx91xJ1rB8k1OpeuI9cm/tNncWqLclCQdtxy2djcnBuZ0B06WwHxbaNCtz8?=
 =?us-ascii?Q?fYAnG19UbRAxmra8btJLgH7sWSIpFAxrld1PU9i09OlUbEIUKDQvo9BGD8WT?=
 =?us-ascii?Q?RYmkgBHN6y8wdo3SgQQAi79bfXGDnpmBuanGTRPWJ3snGQ5KtGfRccsBpNrz?=
 =?us-ascii?Q?QkJ65h4ouuzG+oA+OdDfKXZyBLcT/k6W50MkWIK1YYt+swGQXp53EBnnCglY?=
 =?us-ascii?Q?j9oWfAlMz6/omQQc8qkSrFOSH8DncCpZxvZ2MFl1xBPe49sR7A+X7+HTHyYy?=
 =?us-ascii?Q?CFWX7Eq+GH27jJGnMZFNas00go2QZzfr/O+1DH/CCnMIaDOItlIVN1HrcRzY?=
 =?us-ascii?Q?qqThit7dR9mYlVfLv/toYDF5Js7TyR0LAKMyG9orDxxNP5Iul24gYR4IWcR7?=
 =?us-ascii?Q?zbNirqVy9VpbyWVMhKq1xa2T2AxmfvOb0aNXOOPavq7hBrmINaRMiPtn1JO2?=
 =?us-ascii?Q?td+AGp601dvn7GTXTlGkXe4+iZ5z+QbmdDc7qWB5BbJoBiFAgnAKIqwaCaxk?=
 =?us-ascii?Q?Ckrsii3M+P7eqiDEEM1MnOmS9K96IImWjH4kLi48Zth2HiX/iO6aZD3sKhJL?=
 =?us-ascii?Q?TPCth+J8YLTGBn/daAEKRBI8HapGD5oednEblLVmyY4CMgni87ZPHLF4XcQA?=
 =?us-ascii?Q?kwiUfoyVpA=3D=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1176546f-b81f-4d74-fa7e-08da196b6ea0
X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB4173.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2022 14:24:03.5990
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Go7NoKkRIE+/zopqkuORF9VbCvebe1yrdTyuggSZIPSaovr0A7QHwgAr/JSrBRWSIPGHWN4nFxzOIt1R/7hB4A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR06MB4137
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

Replace `if (!req_ctx->updated)` with `else` for simplification
and add curly brackets according to the kernel coding style:

"Do not unnecessarily use braces where a single statement will do."

...

"This does not apply if only one branch of a conditional statement is
a single statement; in the latter case use braces in both branches"

Please refer to:
https://www.kernel.org/doc/html/v5.17-rc8/process/coding-style.html

Signed-off-by: Yihao Han <hanyihao@vivo.com>
---
 drivers/crypto/ux500/hash/hash_core.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/crypto/ux500/hash/hash_core.c b/drivers/crypto/ux500/hash/hash_core.c
index 5157c118d642..265ef3e96fdd 100644
--- a/drivers/crypto/ux500/hash/hash_core.c
+++ b/drivers/crypto/ux500/hash/hash_core.c
@@ -877,9 +877,7 @@ static int hash_dma_final(struct ahash_request *req)
 				__func__);
 			goto out;
 		}
-	}
-
-	if (!req_ctx->updated) {
+	} else {
 		ret = hash_setconfiguration(device_data, &ctx->config);
 		if (ret) {
 			dev_err(device_data->dev,
-- 
2.17.1