Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp516880pxb; Wed, 13 Apr 2022 07:03:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzVIhbvdTBkJi9rMKg8Lj22/NO+cvhuaJz8898jDi5Hpo6GBosVA+5vSKxeKRLyc3LRC+34 X-Received: by 2002:a05:6808:118f:b0:2d9:a01a:48be with SMTP id j15-20020a056808118f00b002d9a01a48bemr4000999oil.265.1649858583813; Wed, 13 Apr 2022 07:03:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649858583; cv=none; d=google.com; s=arc-20160816; b=nfkpUBVga/U9JZzicC7iuSxdFZAeC+cRgmlqVqbMBHmXBCzmgtvYQo3PFd30JW8dJ3 TOU91VkCFBUrh4u5yXfH2oBHEKNizYPwCGNuJMpXr39IN7qXQZZ/3ZCb/B4rWmF3efSy XNmKa7AIvvcYjsUz1pkT63wHLlVL0XHKfycCgBXVy6Jg9JONAgQSeyiVDaFYk9FuE2Tq rYruDH27/Zudy+wjLEGVgHBI9XYxxlYxhStd2UtyEHj9IwIRDLtoaPNq8qT7QGy03Wyh 5cCsPcH7GGRO50ejFgl+VI8VVGGn3OC1iTeV889Y5QV0fdD/SzcIeFFRw94amr3EwhkN jKNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=q8Ex0PxSMkX6hLvtleAT2Su1yp40GVqczv/isAdXg5A=; b=KhM5YTfTyLghPLGXrGKwB6uAgSlO6FN7msTOmgUHnA0YqjgOMb8Kl2/6Ald3rrAEU3 WzwO/4l2fu6ZzvZh+DQqbxcLzcpAuNFvRbhhjDpDjPP50v07gLyj38rc0BU2Pk02q1L0 spbU/JkPPFwkcIW0iXMsBNWY5B80ZCX2R/HsYLaH/B1+DCikJF2glsZPzjiFTD2V/KMv Y6Dhi2EiqpuhvwgRlTFG4PXzRqOCpnCExJK4togZev3u5ytzlsCQsMBYP2SbVk5jZ6Lu i5yJbviLsRZR+3SzSxWasI/32992Ig2rL2ybtBsNdkbuNxaisPN6ckHexDfcxJlN6F4/ uFsA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@zx2c4.com header.s=20210105 header.b=bfKghglO; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h14-20020a056870170e00b000e1fde091f0si7819952oae.145.2022.04.13.07.02.11; Wed, 13 Apr 2022 07:03:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@zx2c4.com header.s=20210105 header.b=bfKghglO; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232730AbiDMLve (ORCPT + 99 others); Wed, 13 Apr 2022 07:51:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46736 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231590AbiDMLvd (ORCPT ); Wed, 13 Apr 2022 07:51:33 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 70A765AEE3; Wed, 13 Apr 2022 04:49:12 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E62B661DED; Wed, 13 Apr 2022 11:49:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 68962C385A3; Wed, 13 Apr 2022 11:49:10 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="bfKghglO" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1649850548; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=q8Ex0PxSMkX6hLvtleAT2Su1yp40GVqczv/isAdXg5A=; b=bfKghglOXKd8bI5FupKt8r0GvzCdggBiAJl20u1AmZ0Jt8yh1RsaEkpS49+Zt06rAVWxf3 NO2bU7iJMYLIgAmKhUZ1Xhama/JBzEZ/0Oy3M8eXJyB2zjVjGq9BqX7F863Ew6VVm8wuVV FKvh6oX4HU6XEoKjS4laHtOOgeR7JEU= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 69785bfc (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Wed, 13 Apr 2022 11:49:08 +0000 (UTC) Date: Wed, 13 Apr 2022 13:48:53 +0200 From: "Jason A. Donenfeld" To: Will Deacon Cc: Tianjia Zhang , Herbert Xu , "David S. Miller" , Catalin Marinas , linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] crypto: arm64/sm4 - Fix wrong dependency of NEON/CE implementation Message-ID: References: <20220411031313.35449-1-tianjia.zhang@linux.alibaba.com> <20220413102209.GB1229@willie-the-truck> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220413102209.GB1229@willie-the-truck> X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Hi Will, On Wed, Apr 13, 2022 at 11:22:09AM +0100, Will Deacon wrote: > On Mon, Apr 11, 2022 at 11:13:13AM +0800, Tianjia Zhang wrote: > > Commit d2825fa9365d ("crypto: sm3,sm4 - move into crypto directory") > > moved the sm4 library implementation from the lib/crypto directory to > > the crypto directory and configured the name as CRYPTO_SM4. The arm64 > > SM4 NEON/CE implementation depends on this and needs to be modified > > uniformly. > > d2825fa9365d doesn't appear in my tree -- is this something in linux-next? This is in Herbert's tree for next: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git/commit/?id=d2825fa9365d Jason