Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp1148834pxb; Wed, 13 Apr 2022 22:34:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw5ZaO9Hr/3XPgjXPPqW1MAjsL+RAoTY0HIsHqrgo8Bo3rBQ1Xj5brNNz1jr1HAn4u4LzPc X-Received: by 2002:a17:907:2a53:b0:6ce:e4fe:3f92 with SMTP id fe19-20020a1709072a5300b006cee4fe3f92mr916382ejc.389.1649914454319; Wed, 13 Apr 2022 22:34:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649914454; cv=none; d=google.com; s=arc-20160816; b=WKm0gDd249ltXmOoXBxWeamvWiPk59VaYFbYeIYSG2Etp+IM0mp6po9H3uvmcAYWOx i8RQ1QxqQBNgZjZo6nNOS48CN/WcaQz5n7UOcGjXzxGPeIFAr0wPVX0Q8ssqz6nZMjar 4I44QrFZkSBXkZXsYrZ16KC6lQmB3KbINYdq+OX/cl7S3w8TaOt72Cy8W8g9xygITwzy D9sFNgttA5PS5eNobhrAk0Y1naHghh39xa9eNEeAI1zGQ0MbFgkKvzt6wFjXClrEnazN KK0XAjHmfHI6O0wqkOdvjv85RIoDOrgMDzrCHii0j2pusA/w8VLJeMdDb3wh56Yee0Yw h78Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=6k9bKJA41frCR0pmOk9SA+9AKNxBSbRS1tpgQTa/e4I=; b=felUIRtuKzoGz9hjLc9zHI+o4Zd8mIrc6/p+rDmkELSdL46gsB72XJCHaUSx/hUTAH QfoFf8I0wVkmAHySMTOzLLCP0fVmpKzBWca2tTevsAFow07y6iedgh2kXZBYVaFmSl6U X9sL5G6hj9m5myEg8npMBiwBauWLXxEWdGQei6R0yxn3tgkHsaoKp1mgirYCouHSqBcn wj02/QhOz6p00E5SeGWNsKH2Lqv8AubTjZG/ObgQ+w6CHtun32Rt7mHlLzN/mcahqMuJ 18yYgIjKttNCpDckA2Q7gYJATVTcgaVGWQR1v+uA4E1H0cJ2qnea7pJ6NCTb13zFi/Np ZZOg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20210112.gappssmtp.com header.s=20210112 header.b=VYNvVfTk; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f17-20020a170906495100b006e8a4dc2855si1398248ejt.642.2022.04.13.22.33.49; Wed, 13 Apr 2022 22:34:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20210112.gappssmtp.com header.s=20210112 header.b=VYNvVfTk; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236660AbiDMTJt (ORCPT + 99 others); Wed, 13 Apr 2022 15:09:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236669AbiDMTJr (ORCPT ); Wed, 13 Apr 2022 15:09:47 -0400 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1EF4D6E4FC for ; Wed, 13 Apr 2022 12:07:24 -0700 (PDT) Received: by mail-wr1-x42c.google.com with SMTP id c10so4011406wrb.1 for ; Wed, 13 Apr 2022 12:07:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6k9bKJA41frCR0pmOk9SA+9AKNxBSbRS1tpgQTa/e4I=; b=VYNvVfTkDsS2GrZecgJ4GpodMXD4vwGRpH5f6fSEdCuOongHsWNf84yDBtLMfZpCh/ bP/TUsh0Q4kp2FgAq1vxWG8dYmA5buAK9Bg3fehnNA3oI0F/SBENezK39wwQD04oKScC j2wf+dGY8pzeVQe/CungYvO95ijHs+X1EwbGHZLyXNi6ja4lwh2vCN3REwR60vJey/Ql llTjFB5wnjf4SQ3m8/Mm5oPJm/CsXvGqWgVOIoeu4BUZmuUYKUu+z/kiSyxz2at8nCsx eKm/1okCDZUsEjkQPL1p7RKhjElkzqlXXMKPQULRiNSzh9V+pKAuGw2ZScnfcKA8HQvS Hd4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6k9bKJA41frCR0pmOk9SA+9AKNxBSbRS1tpgQTa/e4I=; b=X9r7L8fr1gHP2Ec7rr2ZGt6FVBRIJlXApR6H3NQIonvxP86UEa0M0BvEKL9mNWkTbM MTfP6jMrpSLiMnVkRZic012XQBtRxOMZuxzzfU52mbjFwyVNKk2ek/ccPCFgXZbj057W 3T+BeWXdveRTQFLQXlQy9CLEWRYVQznXs2m1C4EdcSfnn2Ehlkrd48afHU8S2jSGTn2d GUT7eezZnpD1+tOyxxk0iFhtesSXci6aWnRh6K8m/Fy8cx7OWWDiX0kMz+8MpyIX+vR7 MZLeTS65KvX6ZJhjmlFggLdmwCs7x6YvPZl42Wgv0RHSdQr9UMVqR1uKBbrdLJyP3EOj smYw== X-Gm-Message-State: AOAM533NrKBi+xCw2BBea9EBZPoiNyQonVwcv1fLYa+ONWOfuwBFy7NN tEZHEATHNtAPfxb+bplB3e1Beg== X-Received: by 2002:a05:6000:70a:b0:207:a120:bfbd with SMTP id bs10-20020a056000070a00b00207a120bfbdmr258416wrb.142.1649876842619; Wed, 13 Apr 2022 12:07:22 -0700 (PDT) Received: from localhost.localdomain (laubervilliers-658-1-213-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.googlemail.com with ESMTPSA id o29-20020a05600c511d00b0038e3532b23csm3551852wms.15.2022.04.13.12.07.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Apr 2022 12:07:22 -0700 (PDT) From: Corentin Labbe To: heiko@sntech.de, herbert@gondor.apana.org.au, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Corentin Labbe Subject: [PATCH v5 01/33] crypto: rockchip: use dev_err for error message about interrupt Date: Wed, 13 Apr 2022 19:06:41 +0000 Message-Id: <20220413190713.1427956-2-clabbe@baylibre.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220413190713.1427956-1-clabbe@baylibre.com> References: <20220413190713.1427956-1-clabbe@baylibre.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Interrupt is mandatory so the message should be printed as error. Signed-off-by: Corentin Labbe --- drivers/crypto/rockchip/rk3288_crypto.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/crypto/rockchip/rk3288_crypto.c b/drivers/crypto/rockchip/rk3288_crypto.c index 35d73061d156..45cc5f766788 100644 --- a/drivers/crypto/rockchip/rk3288_crypto.c +++ b/drivers/crypto/rockchip/rk3288_crypto.c @@ -371,8 +371,7 @@ static int rk_crypto_probe(struct platform_device *pdev) crypto_info->irq = platform_get_irq(pdev, 0); if (crypto_info->irq < 0) { - dev_warn(crypto_info->dev, - "control Interrupt is not available.\n"); + dev_err(&pdev->dev, "control Interrupt is not available.\n"); err = crypto_info->irq; goto err_crypto; } -- 2.35.1