Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp1529409pxb; Thu, 14 Apr 2022 08:06:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzk2INbwZV6OtBZKo7voKKxRmNVeD1l7T/30EQutKvpK9UUfYmokIQl8oxaSjgCJEpNJFU0 X-Received: by 2002:a05:6402:1247:b0:41d:7932:30d with SMTP id l7-20020a056402124700b0041d7932030dmr3546372edw.2.1649948792172; Thu, 14 Apr 2022 08:06:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649948792; cv=none; d=google.com; s=arc-20160816; b=WP1nt7DMPyp3ZEDpmM2aXGmQzLeSOqpr0SzBFHWBrW8WLMzRWvPIjqqeS7kNR/RwAX RZ0vOfiAEPkeraRpubd8iu163rbsT+BFwl4GgNKY6v20GVuXv5u7WhFivnx2qYZ/3Igp 5dPKzFpN6q6QK27ep+p4VVkR5tj28CrDrV3ebifxFWYHhU43fSiKhQUAdFPHiKTCcIGR oetcc/Js2EH9pgMvb44Y3zjJ8d1+5r4AnEsMDv3eIm9CuQCsRyjSl+S5O01zfyRk6jXX Qn9OTOYfivfQswlzKFeXXVnjJEAfvV+Lv2BW29Ru08P6lCceGYteNQNnDd0OY8VymLdP +eWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=lp8gvQjqxFJE8fQp0cQEH/7CcM+iYWHSKNy4aZ6Rx2w=; b=NDtTxL7sc/QEiy8Jevk/g75XsqkojHZgyjsGIp96uJyO/3q9RM5OPRwsX+DthEDbC5 sGeQMcaJs1GitgNPiKFHoGlyF9X8D0+adEmjCOZoKrCYwaXmIiwWH+DfjaTm4Y317RDz xdBjE/rwxBfcQsJ0u6LwMixC5cBBGu8G9LZq9TpFnHIUHKiVeYMmW0gGJDWBUnf0GYog O/EvjsRl3+iH86Hq7LBrXvGo9dhxmWjr4e3QuHLSCFJClexwDU1oBgOshOuLTb06XKSQ BtVHzMdDIhLTf6E6DjTuVn0z7tHSZUZU1jSg8DULpc/O082vi2GGtvFf/7Ncj/k/r0L8 bPxQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="g/BgrtHb"; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 3-20020a170906224300b006e89718a80csi2249073ejr.507.2022.04.14.08.05.51; Thu, 14 Apr 2022 08:06:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="g/BgrtHb"; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236286AbiDNJhS (ORCPT + 99 others); Thu, 14 Apr 2022 05:37:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34924 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241295AbiDNJhQ (ORCPT ); Thu, 14 Apr 2022 05:37:16 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B4C01A809; Thu, 14 Apr 2022 02:34:52 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 12E2561B95; Thu, 14 Apr 2022 09:34:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D9B06C385A1; Thu, 14 Apr 2022 09:34:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1649928891; bh=V0Du7oRyUyAoNsyD73VGs8c8uXavo0mgfxNJb0Ar+HQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=g/BgrtHbJLQ4/pNzKYsvUe/UEZjUk04bl9vUd9zMgYHSfrw9yaSnDeEusmSIUkoPK 6L2ANTrQUrByTUgOTRgSaFJfUJWWyQwoMunt05vx60Ud+8KjMh9QASr3zG/YNgr3Bt wtpKE3Qj43dAKUXUJxZ+NtU66H+6S+M3T5lw4HI+hgdPdFhFcIfL8u7HBYkKJ4G4iH q3kVeAgAZlcRuS7qsv7iI9eBp88cTSXb1gA7+Az5bfxMK8nYPOODF3a6Ih+rL818HW rbFF72ribsA2OIDOTTZmLR2teKzdYiNNE24KIyzzzE09lJTMyDKrY9K9BGQAb4t+O5 ax36KmEmQPFag== Date: Thu, 14 Apr 2022 10:34:45 +0100 From: Will Deacon To: "Jason A. Donenfeld" Cc: Tianjia Zhang , Herbert Xu , "David S. Miller" , Catalin Marinas , linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] crypto: arm64/sm4 - Fix wrong dependency of NEON/CE implementation Message-ID: <20220414093445.GA2006@willie-the-truck> References: <20220411031313.35449-1-tianjia.zhang@linux.alibaba.com> <20220413102209.GB1229@willie-the-truck> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Wed, Apr 13, 2022 at 01:48:53PM +0200, Jason A. Donenfeld wrote: > On Wed, Apr 13, 2022 at 11:22:09AM +0100, Will Deacon wrote: > > On Mon, Apr 11, 2022 at 11:13:13AM +0800, Tianjia Zhang wrote: > > > Commit d2825fa9365d ("crypto: sm3,sm4 - move into crypto directory") > > > moved the sm4 library implementation from the lib/crypto directory to > > > the crypto directory and configured the name as CRYPTO_SM4. The arm64 > > > SM4 NEON/CE implementation depends on this and needs to be modified > > > uniformly. > > > > d2825fa9365d doesn't appear in my tree -- is this something in linux-next? > > This is in Herbert's tree for next: > https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git/commit/?id=d2825fa9365d Cheers, then I'll leave this fix for Herbert to pick up. Will