Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 15 Apr 2022 16:40:46 +0800
From:   Herbert Xu <herbert@gondor.apana.org.au>
To:     Yihao Han <hanyihao@vivo.com>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Julia Lawall <Julia.Lawall@inria.fr>,
        Linus Walleij <linus.walleij@linaro.org>,
        Zhen Lei <thunder.leizhen@huawei.com>,
        YueHaibing <yuehaibing@huawei.com>, linux-crypto@vger.kernel.org,
        linux-kernel@vger.kernel.org, kernel@vivo.com
Subject: Re: [PATCH] crypto: ux500/hash - simplify if-if to if-else
Message-ID: <Ylkvjpgzk8QbTmZT@gondor.apana.org.au>
References: <20220408142351.16961-1-hanyihao@vivo.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220408142351.16961-1-hanyihao@vivo.com>
Precedence: bulk

On Fri, Apr 08, 2022 at 07:23:49AM -0700, Yihao Han wrote:
> Replace `if (!req_ctx->updated)` with `else` for simplification
> and add curly brackets according to the kernel coding style:
> 
> "Do not unnecessarily use braces where a single statement will do."
> 
> ...
> 
> "This does not apply if only one branch of a conditional statement is
> a single statement; in the latter case use braces in both branches"
> 
> Please refer to:
> https://www.kernel.org/doc/html/v5.17-rc8/process/coding-style.html
> 
> Signed-off-by: Yihao Han <hanyihao@vivo.com>
> ---
>  drivers/crypto/ux500/hash/hash_core.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt