Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp568113pxb; Thu, 21 Apr 2022 06:00:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzOF1Yk7m7ygAc9cUgWduyQR8dbszYyKkDj2+EpIDpMpwEdR8/CjnwLBWzDB8tA8aVqqjJy X-Received: by 2002:a05:6402:1694:b0:425:ae5e:4843 with SMTP id a20-20020a056402169400b00425ae5e4843mr1594617edv.415.1650546056023; Thu, 21 Apr 2022 06:00:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650546056; cv=none; d=google.com; s=arc-20160816; b=rghyCEShljSQG8roaacAHsM6iYQiNUEwo2CygDlCkkhXvWbSHxYw/bowvKMA5P/IYl OlBXjRpMenvM2n3qDz0ube/U95P5dVd67V/TTkVwBBHG80qFF2uA8zvzKqc3rNtz2aqw ZeHhchk6pDM2gZ9DxEv8FufXS1EUl1rycAvqzDmhczA+aPkiMZHHn+Ssw8JJbYqPiVVH 3ZCJ+4j2ya12P83XMY3vslDSZmvpP0NlqAvQA504pHvcM0HtN7TjA1I3VgO2gZdE/5T9 W+4vCmYzM3Y679zub8gYSqpaMpQ9LKglRT6X23GFDNCrX0x//s6XKZBU7hwwIhGg6LOi 8tow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=RMOIbxyAltB/039toEebnPoTpBgXJ0hLpnq+ejXkLLw=; b=hQV/4HQeGs0CbskzlPiqFMnUxCRXWsJSSW4tVn2je921ItmVGoGQ6s6R0vFPwHRcgC uV/8YED2NLMlzWSz24YdAsYQ3+jDB9EheI6g1fQVFrVtLQjA/1jpzL6DUObZYlNBDhQN IV/0QP90Yp11toevG6v0fT0mXkTz+BAOtokcooM+A/d3fO7vV62xZlJpwnPRUNEtmS2X 9J+zaRcyJ6/IqlywbFu/Y9AM17unz3o+QWitiG69S+CLsXTrqms0PFhnx83yyncIfcnx 5VioOsAkSf/wX3gSwNnN1Zt7fbNEuOuV6b97cKIahxtYtWnz8DLkBwlKzg/eZYGL9Cf8 SRjA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t18-20020aa7db12000000b00423de573b40si3288546eds.286.2022.04.21.06.00.24; Thu, 21 Apr 2022 06:00:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1388008AbiDUKDD (ORCPT + 99 others); Thu, 21 Apr 2022 06:03:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1388005AbiDUKDC (ORCPT ); Thu, 21 Apr 2022 06:03:02 -0400 Received: from fornost.hmeau.com (helcar.hmeau.com [216.24.177.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ECDA0BF6B; Thu, 21 Apr 2022 03:00:12 -0700 (PDT) Received: from gwarestrin.arnor.me.apana.org.au ([192.168.103.7]) by fornost.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1nhTbY-005D13-CP; Thu, 21 Apr 2022 20:00:05 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Thu, 21 Apr 2022 18:00:04 +0800 Date: Thu, 21 Apr 2022 18:00:04 +0800 From: Herbert Xu To: Vladis Dronov Cc: Sunil Goutham , Bharat Bhushan , Joseph Longever , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/2] hwrng: cn10k - Optimize random number generator driver Message-ID: References: <20220413141606.8261-1-vdronov@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220413141606.8261-1-vdronov@redhat.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Wed, Apr 13, 2022 at 04:16:04PM +0200, Vladis Dronov wrote: > Hi, > > I'm suggesting couple of tweaks and fixes for the CN10K Random Number Generator > driver. Main points are: fix a logic, optimize a loop and make an error message > more informative. > > Vladis Dronov (2): > hwrng: cn10k - Optimize cn10k_rng_read() > hwrng: cn10k - Make check_rng_health() return an error code > > drivers/char/hw_random/cn10k-rng.c | 31 +++++++++++++++++-------------- > 1 file changed, 17 insertions(+), 14 deletions(-) All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt