Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp1736582pxb; Sat, 23 Apr 2022 15:59:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwblI/8sivcgp+O4TsAVzxXvc1TD7mPKTjQKzcMwWHoFiS9rFk7zvpLwluVyDlNBD6ho9dj X-Received: by 2002:a63:1754:0:b0:3aa:2211:bcc4 with SMTP id 20-20020a631754000000b003aa2211bcc4mr9394131pgx.217.1650754795272; Sat, 23 Apr 2022 15:59:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650754795; cv=none; d=google.com; s=arc-20160816; b=H/H+mmXaTVzzgK/kp75xio6lLWX/FRMQcG2altWtL1FEI7NaVfnC6ZZTPuTCKyXpbR BU2U0GfDuSkblBJm0NuCda6PMwTsNC/yfOOTBkydDzL3gv9nNL1+h/BHYESUjEo0uuD1 4xO5uIWxNtwaCARFVgqjXvrnqn+Yu3CSE8/zMVymAz+LTO+mssQQe3OfZS60BQmbbzPO /AXAwPo0eNMOWcpO4czM1csGvQaWzsVaceGVHnxRQoylruz49sxxijbGgrS7A5TtD/2Z C8nUVUh8wo3SzQtEXfnZYno1EyjtW8Xia7KZDlQpzj7OOYREJuxltm/Jjnj9M7cqe7/J CNzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=EhMHwAtxBeyAlPcmtZM1jKqEy31s4ZBgTOPhjm9fTZQ=; b=tA1pFMldYy/M1NrmfAzeRcMwQFOmFra8AfWI15wGTqjB+BvH+JOa+oiQQ2Om3ET8Go oSNNpLh7MIRqQAfZlfkVhMkBDWLnGcUqvfNZfe9BF202XidZT5DsqEcU3ygUptN13x6Y IUti+AzYszQ/73+Io0ufk+F9M3TYvSO7MtqSVYbtrs5oUXb/fzCdIHsFeoRXSyBZ9Zhr ff9b91XC4J++WUpkk7j9zn72cuy6/tQqJzbGfJlbr7MDYoSmNTY1MFP0R1XsRmMn9qQh /1yOhOAqABsQv98iYQrnRXC0o0LxHHpMt8FynHuz+1j5uOu0hpDqyH9G03mVUev97O2q 59+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@zx2c4.com header.s=20210105 header.b=YCua9rEN; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a64-20020a639043000000b003ab0232f393si2172270pge.248.2022.04.23.15.59.21; Sat, 23 Apr 2022 15:59:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@zx2c4.com header.s=20210105 header.b=YCua9rEN; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237086AbiDWVNw (ORCPT + 99 others); Sat, 23 Apr 2022 17:13:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232418AbiDWVNv (ORCPT ); Sat, 23 Apr 2022 17:13:51 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2277318CE5D; Sat, 23 Apr 2022 14:10:52 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A3401B80D98; Sat, 23 Apr 2022 21:10:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9FC03C385A5; Sat, 23 Apr 2022 21:10:47 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="YCua9rEN" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1650748245; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EhMHwAtxBeyAlPcmtZM1jKqEy31s4ZBgTOPhjm9fTZQ=; b=YCua9rENZsFWL50uQB+osscI/9XaYS6un4Pz4cokIHHtQLDTaqwbLPzFQk9zh+Cm1T4qRP XiJpjU8EjL+J9d8WOjRMAs3D/P14MeTzChLFa5x0mkNGoUca4l7yCPo4Kvhfr9Yry3zBI2 Km/ybmnwIzwzhyr5j46vRWCLMs6kGbA= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 78fab421 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Sat, 23 Apr 2022 21:10:45 +0000 (UTC) Date: Sat, 23 Apr 2022 23:10:41 +0200 From: "Jason A. Donenfeld" To: Guenter Roeck Cc: LKML , Linux Crypto Mailing List , linux-arch , Dinh Nguyen , Nick Hu , Max Filippov , Palmer Dabbelt , "David S . Miller" , Yoshinori Sato , Michal Simek , Borislav Petkov , Guo Ren , Geert Uytterhoeven , Joshua Kinard , David Laight , Dominik Brodowski , Eric Biggers , Ard Biesheuvel , Arnd Bergmann , Thomas Gleixner , Andy Lutomirski , Kees Cook , Lennart Poettering , Konstantin Ryabitsev , Linus Torvalds , Greg Kroah-Hartman , Theodore Ts'o Subject: Re: [PATCH v1] random: block in /dev/urandom Message-ID: References: <20220217162848.303601-1-Jason@zx2c4.com> <20220322155820.GA1745955@roeck-us.net> <20220423135631.GB3958174@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220423135631.GB3958174@roeck-us.net> X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Hey Guenter, On Sat, Apr 23, 2022 at 06:56:31AM -0700, Guenter Roeck wrote: > Looks like your code is already in -next; I see the same failures in > your tree and there. So interestingly, none of the old issues are now present (the hangs on versatilepb and such), so that's very positive. As for the crashes you found: > openrisc generates a warning backtrace. > parisc crashes. > s390 crashes silently, no crash log. I've now fixed these too, and tested the fixes as well. Hopefully the new jd/for-guenther branch has no regressions at all now... Knock on wood. Thanks a bunch for looking at this. Very much appreciated. Jason