Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp2024003pxb; Sun, 24 Apr 2022 02:16:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzUpre+5MpYbhGgiDqd4GTCmtnH5MbNElVBMCs1KZ5pOANI08LuTw4RBuFeo2zD+CetOXM0 X-Received: by 2002:a17:90a:ee84:b0:1d9:27f3:eeeb with SMTP id i4-20020a17090aee8400b001d927f3eeebmr8016894pjz.66.1650791806698; Sun, 24 Apr 2022 02:16:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650791806; cv=none; d=google.com; s=arc-20160816; b=Cn+sxmMP5qGOLzWG2Y4oZD4R4fURH/c8hCt1eJVtAY4xpaaP/cvA6iJor0mjV8MWXe NWpJP7yMlGCwC+9t+YLUNnsc40RvUKrs4VtFLFeh65iY+IJ3CLdJ50mrePYJfUFhvhiZ OQOAvmG4x1wlYalCxgnLnB0XNs04TmJbEOjyDCSSwhsfStllMSd65CifJux6OKM4isgG k1zMEasse+fVAq+MDm+YbX1dLAR0GECM7LgvMShYAGlisULKx5btlUR3lCvv7m2jdUoT tFuczi1PPf1YjzWocEn2VfyrbjBsLYBYiwvFy4O9mawzpSiXgSJNJgSlTygj509mvTGB FdPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=zz5BWAECMqgYeyzIQatgn1YdaIX48xI6Btjx4R/QQM8=; b=Yz08/oHTsROm31VC8JYCNpEwp0W1p70LktZiB1xHZ0clBDlP7OJgiOjXNT9wLbwLoq vtG+02mUOlG/zZxi4jVG4ajjv139iE9CgcnSCTZhSo0g9MFJAP1uBEq8EalGGYiqcSEt z1GuwDEN/slvgomaZNC2P4u3LmPtuSK6wMCndDoXiaEE2ZnXmTp3XsbL3IhhHeEkPcDC wZg90PFUXywZvKK6F81CAnjVoTIqpmjPswgBcIr6ldBxwl5v+xJ23S5kNWAf4CxmKNQd 9JuDX01GaTuo7Z6Wa7dqfVX3o29zKgk36VF1R5Z5Pl9gFEdnsoTr7lRYuREAKhmQpu7D /zSQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@zx2c4.com header.s=20210105 header.b=QQ7PQLbi; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id mz18-20020a17090b379200b001d26c2084eesi11946161pjb.30.2022.04.24.02.16.27; Sun, 24 Apr 2022 02:16:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@zx2c4.com header.s=20210105 header.b=QQ7PQLbi; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238652AbiDXISR (ORCPT + 99 others); Sun, 24 Apr 2022 04:18:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58060 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236121AbiDXISP (ORCPT ); Sun, 24 Apr 2022 04:18:15 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A70B464731; Sun, 24 Apr 2022 01:15:14 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 5E028B80E00; Sun, 24 Apr 2022 08:15:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B901C385A9; Sun, 24 Apr 2022 08:15:08 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="QQ7PQLbi" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1650788106; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zz5BWAECMqgYeyzIQatgn1YdaIX48xI6Btjx4R/QQM8=; b=QQ7PQLbiv6h5RMKfyhPz+0uFS/QEk6cKxIFEdT/4w1vomvJYaek1ix2z1YnXUltNn4JNWs ns72gMmUvnu2yAgEipWd73LYk7yThx0ACLC9UkoUd4mMs7onmV4qUH+mMgtRSeZCBhTJ5t iZcOlpmCAAcVo/uGzHHPVJkmoTKoYzY= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id a4e3a24b (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Sun, 24 Apr 2022 08:15:06 +0000 (UTC) Date: Sun, 24 Apr 2022 10:15:00 +0200 From: "Jason A. Donenfeld" To: "Maciej W. Rozycki" Cc: Thomas Bogendoerfer , LKML , Linux Crypto Mailing List , Thomas Gleixner , Arnd Bergmann , Theodore Ts'o , Dominik Brodowski , Russell King , Catalin Marinas , Will Deacon , Geert Uytterhoeven , Paul Walmsley , Palmer Dabbelt , Albert Ou , "David S . Miller" , Richard Weinberger , Anton Ivanov , Johannes Berg , Ingo Molnar , Borislav Petkov , Dave Hansen , "H . Peter Anvin" , Chris Zankel , Max Filippov , John Stultz , Stephen Boyd , Dinh Nguyen , linux-arm-kernel , linux-m68k , "open list:BROADCOM NVRAM DRIVER" , linux-riscv , sparclinux@vger.kernel.org, linux-um@lists.infradead.org, X86 ML , linux-xtensa@linux-xtensa.org Subject: Re: [PATCH v4 04/11] mips: use fallback for random_get_entropy() instead of zero Message-ID: References: <20220413115411.21489-1-Jason@zx2c4.com> <20220413115411.21489-5-Jason@zx2c4.com> <20220413122546.GA11860@alpha.franken.de> <20220418071005.GA4075@alpha.franken.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Sun, Apr 24, 2022 at 12:33:44AM +0100, Maciej W. Rozycki wrote: > unconditionally. I think this discovery asks for code optimisation, which > I'll try to cook up sometime. At some point too, by the way, we might also consider putting that into a .c file rather than a static inline in the .h, since that function is starting to get sort of big. Jason